From: Mike Kravetz <mike.kravetz@oracle.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
David Howells <dhowells@redhat.com>
Cc: linux-mm@kvack.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] hugetlbfs: Fix an error code in init_hugetlbfs_fs()
Date: Wed, 20 Jun 2018 08:25:04 -0700 [thread overview]
Message-ID: <869220cd-d3f0-2be9-b333-46bbfea9af48@oracle.com> (raw)
In-Reply-To: <20180620110921.2s4krw4zjbnfniq5@kili.mountain>
On 06/20/2018 04:09 AM, Dan Carpenter wrote:
> We accidentally deleted the error code assignment.
>
> Fixes: 9b82d88c136c ("hugetlbfs: Convert to fs_context")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks for catching this,
Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>
--
Mike Kravetz
>
> diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c
> index 9a5c9fcf54f5..91fadca3c8e6 100644
> --- a/fs/hugetlbfs/inode.c
> +++ b/fs/hugetlbfs/inode.c
> @@ -1482,8 +1482,10 @@ static int __init init_hugetlbfs_fs(void)
> i = 0;
> for_each_hstate(h) {
> mnt = mount_one_hugetlbfs(h);
> - if (IS_ERR(mnt) && i == 0)
> + if (IS_ERR(mnt) && i == 0) {
> + error = PTR_ERR(mnt);
> goto out;
> + }
> hugetlbfs_vfsmount[i] = mnt;
> i++;
> }
>
next prev parent reply other threads:[~2018-06-20 15:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-20 11:09 Dan Carpenter
2018-06-20 15:25 ` Mike Kravetz [this message]
2018-06-22 11:15 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=869220cd-d3f0-2be9-b333-46bbfea9af48@oracle.com \
--to=mike.kravetz@oracle.com \
--cc=dan.carpenter@oracle.com \
--cc=dhowells@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox