From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40080C64ED6 for ; Sun, 26 Feb 2023 11:45:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 406576B0072; Sun, 26 Feb 2023 06:44:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3B6716B0073; Sun, 26 Feb 2023 06:44:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 230636B0074; Sun, 26 Feb 2023 06:44:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 140536B0072 for ; Sun, 26 Feb 2023 06:44:59 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 0BE06A0C81 for ; Sun, 26 Feb 2023 11:44:57 +0000 (UTC) X-FDA: 80509261434.08.EB01D8E Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by imf24.hostedemail.com (Postfix) with ESMTP id AC731180005 for ; Sun, 26 Feb 2023 11:44:52 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=V8ljgkX7; spf=pass (imf24.hostedemail.com: domain of fengwei.yin@intel.com designates 134.134.136.126 as permitted sender) smtp.mailfrom=fengwei.yin@intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677411893; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NodspN/U7MKwAqHdMRQdrr1ERVpkxDSDJwRQ/3EitKo=; b=JyFE6d7GFNYRvHTeHz9hQJ2mHlo8R8vyX84RsrnWWapl8eEdiE/RNpA70B7486ZLGn15Vq 1hQBYFrmtZ/KVxiaSt7ZuGhCC4jEuJL1kXzzuadnwNqGgOJEGSwG6TyOekipCVQge57171 3VANiG1ytERdeOsJwlYU5oHHcCszVD8= ARC-Authentication-Results: i=2; imf24.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=V8ljgkX7; spf=pass (imf24.hostedemail.com: domain of fengwei.yin@intel.com designates 134.134.136.126 as permitted sender) smtp.mailfrom=fengwei.yin@intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1677411893; a=rsa-sha256; cv=fail; b=Aq4uDff+HIPjEdCfDxvrGjFPdsEic7oZusHlrvpKdA6UczPKOdKvrH5Y8VpMmTnvhNgi/O MXExmSuh6HaffZnY6898RrXBQBzyqqnHEx3MREiivIy81flObQHH9Fjfa5qC7z7plUnW3i HbpRkQpOhR5F9o1ecO02d3LK6hcyJY8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1677411892; x=1708947892; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=uiBLdfPH74lp9ZXlq4FXjVF1yu4Qyg/nuURNK4XFzB0=; b=V8ljgkX7p9wDxmm3CWk+w/ZjCerDev5ffqXpKtpfOJydsynxHcBl7dbI S/gl7/XbS8r3rTMtjqTe0cHx7ZpwO6GujWWLuXuX1LwMJS7LkKnba7hDJ uNyVtyDlxATyCVPjGjSstUKDYfZwjnLJsVUxDuwNxlnRC2X3iJcN0J+6H o8EaiZBmCfoFa35DMobgl4Fp0y8gv0cY0dmR9TWJPdjOlgV1EWB61HF2X 0j+Y0jT2jLiyTzmg/HVsFjhOdMDk58Lmtw5nFS+bf4JCmUO5LRKiiuR/J mYxOFMFduZT1Xy9ksyZqng2gN5srrc0af9VeHTCZmYTx01QJoxA/i11ZF w==; X-IronPort-AV: E=McAfee;i="6500,9779,10632"; a="317505399" X-IronPort-AV: E=Sophos;i="5.97,329,1669104000"; d="scan'208";a="317505399" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Feb 2023 03:44:50 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10632"; a="666666893" X-IronPort-AV: E=Sophos;i="5.97,329,1669104000"; d="scan'208";a="666666893" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga007.jf.intel.com with ESMTP; 26 Feb 2023 03:44:50 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Sun, 26 Feb 2023 03:44:49 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Sun, 26 Feb 2023 03:44:48 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Sun, 26 Feb 2023 03:44:48 -0800 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (104.47.73.174) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Sun, 26 Feb 2023 03:44:47 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KnRG8qfaihFK2rg92S1k6S/oXgW0TN1lCdZVJNObqcC5bIn9egI0pmbZOaeHRwW6h2mUCUsjiRZh3axis2v8Rke6IElvIiJgAaKjHOzy/9e3Y0TGsyiPli/12g5/Ch0qQVN0fEMG+s3u+mXfr0tnun1jiKOL7KfAT6gTyzDk+MTiILWmDsaoW+JZitENNJZIg186uxxmDfaLPZWH+RVWI2j8dy2moHvvOBOV0xPnMpo6tTg5cg5wBuCWr76coGctuTqXNAuyzXWJ/hVjC03ur5l7WK5x6kB9R6323ky8fw+BslRPT0R3coedZZjv3KKD/Q86ZEriccVNscOvilrgbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NodspN/U7MKwAqHdMRQdrr1ERVpkxDSDJwRQ/3EitKo=; b=dJNX+NdgDSqX7w7lLwOBegFMoGJnRbcqIKSN0jFANyv3omvtN84laS3Q4PL38dRW4w3FQ1q3OIMWCrRRwtlG///TBarEzBwbpZCJiBrVXKLIqWhXJiLw4XqLR+UFI/rzQSwhmAKmu8eaCzDkMOHhirXbKTN9jErOP8ddGl5XhnHE53l+kQr1QQNzBYjndqjKuExQN7PKbAFNAyL3z9f3ZxXp0z/GY4hcySX/p2XeMvO5TtWFtOZn1dbjJRVT5xpjNMd2cPlXoGP24tO5KKfU2kTXIv20b8PgC0uZvQfo0SdKHPOKCP2P7ol/jujtcicg8HFn8UiFR2V0WO4QbHPzhw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CO1PR11MB4820.namprd11.prod.outlook.com (2603:10b6:303:6f::8) by IA1PR11MB7774.namprd11.prod.outlook.com (2603:10b6:208:3f2::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.25; Sun, 26 Feb 2023 11:44:44 +0000 Received: from CO1PR11MB4820.namprd11.prod.outlook.com ([fe80::8073:f55d:5f64:7c6]) by CO1PR11MB4820.namprd11.prod.outlook.com ([fe80::8073:f55d:5f64:7c6%8]) with mapi id 15.20.6134.026; Sun, 26 Feb 2023 11:44:44 +0000 Message-ID: <869157a5-aa47-1d1d-328d-a40df2981326@intel.com> Date: Sun, 26 Feb 2023 19:44:35 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.8.0 Subject: Re: [PATCH 1/5] rmap: move hugetlb try_to_unmap to dedicated function To: Mike Kravetz , =?UTF-8?B?SE9SSUdVQ0hJIE5BT1lBKOWggOWPoyDnm7TkuZ8p?= CC: Matthew Wilcox , "linux-mm@kvack.org" , "akpm@linux-foundation.org" , Sidhartha Kumar , Jane Chu References: <20230223083200.3149015-1-fengwei.yin@intel.com> <20230223083200.3149015-2-fengwei.yin@intel.com> <20230224025119.GA1911853@hori.linux.bs1.fc.nec.co.jp> Content-Language: en-US From: "Yin, Fengwei" In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-ClientProxiedBy: SG2PR04CA0166.apcprd04.prod.outlook.com (2603:1096:4::28) To CO1PR11MB4820.namprd11.prod.outlook.com (2603:10b6:303:6f::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PR11MB4820:EE_|IA1PR11MB7774:EE_ X-MS-Office365-Filtering-Correlation-Id: fa6a9724-0c29-4ca8-c15a-08db17eeda5b X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: K+dw3cQOPMANbkbQIL+r9jqLsKQ5oI9CVQAZ1iImRrqKwgQWb9MjkKfetrRvE5QCerjN5+fF3QhYrSQYE6qrUdziPSGmR2mACs3VthcbSOeltrBYH93pNP3B42Lmx0ucE/0y8mrb/GjZOh0Pc8xM0NnKthysA04J0O5m4oZZrZ60fIOirM4B9RclZkn+UiqCRxZe66h/HkwIqn3tHjcV/Z9OJqJ8Q9X4qkthGUnUme0pLhs0nPbvdqJkpWnc5Cgpy8qa4w4oSoLiJdkjpdTFuzlwcCLZ3fjfqe/PhpsywyDjMNkMBuXrTe72OG1gzneka2CawCde5cpv5Mjm/j51NAfg6oXBiZm8mW3rFDrfXPrHxiGV9IcCHftIIYCJafF7uBGH8/aFSM6oaCYR8BCnGUuLgmB43fzKyhO84zpmwH/FyvocRQ+xSy+isFgmt9vnVbTVi5hy+/l1BHFARDLiX+TeFGBuNfEeeRvPWw6SHY+Jf/K2cAFP3kea58/6RYV8noeQpFcVuF+w9Hb/FFQg2Mr1i/M1NS17l0j4Z9t1qhobZlWwPrTn8HuXQpB/XsmBxiwwGQ9tiaYKJzvCyvpStqJnVVWTA/lUjZAtHjzWCYrmNeV0dwVz0YeDgCyPiwLM4QGCjyjHtvfYYPIAn3kCHsTgy3tbEo8A4k5OPQk/VZiR9n16RW/tx67j0igK6x9368rRLiwuny8pmUWH8d0Jv96plJoYP/uURivgbbKYiwA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR11MB4820.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(39860400002)(376002)(136003)(396003)(346002)(366004)(451199018)(8936002)(36756003)(5660300002)(6506007)(53546011)(38100700002)(6666004)(82960400001)(6512007)(83380400001)(2616005)(26005)(186003)(86362001)(31696002)(54906003)(110136005)(41300700001)(66946007)(66556008)(4326008)(66476007)(8676002)(478600001)(6486002)(316002)(31686004)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dkIwTTYzSWNtVFo0d0FwRlJFbDBrL3pHQ1N4VThBOWJwN2l5dHNPc1BkZ2Ix?= =?utf-8?B?UzkzdmhMRjV5cE5WbHhBc05aUklTK2JGQVprOFZqQjdjYitRWXlvNlpnMlRD?= =?utf-8?B?STBpQSs1NjIvVXpRZDZVUG5nejlaQ0dSUUQvMndkbXVRd1U5TjNSd0FvT05x?= =?utf-8?B?Sy9SRWlaWjlXN2M1WmMxWUZ2ZTZmU0Rhc084NEJMY0RzVE0wcXdsaDlKVUxi?= =?utf-8?B?U2hLUzdTdWlOQVBPdE9GSU1jVWV4NkhJRFpTSDZrYWdTU1drQ2FGSXlnRk9N?= =?utf-8?B?TTBOL25FM1VKbnVJbHV4MUxNV1FTN0tjdkp1cDRHa2NTa0FFTEdKRU5DTzFi?= =?utf-8?B?d1k5dStVZVpPMkdHUkh5N2RzdUNqdHRVdlp6SWhkOEp2VGpuRk9ta2RmV3ZL?= =?utf-8?B?NjErWG9LVHhQY1Bvd0hMMXp1MGxDV3V1RDdMMFRlR0xxZmw5V0s5d3FKcDIx?= =?utf-8?B?KzJlSzdabnRNaWhrbFY5ZW02b2VsNXFhV004Rnlod2hWOU5hNEVHTzFkZFB2?= =?utf-8?B?U2FQL0crQlpUaW12YkxHQkN1bjl0S09GTlAzWFFiOGxyK0tQMUN3M0dBckZT?= =?utf-8?B?NVlSWkNxem50SDNNRTJDUzJmeHltVVZEVzBzUUJ5T2VNdVpVVkFySWpFci9J?= =?utf-8?B?U0huQkFkNDNXUjVFN1ZzbXNEVWlVYXpMRnBNbmZ4TUo0R2x6OW5qR2g5bEVa?= =?utf-8?B?RUtCUlo0NlpEYVlkalZTZFRIV1pnYnc5eXplc0c0QzNUYjlRS2NiQ2FvNUZJ?= =?utf-8?B?Wnk5SUk2d2xCMHdCbitkcnBRK1JVakJicjBUcHNnTUUwNnhPeDNtWTlKL1NB?= =?utf-8?B?eWRaQ1FTYVpRcDJoVmJlNFRjRFNPOTJqZnB2MTg5SUpZRTk3WVhubzVBTXlN?= =?utf-8?B?bDFTMnVMVlV4aVBlaW9BZUhsVEtlcGZJUmlPZ0Yzby9oemU1ZjFwY0V0WUVC?= =?utf-8?B?UzhQc3c3TWhnL2grWXR2V1VZUlJ1TkI2bEFNa1ZDT1ZmUDFYNGd4M3RaMnJ0?= =?utf-8?B?TlZBNVcvVHdnTDFFa1ZXQ2x6RXdjcmVRa1MxVDhGWEF0U2UvVkRMSW1uMFh5?= =?utf-8?B?RDkwM0ZZNDBQeGhySVV4RHpHTit3Z0R3QTlNdzF2S2pMYjdiUXE2M0llS1Ri?= =?utf-8?B?TEFkdU1kVmtML0pLZ0RSV2xVYXMyNzdZb29MUFNOWGtJOEhCQ3JQaVlnTEhP?= =?utf-8?B?eHpRS0Zwa3hXQ0dlNk9GL1lpU3dyY2E1NFk0SUNON2dFNTVzdDc0ejNJL1hq?= =?utf-8?B?UEd1NVJDS0VaQitYSFVrRVdLRFVZRElLTisyN01VMitBNFdkczdocXNVcXRE?= =?utf-8?B?bmMvUG1uMTlrbG04bEdVeW1QZGJrTGM2WFZuUUczZVNlVUVjOThnc0phYnVR?= =?utf-8?B?TmdmdGNPb2xjV3BXZ1hnQUE3QnVqMDBYakRLalpUeC9qR2ZTM01JcDdTRFdQ?= =?utf-8?B?R3ZOSDY0OXBtZHhOa2tlZ2cvVU5mVDVadE9tWTdmRzMrVjRTaG1HQlpsYVo1?= =?utf-8?B?R3RlN203U3BtSFlFMlhtaGFiN1ZUT2gxcTM3TUJZeW05UDdwS2RsQml4UmRI?= =?utf-8?B?bDRoMjNEZjUyekVIUEp0Y1RibUZ4c0pqVndoZ1dXV1N3aU5FbkxXY0ppSFlO?= =?utf-8?B?aitPVUNyWjh3Y09XUHdKeGlYNDIxQjdPMmltcVpSM214MWxoQ205dEwrclhw?= =?utf-8?B?dGxKWjZkdGxlMXc3OEpCYTFJTHVsMk52QUlZOWdhM3RORVQ2TEJwcDl1Y2Nx?= =?utf-8?B?cjlQNzNlb3gxQzlnZVQ3V2swaEhSMnBhS1lBNUo0N2IzckJ5bWE5SGJjQUlx?= =?utf-8?B?aENoN0R6eHRsdjFFTnVENzZCM3l2Y2Z0dVoyNXBsRzhRNEFlMEJKOHBvNWp5?= =?utf-8?B?NkVybXk0MUNBMys0c1ZWNE5nY2VrRWx2L1pSNGpZSk0zZ21BakxmQVVSNGdJ?= =?utf-8?B?bTJxZzBFNWgzT2FJcGV5YmEzK0lNTnloclhyeDhOVUh4MkMvU1BpVkhVQ1F2?= =?utf-8?B?aXR4a295eFFCTFNzR3MvSGNvR3k1QklMMmV1YUlKYlh3NEhWVmszS25GMlVM?= =?utf-8?B?cWlVbkcrU2VhUlFZVWVISWE1TFU0SUJ6MGYzMVFKRmNINWZ4RlhuNllQUm8x?= =?utf-8?Q?LruwmEwhYy/oXnNh9UOc+hEeM?= X-MS-Exchange-CrossTenant-Network-Message-Id: fa6a9724-0c29-4ca8-c15a-08db17eeda5b X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4820.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Feb 2023 11:44:43.9934 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: RyhWdtYi2YuMiB+Mha3bZEJW1t0jI9awT8/B3KxinlMC+M9ywdejQffs3PfHd+6nCgTP7ZLmPieH56qap5Rs4g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7774 X-OriginatorOrg: intel.com X-Rspamd-Queue-Id: AC731180005 X-Stat-Signature: fa7sa766ic9mne3soxph515xkynzcdzj X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1677411892-520303 X-HE-Meta: U2FsdGVkX19F7oNR4E1CYjAfoRnY2PsgI6Sdy1OaTdozZUfkAsgeK+qP2+QIAtaxvInPYfb1El3hlreGNORJmmc6ygpzRUI8qKw095L2Py8xw3hLK7PhWt8w5Oemu7FaWJyp0R3BSg8HhUaiYFZhDhZ+w7vCWoF6eBVmgX2iN5Yiu94ZebrSLtJKh3RIhh79Bv+fwCEQLtTpW3aqvGr2Ne3vzXM+ccg6KQkovJuNXrwXmv7hwdJTGx+Fdu0IeexoG1bmLcBz8Mf+A2gTh2Z8B9jx6WIYeqetssdG3lMa8KMXXy+xRKQch4QjwV36CDFaZwIhSz0Got896bQBfSgs9enWrIkIIdVL0hYlubGvdObjX92vPA9aQoB+vFXQbjXty/e1PDDGgxSb++2mQXUJ57kC3ms7YoP5Q1AG2fN0s0v0X/EwmOikAIFZRPxf3C6EH7zaVFzfCce2Ig+mKtWI/d5PyFkA54PwBPk/qinol025rzz0AxAp/9MnJjMIyauaLWj6dwWQ87/EIOzTLRqgOiEMr2utNWZJEiHNRPzclGlAPEjBwqW5Nj61leYnd2f4NKOqq22N7u6bqNRzkTb0PXRw+ZUDn2+xfNk5AaPfeVS6+GKSJcIQNkBTj/pURurh0myAdv81SfNxeraGezd1pWdo3zzWSovQv691M9y4ZbPguf3IrMmBaQckJfxlFqjKBoLc7w8q7WJQp/ZpqSy9wGo2ufynKtvTL0Gf5v76k8LMzb2KAaQN1GvyENkysJEpyx2RsS2Em12InFrc3jYrt347YcX3rdNBRgRncsRgGO8hIVX6KTbcqQ4BTW8sEAt4JsBheZ9fFI3MEtbNJ7AM6hmq9mqcqoiDJaRPV0gz/vgdZYeTxeaZrI/CbBBjz87q1VKchg/lsUw/L5i85/GOw3Lzkev3if7fKTeJxIbEqxx36nUeSavjW/tnL9ZtA8I5erk0exEW66k/FMvj7UC O2sxmimK u6ve5/1gdR2tZ6yXH0Cx0MvVXljufnT2ChF2L0AKs0gLAdZbgO1OAQOamSfxa94AyKfLPdn8g7fNhIGanrOLAb/dWHal1TEr/uVc/WBLHhZZkdtfQ3CJTRcywWHFryPZSeXOxu6uj75z/c48feeCp/O8XpiHaLl5RKeOJYQqOecl63DaZ/LtTIK/PlLSdTCP8n+uXgYiQTJhrOHP1OnEv6kwtKC1G/f/wY08x2eDGTka84MXVmqECca55PnrV8Im3jVP0Xi3QpT/Fu4ppts0NJVEBE3YJtwqR3BHcNSSBavxDD+j6DTA04Jyz/9SRNr65LtDw3uoQA3CTV/R504sQRleYfnN2N/Z7Xy+NirNExoJo7KAwRh9usEhaxJtJD62MQBHv X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2/25/2023 3:21 AM, Mike Kravetz wrote: > On 02/24/23 02:51, HORIGUCHI NAOYA(堀口 直也) wrote: >> On Thu, Feb 23, 2023 at 05:28:10PM +0000, Matthew Wilcox wrote: >>> On Thu, Feb 23, 2023 at 04:31:56PM +0800, Yin Fengwei wrote: >>>> + >>>> + if (folio_test_hwpoison(folio) && !(flags & TTU_IGNORE_HWPOISON)) { >>>> + pteval = swp_entry_to_pte(make_hwpoison_entry(&folio->page)); >>>> + set_huge_pte_at(mm, address, pvmw.pte, pteval); >>>> + } >>>> + >>>> + /*** try_to_unmap_one() called dec_mm_counter for >>>> + * (folio_test_hwpoison(folio) && !(flags & TTU_IGNORE_HWPOISON)) not >>>> + * true case, looks incorrect. Change it to hugetlb_count_sub() here. >>>> + */ >>>> + hugetlb_count_sub(folio_nr_pages(folio), mm); >> >> I have no objection to this change (moving hugetlb_count_sub() outside the >> if), but I have a question related to this. >> >> Generally TTU_IGNORE_HWPOISON is used to control the pte-conversion based >> on page dirtiness. But actually what it depends on is whether data lost >> happens when the page is forcibly dropped. And for hugetlb pages, that's >> true regardless of PageDirty flag on it. >> So I think we can assume that try_to_unmap_one_hugetlb() is called with >> TTU_IGNORE_HWPOISON clear. So maybe we don't need the if-check? > > Thanks for looking at this Naoya! > > In another reply I asked about the possibility of that if statement ever > being false for hugetlb pages. Looks like that can never happen. I went > back and looked at the memory failure/poison code just to be sure. > > Yin, > Since we NEVER took went down the (folio_test_hwpoison(folio) && > !(flags & TTU_IGNORE_HWPOISON)) not true path in the current code, > perhaps we not need the comment possibly calling dec_mm_counter. Sure. I am going to remove this line and the comment of mm counter also: if (folio_test_hwpoison(folio) && !(flags & TTU_IGNORE_HWPOISON)) { Will send out new version after few more days to see whether there are comments to other patches in this series. Thanks all for sharing the comments. Regards Yin, Fengwei