From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50B51E77188 for ; Mon, 30 Dec 2024 07:48:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6F3A16B0085; Mon, 30 Dec 2024 02:48:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 67DC36B0088; Mon, 30 Dec 2024 02:48:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4F6EC6B0089; Mon, 30 Dec 2024 02:48:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 2EA0E6B0085 for ; Mon, 30 Dec 2024 02:48:47 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id B9B591203FE for ; Mon, 30 Dec 2024 07:48:46 +0000 (UTC) X-FDA: 82950847644.05.B9C663E Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by imf23.hostedemail.com (Postfix) with ESMTP id 7D606140002 for ; Mon, 30 Dec 2024 07:48:13 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcppdkim1 header.b=eEKagQuo; spf=pass (imf23.hostedemail.com: domain of quic_zhenhuah@quicinc.com designates 205.220.168.131 as permitted sender) smtp.mailfrom=quic_zhenhuah@quicinc.com; dmarc=pass (policy=none) header.from=quicinc.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1735544889; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9lBMs0Ul5wQCiw8Sc7Z2zieC30Xesh+V0rLSxzovXSk=; b=2FL8jQrAFijiOUUmejhtnKgUvZlqrcIEmY05d+7t7G+1pmHck6iVMSDnT/hgu/yAIIldwq kTVSxMtS9KOH1Jus0WX4niL1cFKFDwczPXJzLJyw48GVaPG9bHOb0oTHniQn3qEPn7VN1x H9nucxnOj8pC3ivMdGFCVniNmCqWfLU= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcppdkim1 header.b=eEKagQuo; spf=pass (imf23.hostedemail.com: domain of quic_zhenhuah@quicinc.com designates 205.220.168.131 as permitted sender) smtp.mailfrom=quic_zhenhuah@quicinc.com; dmarc=pass (policy=none) header.from=quicinc.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1735544889; a=rsa-sha256; cv=none; b=SHKIsRRSQSdaFhZ/FNErHxn23iPHQ2uSOXps/j0IY17L21bywbLXeKbS3qCijSw903nwOO 48Eu8uBCwNkPe93sbCIRykoetYTNAsgimPZ8YdT/RGOdX5tpQ2kzG+BJIAPyx8oBOk4vaq MED5PgCOQp4T2w8r09sI0z3McvvoPco= Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4BU7G9EF027922; Mon, 30 Dec 2024 07:48:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 9lBMs0Ul5wQCiw8Sc7Z2zieC30Xesh+V0rLSxzovXSk=; b=eEKagQuoKHFeLYmv +5rAlpvEkTrmQJKObjSHAQvteoakjIEOD1R452rvBxZho5m0BjdB0C04K1ALX4rQ 9o433NgW368Y5MpuLea0TOH8sqgZByi3EVpTXM8l+F4E5Qu4zKzgAWu9dk43O79k oSSlGiRm9VbJ8r72IKU8c2icP2lapDpOG33wEmW+IbNWjGsJmVj5uowwvzxepy81 dmiiDWjyLoqVKAogFlvRDvMmCNs7WwfzQAxPr6UQHEA5zpf3wiXQsOT0lnXWhTmP TlwLKVdw8zoacdocd9jgWq3KHNTPP+gbXgUww1bZWLheau8hAbpNvAIXsl631JUY cn3Iog== Received: from nalasppmta04.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 43upyr81tk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 30 Dec 2024 07:48:38 +0000 (GMT) Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA04.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 4BU7mbds012157 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 30 Dec 2024 07:48:37 GMT Received: from [10.239.132.245] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Sun, 29 Dec 2024 23:48:34 -0800 Message-ID: <8685ca94-1382-45c0-a3c3-4b5ccf244057@quicinc.com> Date: Mon, 30 Dec 2024 15:48:32 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] arm64: mm: implement vmemmap_check_pmd for arm64 To: Anshuman Khandual , Catalin Marinas CC: , , , , , , , , , , , References: <20241209094227.1529977-1-quic_zhenhuah@quicinc.com> <20241209094227.1529977-3-quic_zhenhuah@quicinc.com> <39a85800-47c5-4529-906d-5a40e58ce136@arm.com> Content-Language: en-US From: Zhenhua Huang In-Reply-To: <39a85800-47c5-4529-906d-5a40e58ce136@arm.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: 05vQ5z3ocu6WtEGIJq_QrSThdYzcr5BL X-Proofpoint-ORIG-GUID: 05vQ5z3ocu6WtEGIJq_QrSThdYzcr5BL X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 malwarescore=0 bulkscore=0 lowpriorityscore=0 mlxlogscore=396 adultscore=0 clxscore=1015 impostorscore=0 priorityscore=1501 suspectscore=0 phishscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2412300065 X-Rspamd-Queue-Id: 7D606140002 X-Rspamd-Server: rspam12 X-Stat-Signature: jt6phd3ppd1euqimq18a9fo55qbwn751 X-Rspam-User: X-HE-Tag: 1735544893-610897 X-HE-Meta: U2FsdGVkX1+lqA5jOjxrnUvOXtX54i0wntRQOBUxJwof3JVBOcH50iAIBLoDg9qP35QgPz2iqrMQsI8J1DqiAOqJAsDAJTaRgTu8gzuBtvTD9hUMIWEJKDVjLxeJkbj7JSBAnD9kztalILMMU3jAvxcLKzRVO67JZbJFzF2OAVbq7IDrXrtn2bYnZEDtg7TuyR9kpJMD+xVIpOfIVEKIgXV/m0aRdChwRnYLdC13mfWE+LyVGOZt9lx9N6MSjQUyY/0zAy7I2mAHLC8hfhoHra444NY6dzNo/sSPoObsPGGxkxZXmPD1aWFX0W7BDAbxCc5jxH2ydezwYlaIrzWkAKXqDKKU0UecymPVuGnX2ZVpiVQrHEYoEqKGmD4Olg1wOFPqMkUu1KQn7m/KlFC43TUWd8HICy7lk1+3lR+cX+rpqYZetTFVIYyHy9y0HwM4JrUqJrRdrS2FdvWhNg2KYfVDPygpxV3gtmcEyf82Dwig/arJl86ZFf7GSfj5i1lez8eCW7J89mZrfsnUnQ4PBR36ULDV1cuOFFO+V7knzVU3YmHzlUP/84TJ2yRz0kJbU2eZD5eOZZ2aOXPUn5VMZq/Xv+Agn0M/InBeBJBrOqauWyFTad2fFy4n8Rezc3Ae43K8raQQOPuoR2iHqSJoD3at2JaqtmtnsfHCacZi5AWIOJIMJU4w13j/ROLbgLXmiEp7WHpueGFsO2ZDyAvkqTv51s7NCkHgWzlMrZg7I/H0fz3jIXpvJG9+y9u0otEWVA16rkFozL66Ut6qIGInsTHehav5MGH93nG3BMz8GVzXPs3QlcC2QSkaR40eVD85Tcyj9aNM2zsPPyigId2L6/yAFInzI8KtV0Kna7d9wVfghz1zmIZVAtXzj45EC5TE1AIu9SKPsCWa/iVsNZHE2M4K/FH/cZwwrz1QjvPUg5vWVlFYb8box8VYgcvR0d5x/HpAlCVFuJgDrkyWKQK 7G6c+lwq GfolX62ARbKK+HBIn82MBou/VyvfHHFdtfhiK3hL5WgkUm3NQvKtbJ+jA3yBe50syHCha1XTdl+XzWEYSgghx6HOoH2XzcIXKxV+LNJchtFY4VUNfs0gKpiRmKa4ykZqb3iANu2zWcrajOTSZ1/DGKyZo0MipIHUDO0OUymBOL3MEmQWzM501GQwy4Gc8ZeCImGrf3ojY8bibZ3gKy16D2a2Ws3czwORbT3yyKbNLm1SC9PHHBR/iITpGVJB+XU+ktEEsGkgzpr7f5HXXxuamsnpSt4iV678CQxNoZcixl7KSFx15cO30+XUQ/wWosdZom2gsH9Om/7eguMfwDm5+Qg4wX9bbNLRsXIc0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/12/27 10:57, Anshuman Khandual wrote: > However it does not really check the entry to be a section mapping which it should. > Returning pmd_sect(READ_ONCE(*pmdp)) is the right thing, which should have been the > case from the beginning when vmemmap_check_pmd() was added. I guess because arm64's > original vmemmap_populate() checked only for vmemmap_verify() as well. So probably > this does not need a "Fixes: " tag. Hi Anshuman, I agree, will remove "Fixes: " tag in next patchset