From: "Yinghai Lu" <yhlu.kernel@gmail.com>
To: Jack Steiner <steiner@sgi.com>
Cc: Andi Kleen <andi@firstfloor.org>,
mingo@elte.hu, tglx@linutronix.de, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 8/8] x86_64: Support for new UV apic
Date: Sun, 30 Mar 2008 19:23:07 -0700 [thread overview]
Message-ID: <86802c440803301923m29b6a0coca7f61975331cbe5@mail.gmail.com> (raw)
In-Reply-To: <20080331021224.GB20619@sgi.com>
On Sun, Mar 30, 2008 at 7:12 PM, Jack Steiner <steiner@sgi.com> wrote:
> > > Did you test it on non UV_X2APIC box?
> >
> > anyway the read_apic_id is totally wrong, even for your UV_X2APIC box.
> > because id=apic_read(APIC_ID) will have apic_id at bits [31,24], and
> > id |= __get_cpu_var(x2apic_extra_bits) is assuming that is on bits [5,0]
> >
> > so you even didn't test in your UV_X2APIC box!
> >
>
> It works fine on UV_X2APIX boxes because the double shift does
> not occur. However, support for UV_X2APIC is dependent on
> x2apic code that is not yet in the tree. Once the APIC
> is switched into x2apic mode, the apicid is located in the LOW
> bits of the apicid register, not the HIGH bits.
oh, so that will need have new version GET_APIC_ID too.
YH
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-03-31 2:23 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-28 19:12 Jack Steiner
2008-03-28 20:15 ` Ingo Molnar
2008-03-28 20:24 ` Jack Steiner
2008-03-28 20:45 ` Ingo Molnar
2008-03-28 21:08 ` Jack Steiner
2008-03-30 23:22 ` Yinghai Lu
2008-03-31 1:33 ` Yinghai Lu
2008-03-31 2:12 ` Jack Steiner
2008-03-31 2:23 ` Yinghai Lu [this message]
2008-03-31 2:26 ` Jack Steiner
2008-03-31 2:29 ` Yinghai Lu
2008-03-31 2:40 ` Jack Steiner
2008-03-31 2:06 ` Jack Steiner
2008-03-31 2:13 ` Yinghai Lu
2008-03-31 2:23 ` Jack Steiner
2008-03-31 2:27 ` Yinghai Lu
2008-03-31 2:31 ` Jack Steiner
2008-03-31 2:02 ` [PATCH 8/8] x86_64: V2 " Jack Steiner
2008-03-31 13:07 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86802c440803301923m29b6a0coca7f61975331cbe5@mail.gmail.com \
--to=yhlu.kernel@gmail.com \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@elte.hu \
--cc=steiner@sgi.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox