From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16728EB64DB for ; Tue, 20 Jun 2023 21:21:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ADBA08D0003; Tue, 20 Jun 2023 17:21:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A8BE78D0001; Tue, 20 Jun 2023 17:21:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 953438D0003; Tue, 20 Jun 2023 17:21:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 8358B8D0001 for ; Tue, 20 Jun 2023 17:21:15 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 5AD5DB0045 for ; Tue, 20 Jun 2023 21:21:15 +0000 (UTC) X-FDA: 80924396910.10.3B297CC Received: from mail-qk1-f178.google.com (mail-qk1-f178.google.com [209.85.222.178]) by imf01.hostedemail.com (Postfix) with ESMTP id 7BADF4000B for ; Tue, 20 Jun 2023 21:21:13 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=joelfernandes.org header.s=google header.b=xVQxFtvI; dmarc=none; spf=pass (imf01.hostedemail.com: domain of joel@joelfernandes.org designates 209.85.222.178 as permitted sender) smtp.mailfrom=joel@joelfernandes.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687296073; a=rsa-sha256; cv=none; b=xzQ6tkbRHDU6cS8eRqEKnPPmUVBn1W98STRokMchE4Muzz9O59o6sdPZH9DpUlIiJzfLzl +sRrQ+A+E4QM/7eAi34eqs2ZrftVbyq2nQhT3uxc+WAMwhohYDatjFntOE6bi+JwuI83XT giCMuN81+v4sEosD8LM/CNlVn6KZ0+g= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=joelfernandes.org header.s=google header.b=xVQxFtvI; dmarc=none; spf=pass (imf01.hostedemail.com: domain of joel@joelfernandes.org designates 209.85.222.178 as permitted sender) smtp.mailfrom=joel@joelfernandes.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687296073; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5jcP/rm05RrInHETkeFjW0Eo/JiIhtFou4XrWSAd+wQ=; b=uWOQTYn4vBI26p3je3smXGkr9FxqFIK+OGqmvt1DjZBn/bo8Wb3d4cVUnBIz7HBbfiJxQM +Ek0dhkhP2e+buwSYS7v9MObs3DFjKyiJc+OeBvJlO36gS/Nz1o81TSiW4ao47j6VVuohN ci5B/bFg1drmFF6x+Otj0Gnf7kGSJj4= Received: by mail-qk1-f178.google.com with SMTP id af79cd13be357-763a3699b9aso187066885a.2 for ; Tue, 20 Jun 2023 14:21:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joelfernandes.org; s=google; t=1687296072; x=1689888072; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=5jcP/rm05RrInHETkeFjW0Eo/JiIhtFou4XrWSAd+wQ=; b=xVQxFtvINCiFD58bFiHYe1aaNqyDHDsRvXUtLyBCZQ4OLf5LG+wj4dz9IJT7bARDm8 bndpbFIdIVhYMIXyn2vhnHPSX95zDd62o17nMugqLgSeM2YOobMUCCAS1Ip1HLcN+ESg nhyfiD/0m3FoPIOECqAJa4v472BYsAo6epunk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687296072; x=1689888072; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5jcP/rm05RrInHETkeFjW0Eo/JiIhtFou4XrWSAd+wQ=; b=OgFvsB0yMSjQu8B89EXWUYoWWZ8S9BgbQaQyVaGCFNJ4BtO0JAooSWiJ06H3unv938 47SM0REaDh64kQzEROvjwYdS13uJiBtEnna9K954+X3a6FaxAap40tt+Q7Mdn6Pk+4Hr nb9hRMMlgIeCbUtofoWjeUT78dWfOFRqiJ/X5mRK97jrYzrXl4G9sE/m+Pa4PjX/cAVl E0Xr0JN0k0NvUSq/x7BPiEWt6qIYaG/+e7fzoYwUnp0lI5G/adY2gc5NEVGInDsSS5xI PrL/GL7o+ZcMwdIXGUGN/ZhgHlRhn5nntMBEh2pHLjhqsbhvr4KA+TO8lFCjQ8KMame9 IFrg== X-Gm-Message-State: AC+VfDy/UVjzKRPrWY0CQv/Ka+XBQIeR09tDY3RmfmILeacCQIHhwUNN VZ21QC4XLU2+XJU8WsWeeJ7jow== X-Google-Smtp-Source: ACHHUZ4JrLF0b4oOsT9kMCPcCqgqzM5+OfFosKmIub96E+yaPuRpcx9m5LtP3kwYacB3vbBCwaTVGQ== X-Received: by 2002:a05:620a:660a:b0:762:3a20:7719 with SMTP id qf10-20020a05620a660a00b007623a207719mr12345317qkn.18.1687296072551; Tue, 20 Jun 2023 14:21:12 -0700 (PDT) Received: from [192.168.0.140] (c-98-249-43-138.hsd1.va.comcast.net. [98.249.43.138]) by smtp.gmail.com with ESMTPSA id l2-20020a37f502000000b0076087149a19sm1512897qkk.83.2023.06.20.14.21.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Jun 2023 14:21:11 -0700 (PDT) Message-ID: <867bd9d6-1d00-0d9d-368a-8224cb40a505@joelfernandes.org> Date: Tue, 20 Jun 2023 17:21:10 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v4 1/7] mm/mremap: Optimize the start addresses in move_page_tables() Content-Language: en-US From: Joel Fernandes To: Lorenzo Stoakes Cc: linux-kernel@vger.kernel.org, Linus Torvalds , linux-kselftest@vger.kernel.org, linux-mm@kvack.org, Shuah Khan , Vlastimil Babka , Michal Hocko , Kirill A Shutemov , "Liam R. Howlett" , "Paul E. McKenney" , Suren Baghdasaryan , Kalesh Singh , Lokesh Gidra , Vineeth Pillai References: <20230531220807.2048037-1-joel@joelfernandes.org> <20230531220807.2048037-2-joel@joelfernandes.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 7BADF4000B X-Stat-Signature: jnhcry83osdmzyu4a74gji6dpngyuifz X-HE-Tag: 1687296073-334787 X-HE-Meta: U2FsdGVkX18NhJbsfnG0A20eVqjRAqGUhgN14eyxB8532dAIV73nI7LkLD07Kwe0fAp64ZWCoTEHcyKiGetCMPX9tT3iPRSLJjSNqC2VxCEWcsnfoxXOloixY65OpABXVFp8UX0QBmdvwPqaxBoiwAQAi5RZATRE2sg+YYYTFFQFQ/xHTgrPhhAN8qk3feg0zvLNvuPbEd0TDwVocVKrKmn1AhNoMFWD9dWhVtk5FKI+Srg2mLbdrm5DeD25igKnIPdHanFpIE34Yx+QRHDy2Ct4EQWEArdqnThAEGRZc7k2JFtAiVKYtj5S9gesauWAHBgH6YTRJz33+C/iTarRKobGnCCROQDb2ubU2vHi3aWvfEyJ50bSLGGgLBoB5NdbbDINwkcrGP6Sey8a6/1Wbxc4ULeQehmYIeBISSIpHEpWJftX0vvXLrnlysPLhk36jtUwCjQAlq2y/92X0kZPHKQqEsqqsRcLCWa3agyvoI43PO8yG6L+OywStH1yH515CJxhvsGiHTGAcrrNpbHSiLBPkfQDCDq5yGdhKzELysCHEYIGjF/sm358eHDlbEr5wphLo6vi7xRYDy1ddT7qSe7kkEw1IEmnDRTvofCJ5jaxa59gHPOh5067Ja1G4QOUASiEkrFeB/COQEXuHwfowgoamBMvbfX7sGqTSksXcfpwBHbQr/adTbagmR+IZbybFhKcXxni2C0h92BTHAXHUG1QWFrVgrgJDUqME9GoTdiK01nn9aON0Dm3rjyGcr3qgv98ixowHShGa91ZM8XVNtiV5NX+oIeYK8PznJNLXtC+R/86HD4CJ3KQjzMAm+spOfPbT5a/w2DtxHi95DuLOis9V63P+8GTdPPjuJ4kIbMuQaRgBxpW7n36/O3T94uTQWAZvJdnPjDVXT3Izv1/FOQa7NkFVirrJDlDwGyQ9tme7axVuqmXemE7YuTvQTNdVC3/WZQHAdCq4m3VeIy jL5Bevyr vbU4l+qMcWfXNOEodF7ozhhP0Tc6XVpmF6Drvln/EK6j9fRieOJPr8bhn+2VruJknCl3cq1L0OY73vlyLmyCDln1GyvGg6VU31LvoPs3L2cNlx+6hdpB6K5Og1RLe4qijrJs154VqWZ9N9y6psDD/pX+2hcuNQgtDu1LwMbcnyNwqUhDZr4k/0AIJL4lS5LNjIQtuMOfhnIOsUSzpWhAqbn9oAME7Ad52BoKUbtg9pbXhifPVG+Fg89ttmCcdBok2BfuHMBt9LsCPSr1oJ1Fr+hvTx3Gjg9nubGJT78KD5AFNyWSpSrWJCZl0GFkbEX7pZxm3OUeFo+br5bno/I10Ii3b2T/PrQdzv8+yAIsFDAhBtujfIXitFNjoEGECMt9TrVtwT1BvIq84vAI0RQBnWWnRHw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 6/20/23 17:16, Joel Fernandes wrote: > > Considering our discussion above that hugetlb mremap addresses should always > starts at a PMD boundary, maybe I can just add a warning to the if() like so to > detect any potential? > >     if (is_vm_hugetlb_page(vma)) { >         WARN_ON_ONCE(old_addr - old_end != len); Oops, I meant WARN_ON_ONCE(old_end - old_addr != len); to make sure we did not mess up hugetlb mremaps. thanks, - Joel