From: Joel Fernandes <joel@joelfernandes.org>
To: Lorenzo Stoakes <lstoakes@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kselftest@vger.kernel.org, linux-mm@kvack.org,
Shuah Khan <shuah@kernel.org>, Vlastimil Babka <vbabka@suse.cz>,
Michal Hocko <mhocko@suse.com>,
Kirill A Shutemov <kirill@shutemov.name>,
"Liam R. Howlett" <liam.howlett@oracle.com>,
"Paul E. McKenney" <paulmck@kernel.org>,
Suren Baghdasaryan <surenb@google.com>,
Kalesh Singh <kaleshsingh@google.com>,
Lokesh Gidra <lokeshgidra@google.com>,
Vineeth Pillai <vineeth@bitbyteword.org>
Subject: Re: [PATCH v4 1/7] mm/mremap: Optimize the start addresses in move_page_tables()
Date: Tue, 20 Jun 2023 17:21:10 -0400 [thread overview]
Message-ID: <867bd9d6-1d00-0d9d-368a-8224cb40a505@joelfernandes.org> (raw)
In-Reply-To: <e81b4534-54ce-466f-0d07-dc530cf137c2@joelfernandes.org>
On 6/20/23 17:16, Joel Fernandes wrote:
>
> Considering our discussion above that hugetlb mremap addresses should always
> starts at a PMD boundary, maybe I can just add a warning to the if() like so to
> detect any potential?
>
> if (is_vm_hugetlb_page(vma)) {
> WARN_ON_ONCE(old_addr - old_end != len);
Oops, I meant WARN_ON_ONCE(old_end - old_addr != len);
to make sure we did not mess up hugetlb mremaps.
thanks,
- Joel
next prev parent reply other threads:[~2023-06-20 21:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230531220807.2048037-1-joel@joelfernandes.org>
[not found] ` <20230531220807.2048037-2-joel@joelfernandes.org>
2023-06-17 22:49 ` Lorenzo Stoakes
2023-06-19 15:55 ` Joel Fernandes
2023-06-20 11:02 ` Lorenzo Stoakes
2023-06-20 21:16 ` Joel Fernandes
2023-06-20 21:21 ` Joel Fernandes [this message]
2023-06-20 22:00 ` Lorenzo Stoakes
2023-06-27 17:56 ` Liam R. Howlett
2023-06-27 18:02 ` Lorenzo Stoakes
2023-06-27 20:28 ` Liam R. Howlett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=867bd9d6-1d00-0d9d-368a-8224cb40a505@joelfernandes.org \
--to=joel@joelfernandes.org \
--cc=kaleshsingh@google.com \
--cc=kirill@shutemov.name \
--cc=liam.howlett@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lokeshgidra@google.com \
--cc=lstoakes@gmail.com \
--cc=mhocko@suse.com \
--cc=paulmck@kernel.org \
--cc=shuah@kernel.org \
--cc=surenb@google.com \
--cc=torvalds@linux-foundation.org \
--cc=vbabka@suse.cz \
--cc=vineeth@bitbyteword.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox