From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19BBDC5320E for ; Tue, 27 Aug 2024 06:52:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A25636B0083; Tue, 27 Aug 2024 02:52:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9AEB46B0085; Tue, 27 Aug 2024 02:52:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 801976B0088; Tue, 27 Aug 2024 02:52:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 5E8B86B0083 for ; Tue, 27 Aug 2024 02:52:42 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id B23841A1636 for ; Tue, 27 Aug 2024 06:52:41 +0000 (UTC) X-FDA: 82497107322.13.CC9DAC2 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf25.hostedemail.com (Postfix) with ESMTP id 5EEF2A0013 for ; Tue, 27 Aug 2024 06:52:39 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=0kCF8QJd; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=i8KDeLBm; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=0kCF8QJd; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=i8KDeLBm; dmarc=none; spf=pass (imf25.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724741463; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Q4Q/foGOiwLAlEEnyHFbOjEBIbylsqi1rcIrtd8oivM=; b=M1NJQYZowR3VhDbRPA1Ex3Tk+/oEYsJyMziWv07S8nFMm42wcz54jtFTyWrhSh97cUCual Nzwd8wHgg/ANQZ9+vOlSEu2D/cd1DzBRLp1Aph/D3s71/IgxsBxEsduDSFppnTNQjqz91w UcMsU4Jc4B2GKMFqliyhv5D9jX9HoDU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724741463; a=rsa-sha256; cv=none; b=4CMjjtr8zjv/RtxHrsz5F50SPLwE7qDdEEMT0deitzqisL0TWoL8wBXqP5275yE7jwKrMN WurcyqVPKa/blTnd9O6mesJ9UxZd7YxokMG0tUqihqCh5wAxHEm+oRJ064Xl4rwuaBKJ2U 2ki5BJ2pyz5d0VVSrM1wrcuGhok2uV4= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=0kCF8QJd; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=i8KDeLBm; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=0kCF8QJd; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=i8KDeLBm; dmarc=none; spf=pass (imf25.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 614EC219C4; Tue, 27 Aug 2024 06:52:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1724741557; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Q4Q/foGOiwLAlEEnyHFbOjEBIbylsqi1rcIrtd8oivM=; b=0kCF8QJdQLejjw8wZ/nJ86lvZTqgFB7QjhcCqNMgywpXq0BhCsgiNdifUApOTSMzqVJzgd /UAPwbfs8wRRpHfm+fnIPzustXf8qN2DdNytjG5XKBbOT9HRx32dg7dg6YPmkJ/HOm76g0 FuzdlHrr9r4fn1XTf1E53KdtIkEakj4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1724741557; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Q4Q/foGOiwLAlEEnyHFbOjEBIbylsqi1rcIrtd8oivM=; b=i8KDeLBmay6hjGV5q2pc9kBNKu5WmOS8Pj2f+s/oYKOiosReMXLU7BdPuTsqUdn87mF/q3 GjTG6qlCel2qn5Bw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1724741557; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Q4Q/foGOiwLAlEEnyHFbOjEBIbylsqi1rcIrtd8oivM=; b=0kCF8QJdQLejjw8wZ/nJ86lvZTqgFB7QjhcCqNMgywpXq0BhCsgiNdifUApOTSMzqVJzgd /UAPwbfs8wRRpHfm+fnIPzustXf8qN2DdNytjG5XKBbOT9HRx32dg7dg6YPmkJ/HOm76g0 FuzdlHrr9r4fn1XTf1E53KdtIkEakj4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1724741557; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Q4Q/foGOiwLAlEEnyHFbOjEBIbylsqi1rcIrtd8oivM=; b=i8KDeLBmay6hjGV5q2pc9kBNKu5WmOS8Pj2f+s/oYKOiosReMXLU7BdPuTsqUdn87mF/q3 GjTG6qlCel2qn5Bw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 3999113724; Tue, 27 Aug 2024 06:52:37 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 0p5eDbV3zWbzbgAAD6G6ig (envelope-from ); Tue, 27 Aug 2024 06:52:37 +0000 Message-ID: <8678eac7-93c3-4a85-86e3-0fef8facb1f0@suse.cz> Date: Tue, 27 Aug 2024 08:52:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] mm/slub: Add check for s->flags in the alloc_tagging_slab_free_hook To: Hao Ge , surenb@google.com Cc: 42.hyeyoo@gmail.com, akpm@linux-foundation.org, cl@linux.com, gehao@kylinos.cn, iamjoonsoo.kim@lge.com, kees@kernel.org, kent.overstreet@linux.dev, linux-kernel@vger.kernel.org, linux-mm@kvack.org, penberg@kernel.org, rientjes@google.com, roman.gushchin@linux.dev References: <20240816013336.17505-1-hao.ge@linux.dev> Content-Language: en-US From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <20240816013336.17505-1-hao.ge@linux.dev> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 5EEF2A0013 X-Stat-Signature: 5n4t15ps3tk3y83m1iezarwsqa7fdm3b X-Rspam-User: X-HE-Tag: 1724741559-570275 X-HE-Meta: U2FsdGVkX1/C51L8rN/gMJW692xyHRZT9LnQ9O0kWIN8fVmUF3FQVlzcrIP92VnD/nJkEO6wEx/LSQP5OPRP8eEIMo1pBSornuALU2cVvduiYaix14dSWomNkzZIMKRKjUyBsndSZc/HBbtaSNtYcoDrA/bWCihdwKCOdbxVzCL+x5XUABzP3R8gqcy+JwtaLoptfHyiUdMAwD2UkEGxBXK0yf2S6DuBfYA2XacjHDdO4JCNSCW0IEw8/86yTfRoiWD1QekfOjAjOOHMSdHLbfiYeI93XxosfABWYldcaP1TTAEp8h2m/sOla5UMerhaRWgA+N7uPfq7cpx4kTJbTMi07qbsqyiupC3ysZhV/cklhsBEhBoO8dwtR4rN1IJLMhU3xjd0gQp9gRfu+w9y68jcS3KyWONHrKvhKq4szu5rQz9oX1wz+2L0JNQrKGBO6IJe7+byZjjXNmTMfPedhEdQXnrxoeHS1bY9Zz2pyp+qD5vEPofD/qnAwUmQTut8iu8c5+illw8DCLrFIJSL3WqDtan/z+CHZ7gnPKH+L8bJxqKar28muc6szdpx5Ua7E2UgAPq/znorqdZOP9KavLl6zE/H/P+wN3gqpBY7AXz3C9nHomD0v0efoIiCtzkIp5kK8mPNLKSuW9an9u/uQ87yPcjYfsxZBF7+QGBG34/uo5xnGsCbf4xdjpwxe/UJ5ZzzuVY88l7sHJZ71V2+CjdwqAa/FQNn7hUBbt2eHWKZZSpf8Wbjv1XlGE3bqHeOo4zHdB2aCqwDWidyw11hj+pi1oqm18oTqBTPqu21/W5wJeQ4Tj6Fx1jZaGrS7GGVU7a9WzJUc9+Rddmk1lPFHM3JyqxmHzuXADJOyFLkO701HYafuJPddaLr72ei1WPx/gGhGOS0GZu/6Im1khb3oQAPgHUKENZK7Ttc3us8R7OeT5gR0/EBJrsz79DtwbJrRE6DneNmDzhamGIuKyW WApMEhra 0MlqISSPKTr0Au/mKKtCDqpxrVPJ1dmRnVLpsnVxEZOtenzhoTkICxUh9sYUbPl1JMxR/hIYpB8i63cQZ7AphYFgnULuETIwb7VY60XWBJxl/Je3oz1Xef/2AiqrBVW82waRwzIvtSxRv1hzhWol3OmkqGMBKxGeN6gKZG+9NGOdLKfTfN79Wz3blZJs0tXN+tknUetARprlOhsbvuxXTzZAumtJUqzzdZAPVba/128LMUiVPck15le+dJ3yGQODauP7x+YbhHkYpvG9ulU8c+jrDueJO6r0QzbvhGu6LHR/DDZUpAdUrSZ1QWDfYF1qYdJCDFksfPImEW1EW6Kx77xvdFl/sG5zD2b8BCNpBRLTv2/AsxJmkUIRBfe8o7mKdAjIF X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 8/16/24 03:33, Hao Ge wrote: > From: Hao Ge > > When enable CONFIG_MEMCG & CONFIG_KFENCE & CONFIG_KMEMLEAK, > the following warning always occurs,This is because the > following call stack occurred: > mem_pool_alloc > kmem_cache_alloc_noprof > slab_alloc_node > kfence_alloc > > Once the kfence allocation is successful,slab->obj_exts will not be empty, > because it has already been assigned a value in kfence_init_pool. > > Since in the prepare_slab_obj_exts_hook function,we perform a check for > s->flags & (SLAB_NO_OBJ_EXT | SLAB_NOLEAKTRACE),the alloc_tag_add function > will not be called as a result.Therefore,ref->ct remains NULL. > > However,when we call mem_pool_free,since obj_ext is not empty, > it eventually leads to the alloc_tag_sub scenario being invoked. > This is where the warning occurs. > > So we should add corresponding checks in the alloc_tagging_slab_free_hook. > For __GFP_NO_OBJ_EXT case,I didn't see the specific case where it's > using kfence,so I won't add the corresponding check in > alloc_tagging_slab_free_hook for now. > > [ 3.734349] ------------[ cut here ]------------ > [ 3.734807] alloc_tag was not set > [ 3.735129] WARNING: CPU: 4 PID: 40 at ./include/linux/alloc_tag.h:130 kmem_cache_free+0x444/0x574 > [ 3.735866] Modules linked in: autofs4 > [ 3.736211] CPU: 4 UID: 0 PID: 40 Comm: ksoftirqd/4 Tainted: G W 6.11.0-rc3-dirty #1 > [ 3.736969] Tainted: [W]=WARN > [ 3.737258] Hardware name: QEMU KVM Virtual Machine, BIOS unknown 2/2/2022 > [ 3.737875] pstate: 60400005 (nZCv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--) > [ 3.738501] pc : kmem_cache_free+0x444/0x574 > [ 3.738951] lr : kmem_cache_free+0x444/0x574 > [ 3.739361] sp : ffff80008357bb60 > [ 3.739693] x29: ffff80008357bb70 x28: 0000000000000000 x27: 0000000000000000 > [ 3.740338] x26: ffff80008207f000 x25: ffff000b2eb2fd60 x24: ffff0000c0005700 > [ 3.740982] x23: ffff8000804229e4 x22: ffff800082080000 x21: ffff800081756000 > [ 3.741630] x20: fffffd7ff8253360 x19: 00000000000000a8 x18: ffffffffffffffff > [ 3.742274] x17: ffff800ab327f000 x16: ffff800083398000 x15: ffff800081756df0 > [ 3.742919] x14: 0000000000000000 x13: 205d344320202020 x12: 5b5d373038343337 > [ 3.743560] x11: ffff80008357b650 x10: 000000000000005d x9 : 00000000ffffffd0 > [ 3.744231] x8 : 7f7f7f7f7f7f7f7f x7 : ffff80008237bad0 x6 : c0000000ffff7fff > [ 3.744907] x5 : ffff80008237ba78 x4 : ffff8000820bbad0 x3 : 0000000000000001 > [ 3.745580] x2 : 68d66547c09f7800 x1 : 68d66547c09f7800 x0 : 0000000000000000 > [ 3.746255] Call trace: > [ 3.746530] kmem_cache_free+0x444/0x574 > [ 3.746931] mem_pool_free+0x44/0xf4 > [ 3.747306] free_object_rcu+0xc8/0xdc > [ 3.747693] rcu_do_batch+0x234/0x8a4 > [ 3.748075] rcu_core+0x230/0x3e4 > [ 3.748424] rcu_core_si+0x14/0x1c > [ 3.748780] handle_softirqs+0x134/0x378 > [ 3.749189] run_ksoftirqd+0x70/0x9c > [ 3.749560] smpboot_thread_fn+0x148/0x22c > [ 3.749978] kthread+0x10c/0x118 > [ 3.750323] ret_from_fork+0x10/0x20 > [ 3.750696] ---[ end trace 0000000000000000 ]--- > > Fixes: 4b8736964640 ("mm/slab: add allocation accounting into slab allocation and free paths") > Signed-off-by: Hao Ge Acked-by: Vlastimil Babka > --- > mm/slub.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/mm/slub.c b/mm/slub.c > index c9d8a2497fd6..a77f354f8325 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -2116,6 +2116,10 @@ alloc_tagging_slab_free_hook(struct kmem_cache *s, struct slab *slab, void **p, > if (!mem_alloc_profiling_enabled()) > return; > > + /* slab->obj_exts might not be NULL if it was created for MEMCG accounting. */ > + if (s->flags & (SLAB_NO_OBJ_EXT | SLAB_NOLEAKTRACE)) > + return; > + > obj_exts = slab_obj_exts(slab); > if (!obj_exts) > return;