From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D53EC678D4 for ; Fri, 3 Mar 2023 14:05:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 93F316B0074; Fri, 3 Mar 2023 09:05:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8EF686B0075; Fri, 3 Mar 2023 09:05:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 790616B0078; Fri, 3 Mar 2023 09:05:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 6B93F6B0074 for ; Fri, 3 Mar 2023 09:05:14 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 30089ABA0D for ; Fri, 3 Mar 2023 14:05:14 +0000 (UTC) X-FDA: 80527758948.30.494847A Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf30.hostedemail.com (Postfix) with ESMTP id 23D8E80012 for ; Fri, 3 Mar 2023 14:05:11 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=OZYIFFVu; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=wpl6Vlsz; dmarc=none; spf=pass (imf30.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677852312; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qAyHMSLU+ZAjg+fVvvS8HIYSzMW9bXu596gR+RmZV28=; b=OTUZy55x5xylTKHuJy1h+qWoctQAKXpUes5FszRhafWZxmtAAvjhV+LsrgOLTFlUoga/8v ubSNIMWGG7T38fLnvpRzr45ujOdxhgK0ORdkRsf+q8rAq5cTTMqFQkmSuI2CBuRuDW0yot aDk0PQpV9VLtpUlm6oXUtPlOmG+AxrE= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=OZYIFFVu; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=wpl6Vlsz; dmarc=none; spf=pass (imf30.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677852312; a=rsa-sha256; cv=none; b=32G0g1MRviFPuA+e8ZwZ4/bkWZrCqIrZjxAzlEvK7DNqgXfM7nC7VY5ftxiBe3+FOnni5c /wHyIDnJVfNNSFerq2yaUyueTbiffiMECrv9+HxbHBDdhihB8lVdAyWIT4TrvAwVH1ZS/M /aYTga4Y2QmFMwJyVcMQrS8QnzI0/+k= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id C2E3622C72; Fri, 3 Mar 2023 14:05:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1677852310; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qAyHMSLU+ZAjg+fVvvS8HIYSzMW9bXu596gR+RmZV28=; b=OZYIFFVuw6oXAahfgkiI7/oLV2HorUHQKPuVFaHGSV1FQ52eFfviWY2ZVhsnGfMusLRBwh XNXKwNKDuGNdpnGWkW8BEKQlrdyPGJaLI9pNPW9letJQ+REJvnFOvGTr16yTDXowK8Z5GK 1lrkSdwl4PbTp+XEm8ZjRfHUbolU9IE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1677852310; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qAyHMSLU+ZAjg+fVvvS8HIYSzMW9bXu596gR+RmZV28=; b=wpl6VlszaaUCfBqWylPJmkDjE6mriL1Af0Up1NXNdbJQ/AFxPePwT34tA2etKFMg1HPZ2N p9f0BEq5bCbeLUDg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3977E1329E; Fri, 3 Mar 2023 14:05:10 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id eOLlC5b+AWQ8DQAAMHmgww (envelope-from ); Fri, 03 Mar 2023 14:05:10 +0000 Message-ID: <8670a645-f48f-1d64-e5a5-291f2593643a@suse.cz> Date: Fri, 3 Mar 2023 15:05:09 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH RFC v8 09/56] KVM: SEV: Handle memory backed by restricted memfd Content-Language: en-US To: Michael Roth , kvm@vger.kernel.org Cc: linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, jroedel@suse.de, thomas.lendacky@amd.com, hpa@zytor.com, ardb@kernel.org, pbonzini@redhat.com, seanjc@google.com, vkuznets@redhat.com, jmattson@google.com, luto@kernel.org, dave.hansen@linux.intel.com, slp@redhat.com, pgonda@google.com, peterz@infradead.org, srinivas.pandruvada@linux.intel.com, rientjes@google.com, dovmurik@linux.ibm.com, tobin@ibm.com, bp@alien8.de, kirill@shutemov.name, ak@linux.intel.com, tony.luck@intel.com, marcorr@google.com, sathyanarayanan.kuppuswamy@linux.intel.com, alpergun@google.com, dgilbert@redhat.com, jarkko@kernel.org, ashish.kalra@amd.com, nikunj.dadhania@amd.com, Nikunj A Dadhania References: <20230220183847.59159-1-michael.roth@amd.com> <20230220183847.59159-10-michael.roth@amd.com> From: Vlastimil Babka In-Reply-To: <20230220183847.59159-10-michael.roth@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 23D8E80012 X-Stat-Signature: 6ssyw4fxdhrjq85ex3bqaxzc19sztuj8 X-HE-Tag: 1677852311-230770 X-HE-Meta: U2FsdGVkX1+G3QuhKZCRy+RLxPZ+2iCcHj7zSaOJLJj/e59PzfLqnijpzUYEJbFVFqL6e8td8ZvXZKgpKeuxYgaG2vSnG05u6ySmgi2JEuw8qxBq3j5eOEGpphTu+RsuTWmwm6bX1Nf40gMVXAsI7CA+Vd1Tm6QkEOSdcibTWxhN+enWi/CDx5DqcQ9v9MAWi7Q1IlsGhmFS3TaxNzVSHW9KxRPnhfk8E5luOyga05Ry81xVpTCLYfCek/lo9ecBobEX4SzjnOFhvvipr59XLaNdyZlT8ZtTabgPRvTA0+TcJY5Lw0cNTBQOVZte0H8SA3eZe/iNat1yDSQaHxw6wlsQ+q/EPyQwYV2UsrukC/F1NLW8/FBpSU9roZ5Y8OP6BxLk+ZcTS2fqeG34QG8oa5dtLdP3KcIu7FNQsntEgfwaYq05RKhYw5RRyrTRCdVHWXjnC68VcT3FSHVED911QRwLj9hynu2TgbIpEMHLgoymKGcG+/Oz24/spPKGZzYhG1tZmjAHGG8i4N3/V/6XXFx9IadDqQ5c6lfC1Ri9fXfC5XAI0EZ+LF5CswNyR9/BGvK7YNTfIGsiJhGEBNScSuSWMP5BRKocw2rDikOerRyZeCZxpdQwQ9bUlyqAGp2eu+b+938mbkPRfDSTSjPbQYmwu9Hrtu/pyHMwPGDYCXnhFBDoJrJCnxqz8f5i5hlIT0TrCn0FkPYrNvVE4t9UPosKYefZJ72viS2qR8UuWD9HrXCfGSqhroSizZ4qwht7M+aA00wgR1RSAWq/e6lhF03EKs37NXPWz/CbIG2j39EFiGfuRZjaz6Fz71M1pDszjHCFeRiTlRu73OXDLl9iYPpC1uvOzrlPvTTj9sIQlru1njNYdoqANANmQewP/Eg9k1SWZZe7wQS8W+Gt0Sjw46pNN6frDewVwOc4iAwZneB+2SmuIFHi85kFVJNlOxBRZHrIuDHBZllBXSGtZL4 +NCK994Y Rh2xAZ1fBL4/Lrt0D+7+eyqsFAksPJZo2ydm3e96ujH6nc0UOEB4Z4Bi6XqOm/36mJub2LdRwuR/B66dHnm9Zpdri93g/Ve+zV6bhq5yLRw94bojkQHM+/VV91FGvpacKI1i2h3CXsxm3Blrdtkm5gk0D+9oK7wMb2o0wUiP2azMRVm9c3qtk1YYTrpZHrVLvVLUdxbazlnkafjIEaENjDhtHn2+LbgUybsHm2/wyAkdS96k= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2/20/23 19:38, Michael Roth wrote: > From: Nikunj A Dadhania > > Do not pin the guest memory backed by a restrictedmem backend, as > pages in the restrictedmem are already pinned. Instead, populate the > pages array for these guests using the already-pinned pages provided by IIUC the "already pinned" became "effectively unmovable and unevictable" since the earlier versions, so that would be more accurate now? > +static int sev_private_mem_get_pages(struct kvm *kvm, unsigned long addr, > + unsigned long size, unsigned long npages, > + struct page **pages) > +{ > + return kvm_vm_do_hva_range_op(kvm, addr, addr + size, > + sev_private_mem_get_pages_handler, pages); > +} > + > /* > * Legacy SEV guest pin the pages and return the array populated with pinned > * pages. > + * > + * SEV guests using restricted memfd backend, pages are already marked as > + * unmovable and unevictable. Populate the pages array for these guests using > + * restrictedmem get_pfn. Right.