From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4653C433F5 for ; Mon, 20 Dec 2021 00:48:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B43F46B0071; Sun, 19 Dec 2021 19:48:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AEF116B0073; Sun, 19 Dec 2021 19:48:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9690F6B0074; Sun, 19 Dec 2021 19:48:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0213.hostedemail.com [216.40.44.213]) by kanga.kvack.org (Postfix) with ESMTP id 857A66B0071 for ; Sun, 19 Dec 2021 19:48:13 -0500 (EST) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 3DBE68848E for ; Mon, 20 Dec 2021 00:47:57 +0000 (UTC) X-FDA: 78936335394.24.5FB9293 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf15.hostedemail.com (Postfix) with ESMTP id 49236A003B for ; Mon, 20 Dec 2021 00:47:50 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 0BED61F395; Mon, 20 Dec 2021 00:47:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1639961275; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GljbjGESLyxg+ngLc7mhGY1oQBxex2sK+C5XSkEFVyI=; b=bXsxoOzcRRIip4e3u7ZMJHBHCqpqGoHvghX+Qod90rITqgkPX6WlwwmBkBzLIQgnPM3M7l siGEY6tKIftLy8gm6P7tCtEhJhPH5+N420SWQ7CGJk78g/87i2iR5inofquN9kpBkcJNuF Zi+LVig8LSExmO4XED1Ps1yp2oNnfR4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1639961275; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GljbjGESLyxg+ngLc7mhGY1oQBxex2sK+C5XSkEFVyI=; b=d+lrN53wSmcr6AJTW2rR1oZX3qGUcCXsDSsgdtTCVT7nNW2HNB8UytrIeq4FK+FkuQdmV5 dAxQM4ms+6JZ/yCg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 66B78133A7; Mon, 20 Dec 2021 00:47:54 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id yFyaF7rSv2HcbQAAMHmgww (envelope-from ); Mon, 20 Dec 2021 00:47:54 +0000 Message-ID: <86617be0-8aa8-67d2-08bd-1e06c3d12785@suse.cz> Date: Mon, 20 Dec 2021 01:47:54 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH v2 00/33] Separate struct slab from struct page Content-Language: en-US To: Roman Gushchin Cc: Matthew Wilcox , Christoph Lameter , David Rientjes , Joonsoo Kim , Pekka Enberg , linux-mm@kvack.org, Andrew Morton , patches@lists.linux.dev, Alexander Potapenko , Andrey Konovalov , Andrey Ryabinin , Andy Lutomirski , Borislav Petkov , cgroups@vger.kernel.org, Dave Hansen , David Woodhouse , Dmitry Vyukov , "H. Peter Anvin" , Ingo Molnar , iommu@lists.linux-foundation.org, Joerg Roedel , Johannes Weiner , Julia Lawall , kasan-dev@googlegroups.com, Lu Baolu , Luis Chamberlain , Marco Elver , Michal Hocko , Minchan Kim , Nitin Gupta , Peter Zijlstra , Sergey Senozhatsky , Suravee Suthikulpanit , Thomas Gleixner , Vladimir Davydov , Will Deacon , x86@kernel.org, Hyeonggon Yoo <42.hyeyoo@gmail.com> References: <20211201181510.18784-1-vbabka@suse.cz> <4c3dfdfa-2e19-a9a7-7945-3d75bc87ca05@suse.cz> From: Vlastimil Babka In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 49236A003B X-Stat-Signature: tmiuwnuc5rmxsjx1h96z7efufdsrf65g Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=bXsxoOzc; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=d+lrN53w; spf=pass (imf15.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none X-Rspamd-Server: rspam10 X-HE-Tag: 1639961270-136077 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 12/16/21 00:38, Roman Gushchin wrote: > Part 2: > > * mm: Convert check_heap_object() to use struct slab > Reviewed-by: Roman Gushchin > > * mm/slub: Convert detached_freelist to use a struct slab > How about to convert free_nonslab_page() to free_nonslab_folio()? > And maybe rename it to something like free_large_kmalloc()? > If I'm not missing something, large kmallocs is the only way how we can end up > there with a !slab folio/page. Good point, thanks! But did at as part of the following patch, where it fits logically better. > * mm/slub: Convert kfree() to use a struct slab > Reviewed-by: Roman Gushchin Didn't add your tag because of the addition of free_large_kmalloc() change. > * mm/slub: Convert __slab_lock() and __slab_unlock() to struct slab > Reviewed-by: Roman Gushchin > > * mm/slub: Convert print_page_info() to print_slab_info() > Do we really need to explicitly convert slab_folio()'s result to (struct folio *)? Unfortunately yes, as long as folio_flags() don't take const struct folio *, which will need some yak shaving. > Reviewed-by: Roman Gushchin > > * mm/slub: Convert alloc_slab_page() to return a struct slab > Reviewed-by: Roman Gushchin > > * mm/slub: Convert __free_slab() to use struct slab > Reviewed-by: Roman Gushchin > > * mm/slub: Convert pfmemalloc_match() to take a struct slab > Cool! Removing pfmemalloc_unsafe() is really nice. > Reviewed-by: Roman Gushchin > > * mm/slub: Convert most struct page to struct slab by spatch > Reviewed-by: Roman Gushchin > > * mm/slub: Finish struct page to struct slab conversion > Reviewed-by: Roman Gushchin > > * mm/slab: Convert kmem_getpages() and kmem_freepages() to struct slab > Reviewed-by: Roman Gushchin Thanks again! > * mm/slab: Convert most struct page to struct slab by spatch > > Another patch with the same title? Rebase error? > > * mm/slab: Finish struct page to struct slab conversion > > And this one too? > > > Thanks! > > Roman