From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC917C433FE for ; Fri, 3 Sep 2021 07:31:36 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5ACC56054F for ; Fri, 3 Sep 2021 07:31:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5ACC56054F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id AB48C8D0002; Fri, 3 Sep 2021 03:31:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A3C778D0001; Fri, 3 Sep 2021 03:31:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 904558D0002; Fri, 3 Sep 2021 03:31:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0131.hostedemail.com [216.40.44.131]) by kanga.kvack.org (Postfix) with ESMTP id 7D94D8D0001 for ; Fri, 3 Sep 2021 03:31:35 -0400 (EDT) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 3235182E9233 for ; Fri, 3 Sep 2021 07:31:35 +0000 (UTC) X-FDA: 78545442150.11.CFAE96B Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf18.hostedemail.com (Postfix) with ESMTP id CFC9C400208E for ; Fri, 3 Sep 2021 07:31:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1630654294; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LyKqSxHAqtRgLuja3A5/OxlFAavADXVdY5DxybXyPgA=; b=MJ+fI9pDrwarzDfwZxrQvXcdWTZbxqukUeH4B4dD+Gmv5l1M8xjsZC0AS9rcTwK2AnuMXL VT06SINqYAlHaD0Z/fZrFMB+iXM8TUnpEV8ZPNXjND3jYE+kFy78cSX9BSwxTnB1APKpC5 VqojQdhGyqkbevFf77Ho2XNFhVD/3/k= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-556-CqbvS2GgPuidwZ_iM-e1gg-1; Fri, 03 Sep 2021 03:31:31 -0400 X-MC-Unique: CqbvS2GgPuidwZ_iM-e1gg-1 Received: by mail-wm1-f71.google.com with SMTP id m22-20020a7bca56000000b002e7508f3faeso1592562wml.2 for ; Fri, 03 Sep 2021 00:31:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=LyKqSxHAqtRgLuja3A5/OxlFAavADXVdY5DxybXyPgA=; b=HH77ptlr8p2poOY9JLtCymSYbz/YVpofgBE0kyg6DJmhR6YKlh/5swYPUDV1Yz9VNp F5HQSGx8YiWSgOc8laWJ3zITDMVgike7cittstUufpNYl7HJH2NLlt7BtYBUuGV8yxFQ 1NoMtApyRk2NFlcI8pdU3danJ5f8fhRAXfiVtIDQhjAqbW9xGFk6ClV5lgtjAdzn17e9 Giqe4gMTxzZLdzcglNBH4Y9srPTkjT6JFB/zDbAPVTejlm8uGojTLYWvzftfqWsSc3e1 8pJ7fDISCderevtrJaUQWywPhUnxeGUlwsFFAH7hDKbA///fky2qR2WIMmuhbM6ecJ6z zXNg== X-Gm-Message-State: AOAM53172/Q6THI22xjhOcuuWRqihOODoPFaXs7FI3NP6PFVUNX8cDF1 +Y6oWSYCJiGWUAj2x33M9AEonaf9l8mNjy/aUmBo7AR3EkZn5AqMVqL6VjolUa/0210pVXXVP1+ 9tOWkDzC/Q74= X-Received: by 2002:a1c:2313:: with SMTP id j19mr7013315wmj.189.1630654290028; Fri, 03 Sep 2021 00:31:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwTi0va8xvkYtxRvasQVBbPjwSjjUJEqirBs9Ca3dzZ1Z6zv7lNuRLRQQbxW8esF8g5T0TMiA== X-Received: by 2002:a1c:2313:: with SMTP id j19mr7013298wmj.189.1630654289874; Fri, 03 Sep 2021 00:31:29 -0700 (PDT) Received: from [192.168.3.132] (p4ff23e05.dip0.t-ipconnect.de. [79.242.62.5]) by smtp.gmail.com with ESMTPSA id z6sm3583891wmp.1.2021.09.03.00.31.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Sep 2021 00:31:29 -0700 (PDT) Subject: Re: [PATCH v2 5/5] mm: Add ZAP_FLAG_SKIP_SWAP and zap_flags From: David Hildenbrand To: Peter Xu , linux-mm@kvack.org, Hugh Dickins , Andrew Morton , linux-kernel@vger.kernel.org Cc: Miaohe Lin , Matthew Wilcox , Yang Shi , "Kirill A . Shutemov" , Jerome Glisse , Alistair Popple , Andrea Arcangeli , Mike Rapoport References: <20210902201721.52796-1-peterx@redhat.com> <20210902201836.53605-1-peterx@redhat.com> Organization: Red Hat Message-ID: <86536aa5-8e9a-64ec-1bee-c47ee24fc683@redhat.com> Date: Fri, 3 Sep 2021 09:31:28 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MJ+fI9pD; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf18.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: CFC9C400208E X-Stat-Signature: rasunab7g9wo61sozbknu6gjhiu7s1c7 X-HE-Tag: 1630654294-571330 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: >> @@ -3377,7 +3377,7 @@ void unmap_mapping_pages(struct address_space *mapping, pgoff_t start, >> pgoff_t nr, bool even_cows) >> { >> pgoff_t first_index = start, last_index = start + nr - 1; >> - struct zap_details details = { }; >> + struct zap_details details = { .zap_flags = ZAP_FLAG_SKIP_SWAP }; >> >> details.zap_mapping = even_cows ? NULL : mapping; >> if (last_index < first_index) >> > > I think what would really help is to add a high-level description what > unmap_mapping_page() vs. unmap_mapping_pages() really does, and what the > expectations/use cases are. The names are just way too similar ... aaaaand staring only at this patch I missed that we have nice descriptions already :) -- Thanks, David / dhildenb