From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9ABAC433F5 for ; Thu, 11 Nov 2021 10:00:56 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9756B61107 for ; Thu, 11 Nov 2021 10:00:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9756B61107 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 18ECF6B0096; Thu, 11 Nov 2021 05:00:56 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 118316B0098; Thu, 11 Nov 2021 05:00:56 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ED44C6B009A; Thu, 11 Nov 2021 05:00:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0181.hostedemail.com [216.40.44.181]) by kanga.kvack.org (Postfix) with ESMTP id DEDDA6B0096 for ; Thu, 11 Nov 2021 05:00:55 -0500 (EST) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id AF50C80CD178 for ; Thu, 11 Nov 2021 10:00:55 +0000 (UTC) X-FDA: 78796205670.30.E0821B2 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf13.hostedemail.com (Postfix) with ESMTP id 15F3E104D42F for ; Thu, 11 Nov 2021 09:59:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1636624794; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JJZyqwp1ZfPiiIIAKWZ1DfaVeDawYq4abX63m+PU+To=; b=CBD3UekzsM0cjDmDC6yBOVHPPQIpUVeN4OeXD2fz/5R7eSRVF9eaWzWiNEoMsw2Mmfbiv6 D6hhInDH6SKtndEOTMYexqh4uqQE5i7HiaL4WL7c9d0WTxmx0jk1lu9OxpYDt+k4NJ4QhT BFWDeCxYBgxZQ2b1pfuh2M5SuYOeCqg= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-340-K_m4kTdbNceP5bnS4gnokg-1; Thu, 11 Nov 2021 04:59:53 -0500 X-MC-Unique: K_m4kTdbNceP5bnS4gnokg-1 Received: by mail-wm1-f72.google.com with SMTP id z126-20020a1c7e84000000b003335e5dc26bso1218521wmc.8 for ; Thu, 11 Nov 2021 01:59:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=JJZyqwp1ZfPiiIIAKWZ1DfaVeDawYq4abX63m+PU+To=; b=HxZTyNu5bSzekivhi7l5FUarwdciVK1RXgauvDK+JdEJm32H4xC3x1vtdnF42t/0/z A+SExHMS1yGstAI1CEdhslM9rMwf9w2vzPqq/GMjn/q65BzCaxAJCdQaOL+sCr/JSWJ+ 0IplQXDWsoycp2gkxetldGZ6ie24HvWjNsD8J1hBY8ruAKpXNpkfD8rgXN0NeggZ2iZX ejU8XKQ7naiRCclZHr0Cniv75vJ1FeJ5DQH2ivtvXV8yZXCqsPq9MOn6EcPFPc8dfvm5 rimn5hZbOTdGxMaej5k9qj7YXRjUIpmkp+l4gbks9i6/4QF5DQrm3T/ta9A4OlWqgq8h 2X8A== X-Gm-Message-State: AOAM531Iy+ekp09+dKuwgDWdKZB90KvkDgtDnVdzmiju8qHvBe84vHqm nRela3nqXxG0j9H3whv7UFyNcIcJdcTYQaTtwATAl1JEG2wSoI3jXnWQM8UIS7bb0UsJ9AR51vw EwTaNbjphqjk= X-Received: by 2002:a05:6000:1acd:: with SMTP id i13mr7515145wry.398.1636624792278; Thu, 11 Nov 2021 01:59:52 -0800 (PST) X-Google-Smtp-Source: ABdhPJwCMFguV57azEtjX0H9g2qbHnrf05evwsn7R3U/X/5WhRj7wS9zZ6r9M/+fj7ufva631F1UwQ== X-Received: by 2002:a05:6000:1acd:: with SMTP id i13mr7515110wry.398.1636624792096; Thu, 11 Nov 2021 01:59:52 -0800 (PST) Received: from [192.168.3.132] (p4ff23ee8.dip0.t-ipconnect.de. [79.242.62.232]) by smtp.gmail.com with ESMTPSA id d6sm2404299wrx.60.2021.11.11.01.59.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Nov 2021 01:59:51 -0800 (PST) Message-ID: <864f67e1-6250-57ac-511b-60a3590af2c2@redhat.com> Date: Thu, 11 Nov 2021 10:59:50 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH 2/7] fs/exec: make __get_task_comm always get a nul terminated string To: Yafang Shao , akpm@linux-foundation.org Cc: netdev@vger.kernel.org, bpf@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, oliver.sang@intel.com, lkp@intel.com, Kees Cook , Steven Rostedt , Mathieu Desnoyers , Arnaldo Carvalho de Melo , Alexei Starovoitov , Andrii Nakryiko , Michal Miroslaw , Peter Zijlstra , Matthew Wilcox , Al Viro , Petr Mladek References: <20211108083840.4627-1-laoar.shao@gmail.com> <20211108083840.4627-3-laoar.shao@gmail.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20211108083840.4627-3-laoar.shao@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=CBD3Uekz; spf=none (imf13.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 15F3E104D42F X-Stat-Signature: e8jdetxiofdeaxajybmtwcsnzpscs3fm X-HE-Tag: 1636624783-684287 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 08.11.21 09:38, Yafang Shao wrote: > If the dest buffer size is smaller than sizeof(tsk->comm), the buffer > will be without null ternimator, that may cause problem. Using > strscpy_pad() instead of strncpy() in __get_task_comm() can make the string > always nul ternimated. > > Suggested-by: Kees Cook > Suggested-by: Steven Rostedt > Signed-off-by: Yafang Shao > Reviewed-by: Kees Cook > Cc: Mathieu Desnoyers > Cc: Arnaldo Carvalho de Melo > Cc: Alexei Starovoitov > Cc: Andrii Nakryiko > Cc: Michal Miroslaw > Cc: Peter Zijlstra > Cc: Steven Rostedt > Cc: Matthew Wilcox > Cc: David Hildenbrand > Cc: Al Viro > Cc: Kees Cook > Cc: Petr Mladek > --- Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb