From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78E04C38142 for ; Tue, 24 Jan 2023 14:28:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1033E6B0075; Tue, 24 Jan 2023 09:28:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0DA886B0078; Tue, 24 Jan 2023 09:28:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EE43C6B007B; Tue, 24 Jan 2023 09:28:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id DC3776B0075 for ; Tue, 24 Jan 2023 09:28:03 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 821291A0270 for ; Tue, 24 Jan 2023 14:28:03 +0000 (UTC) X-FDA: 80389922046.29.BE42EDD Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf27.hostedemail.com (Postfix) with ESMTP id A999540009 for ; Tue, 24 Jan 2023 14:28:01 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=RQyHZ4wm; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf27.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674570481; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hIS1K7niUqS6nIphS79ng1X59kXY7sWKmEnTl9Ur8D0=; b=JAent+QRnJgpJ/tC7Z5PH2+tV6p6x/QYtiXt8paVgFZUxZwubEs5O0Uh/kLHtVPEc5tN7U TPp6+3QiD5L0HtZG6S7EPKXAxLCWH3x/QC6JAzih5QNAFMdTBjb0n5G2Ogpmj+KlrQmobF pQVQWztCY7Arc4qxZwVk3/qLkou2NYk= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=RQyHZ4wm; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf27.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674570481; a=rsa-sha256; cv=none; b=eMDE0KnK3dzwYoP4TXaIBCjtqZI7Nkp/afFdPlkM9sz10Hz5sj2ATv/LTNDhORhSKEXVCM BB/77CY+hJXv4XigbBRtC9++uKawutlj1vFQi9ibN7NQK2HPglqUCD02A2wqA066ig4OlN rWMWl4EKQDtxz3iy4MKltrRvrR1xDIQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674570481; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hIS1K7niUqS6nIphS79ng1X59kXY7sWKmEnTl9Ur8D0=; b=RQyHZ4wmUA5FKbHukUMBZHVGcwvxI6gdaFMGMFwcktCrahJ3jQb6QKp+ytoV3HXz7wpiGq FqgvtKh2buyaS/t/v117n6KD3YbF3vM0FZ/B5BOX64MfEPuL7+AQ3aDmTmVngAqfIliP2l tB0M3dPQljK7ee0dpaovpPp/3kmQzno= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-510-YAv3yGWgMmi0PtpnGZgFIw-1; Tue, 24 Jan 2023 09:27:56 -0500 X-MC-Unique: YAv3yGWgMmi0PtpnGZgFIw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 082C03C0D861; Tue, 24 Jan 2023 14:27:56 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.97]) by smtp.corp.redhat.com (Postfix) with ESMTP id 691D0C15BA0; Tue, 24 Jan 2023 14:27:54 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <20230123173007.325544-1-dhowells@redhat.com> <20230123173007.325544-11-dhowells@redhat.com> <31f7d71d-0eb9-2250-78c0-2e8f31023c66@nvidia.com> <84721e8d-d40e-617c-b75e-ead51c3e1edf@nvidia.com> <852117.1674567983@warthog.procyon.org.uk> <852914.1674568628@warthog.procyon.org.uk> <859142.1674569510@warthog.procyon.org.uk> To: Jason Gunthorpe Cc: dhowells@redhat.com, John Hubbard , Al Viro , Christoph Hellwig , Matthew Wilcox , Jens Axboe , Jan Kara , Jeff Layton , Logan Gunthorpe , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Christoph Hellwig , linux-mm@kvack.org Subject: Re: [PATCH v8 10/10] mm: Renumber FOLL_PIN and FOLL_GET down MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <864108.1674570473.1@warthog.procyon.org.uk> Date: Tue, 24 Jan 2023 14:27:53 +0000 Message-ID: <864109.1674570473@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Rspamd-Queue-Id: A999540009 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: yzaerbjr4614fdugmr55h67hzx368pjw X-HE-Tag: 1674570481-773091 X-HE-Meta: U2FsdGVkX18YdyF/ZaysLP3k+Uj5FaFYr6PNNUUDtcPzbjdR1NK564UX6qRTy3WMc4xPWPjfNOePLThXYZa4ZC4CCFjvkxEJkJG7AYf8/PR7d/+5aN2sMFGCnGmf6IoOqjGkpQq31NjM8l24R0qb8YQu+frQtSg6BGz4TRkgVaRxwJ5feneQtzSzY85L5JMmDt5mB6pxJhfO4V5kcj9O1PlmggrFfBnTHcJN8KO96vbwrXXtU5kJc7gjP4efwIg692dNQgRIByqn33qRYPTg5/GI1zX4pukH1ot/G9uaDSklmIfzQT8k71ikIXaqScKUXuXzM4Z0Kq2ZiKiBvwKFEHkdhbw27/dRry33lOeCR7DSiV5BnIRNy6cVB+haSs5H5qg6E1dVp7LI7i0a5ePYUkTf9eRrlsBwezR17CYmQfGCedAVsmv3tHCz4MIeiCldMgNjkPTT+eFCoOzOwfLCAnliEQ8Xe+d729KVH5/1hf3ggUMFtSebXh4NqD5nOKTN9apESxGAodkr4pnJgUXs0uh9ccKTvOKYC4ZZdXivXZirRiT759RiiWVbA0rnCdVIDLSlGfjt231gwUjIyLrJihSnxAyX6LzFZ9T0/u4aN5rxlA/rr62VK78yR6VKlleOLABl+EKA/VGQqPw5PAFHUUoUb9hY7e3DUV001s6MVnPtRq3x5pL5XgP2iknRpjDjLPeMEArAFcklndLp0uv8m/P3iTpPBLrjjGc24E758LtE+MGKNLlfXskzfXfcTPDnfaBXdq/Q+ACyCQ5zr+0IamUJmALqcnowBdqw3W2YzIywsbpYmpz+s7Arw3mKBO8Lum9JnG0brEvOFXuJw5BAxPcDVLInkDflZZGKIg/d/FTyWYc96oEpZ2J1S8v2KifjOpo88CyJwEI7LEusPMGC/FytyAJhM9N/2nP1tAISSe99CDkpuVsOwqCATy1kiN1MjmxQaTOA+Qby2J0WMip AhD5+GmC 7hpUX0/mYDFLWCJnagvcgNnU2TLt2jxUBJ1AYJQ56K3NXkTrqe+6iWLk0u5lsTDyAF4Vi/dcJ3CCW8uldbiM3BljP08Y2H+XnpLVA7zBaXDKMQ9ooffJQzOKUiQRZDVKIS4+mZMYUT8UhVMhJzNfv6Pla6S6+/wzHZd9rHWg0ZeLKgWoiSTnX1pFqx3hw4xZ6RidMeEHkdjuyCtFk+YuHn35hhmiJgV/kF17H1hP3U/klZ58w9GCA1aazHw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Jason Gunthorpe wrote: > My point was to change that to take a 'bool unpin' because FOLL_PIN is > not to be used outside gup.c I need a 3-state wrapper. But if I can't do it in gup.c, then I'll have to do it elsewhere. As Christoph says, most of the places will only be pinned or not-pinned. The whole point was to avoid generating new constants when existing constants would do. David.