From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76C53C433EF for ; Fri, 8 Jul 2022 19:59:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C8AAA8E0001; Fri, 8 Jul 2022 15:59:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BEB3E6B0073; Fri, 8 Jul 2022 15:59:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A64418E0001; Fri, 8 Jul 2022 15:59:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 904516B0072 for ; Fri, 8 Jul 2022 15:59:03 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 623783574F for ; Fri, 8 Jul 2022 19:59:03 +0000 (UTC) X-FDA: 79664996166.07.14FBE97 Received: from mx0a-00082601.pphosted.com (mx0b-00082601.pphosted.com [67.231.153.30]) by imf07.hostedemail.com (Postfix) with ESMTP id CBA224001B for ; Fri, 8 Jul 2022 19:59:02 +0000 (UTC) Received: from pps.filterd (m0089730.ppops.net [127.0.0.1]) by m0089730.ppops.net (8.17.1.5/8.17.1.5) with ESMTP id 268IrJZ9010299; Fri, 8 Jul 2022 12:58:47 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-id : content-transfer-encoding : mime-version; s=facebook; bh=l8pNSv5tpFtrTgEiZVJno9chqmRXhRia8c4jBfqgbUk=; b=XAZwMhKuJCNubnqtpxJRh6OA0zDzktO8e3LeI99WWnVhf524qqTE2CNQVvUABZbAFDnU i+Oqf5o+5bVExiBmijCxXFcymQoZQPH0M6xtf51EH4zBfzubKuKzrgMue8ATR4TJeka9 qRlOjAIbSeiPZJzCAd12fcyP+m/efjMl5p4= Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2047.outbound.protection.outlook.com [104.47.66.47]) by m0089730.ppops.net (PPS) with ESMTPS id 3h65q4fd3v-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 08 Jul 2022 12:58:47 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aTKAw9tLc9dPMUEbonSQtDmEYLw/AQCa01rOyKbIHPFROG1H6GsMXbze70SbHivU8l2yzLprkX2NJcU5sl/U8JuhHtVpzYJh6Rh7G1f1Dj+Y/Bygnn6MID++i7d+zuWcc/jhIixU9yQ6ZLlqEt+zWxAoT1Inh31aowTU0MekId/TfdrEC9iB3nRgct0Y7jOT1tL1mjiL9kPvhEsluBIhYNRg+Vp96tOkdBoBW7oQJvlBRihhfe5CVpvWfi7eUX3vZTdQId+Q2WcxIqMFumKv5pcnmY1AOwQc/kFPaQ0KNqCUfArl/LcwZuE8LNEIBPvfj4l4xrosdxMcfsmhwyvliQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=l8pNSv5tpFtrTgEiZVJno9chqmRXhRia8c4jBfqgbUk=; b=IXZW/34HuMSKLdSVGHVYHUqT7WHnXBqxDzgFuzP54ZWqh2KMHik278aK5RVfcSD6MUL/Acp3ZBkvTxajMFPhlGrEvHOKfhqCB7RF/7vSCsPvYX0/P7FMcuzFnnuXCgwwm6PApovuQyj4y0/AogV9afBqpu2iiHD2NQAaVts8k+qPYZ1SxydeppOhMtcvuNPjaTuOVFrLy4xiWRowyRtMkcNxQe/EuZHil5d7hUQUiDwBLfEhtwkGd/Od7jlXKlSwXevKDAlP3K1QlzCqrIZJJBRHGKFNH2QZ/5uqqA08Pa7Ma2Y6WFvlwuMOpel1uYJkTZdCXyucUXJLhky4z1S+Qw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=fb.com; dmarc=pass action=none header.from=fb.com; dkim=pass header.d=fb.com; arc=none Received: from SA1PR15MB5109.namprd15.prod.outlook.com (2603:10b6:806:1dc::10) by CY4PR15MB1398.namprd15.prod.outlook.com (2603:10b6:903:fd::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.20; Fri, 8 Jul 2022 19:58:44 +0000 Received: from SA1PR15MB5109.namprd15.prod.outlook.com ([fe80::e8cd:89e9:95b6:e19a]) by SA1PR15MB5109.namprd15.prod.outlook.com ([fe80::e8cd:89e9:95b6:e19a%7]) with mapi id 15.20.5417.020; Fri, 8 Jul 2022 19:58:44 +0000 From: Song Liu To: Luis Chamberlain CC: Song Liu , bpf , lkml , Linux-MM , Daniel Borkmann , Kernel Team , "x86@kernel.org" , "dave.hansen@linux.intel.com" , "rick.p.edgecombe@intel.com" Subject: Re: [PATCH v6 bpf-next 0/5] bpf_prog_pack followup Thread-Topic: [PATCH v6 bpf-next 0/5] bpf_prog_pack followup Thread-Index: AQHYklIC37qezjyxh0moueFgoO/pNa1zhdgAgAAO4YCAABD0AIAAC/MAgADwxACAAEM5AA== Date: Fri, 8 Jul 2022 19:58:44 +0000 Message-ID: <863A2D5B-976D-4724-AEB1-B2A494AD2BDB@fb.com> References: <20220707223546.4124919-1-song@kernel.org> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.100.31) x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: cd22fbbe-0d05-4ea7-ad12-08da611c437a x-ms-traffictypediagnostic: CY4PR15MB1398:EE_ x-fb-source: Internal x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: uOiFbsyl/enytZJokpi/OD+RCGV05O/g4q0pM/WGCc+//HmPNcJHAnNE8wyYPZcArMwmvMRrDVGjrzUbWE6edUG1Nu1jThmtYMDENcZwU+NJnIrec0MTMYL5btUv0gckXyzsZNwO2IbQWqoGTyxb05ti67reDki2SeClob/78rCI8bsOiIJDHl0bLfU98Sgv0cuN0jcJAwY8Rgtfk+5++kvYPFxM808ZKkwD2eb1Guh2OSgFOXv9WYpCXt278m3NgA2ZsF9eMUijA3K5K+5v2sExLs+cG6f79lic4pwVSykLkZhTSUwVuUVODw1GrtbV2GVL3c8yC4y0mD9MEgW5Rb90DxmcGzxiH/v5ZHmVOHPAaG87O9depVqPCRJvWlsIkqt/K3TlCIsQLb5LXnBLugTwrbunAoW4QfHQumDUY7VH7TjdizESdHfRucfh87JoXCkAK9Q3yG2Cyu/6V7vanHccEEEiHMWZ9/UAhICwThO0I99IDEo3jScgY4PdVQSMR7/g6YLDFoY8SvZJOF5ZcqObK6/TPpiEX7LZlgBhIHmaAXdYRAtzSAh18KvXUIeQlRXnppCQbBlziXGKA8uOZ8yjU3GLtDYGTtcRaIpeBNQ66+10Zvzkzv8aWsZfhJHiQ0TR7GsA+4HEOO4GLt76mETa45nZC5g3wrL95B5ogDbQPd409MMx9ZaZKy1lEZXRsvnVo6AtduhscgdvPOQa4krzDFds2ODsAPl4NsYp1VyDy10orxwxHe82Xj7w5WCKwEs0/sVanRpNoiPf7ZcdbIGP4263yw78wupSQSl3EpfzFed0qsjYQW4nqJzW0LKaXGzoo73pk6emAlZmFwTsFV6Yv3VT3WtoBbqExUE9TqM= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA1PR15MB5109.namprd15.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(346002)(396003)(39860400002)(366004)(136003)(376002)(38100700002)(33656002)(8936002)(478600001)(54906003)(122000001)(6916009)(316002)(71200400001)(6486002)(76116006)(5660300002)(8676002)(66476007)(66946007)(66446008)(64756008)(4326008)(186003)(2616005)(66556008)(41300700001)(6512007)(83380400001)(38070700005)(2906002)(91956017)(53546011)(36756003)(6506007)(86362001)(45980500001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?aXlclE+jIr55uyTEbLPrK3wlkVFUFunvVpkWIPHWQv2Fx9VFPeZhoB0xIWAi?= =?us-ascii?Q?CW7IMV4YTY32JlpUi3WR/Dt9/QlOiw7lxy9HMMqA9eHz6vxfy1KPo8kKm2u/?= =?us-ascii?Q?sfoVn6gxY62X0z0hzN5xehuZ391PkP3Whbbd68hM3oXOENg7JJhhCNqHYzsh?= =?us-ascii?Q?zieIGkiu0ARF+NlnLmMYnUwvHJxCkkT9JQXqdP8zpvki1D9R7q+qpCB7HgHq?= =?us-ascii?Q?4KtSQfxY/bag+VgoRtM4iiVQTCehpBPkMmLmxyyn5k9mONHtV/M6KcieP3yI?= =?us-ascii?Q?Debs/RYFwFMbJ6ItQpwuEay0j57M/5NWCItH+RZiNu7MOEtG0lxdHwr5Y9U0?= =?us-ascii?Q?kBh2rr7NEclrZLzqZhjhhtMujkT5SL+DKtrHJcE/nzCQXp0a7TLLSh+jN6p0?= =?us-ascii?Q?t1hjj/QYeKcRyviUDO8CXcKUcOr6VsNSSWmU/g9AeWT/GlEsURuYIz9Tnnq+?= =?us-ascii?Q?hEj2n8ZQ1zoGiIKEcY2skm3YbfXJUpOqShvybe9P9bXaYXxfhhiMEK1GhNXd?= =?us-ascii?Q?vwT5DPztHexz+8sTz4N57hpX9CsshxDAjzsPdb4jVjMIsqk7HEQeEVLPOxT6?= =?us-ascii?Q?v4rZd9R08lKKcg0T9XY1CFcowA+0R9elpV4cCK76Z8Du8Hzdrs7JMSqboZg7?= =?us-ascii?Q?pDeK76KKg9oIY2YE02QM34kdA+k/088R8jdQsMTS9lV3zjpOQ2QdjMX+9jvR?= =?us-ascii?Q?b4T4d38VAiRpKvPbNCH40r+X1Ew4Fn7CyrrxwvktBb6esw5+8xxjEuLDb7tt?= =?us-ascii?Q?Vf7BIm4GVCoBLgBuCdi0rVLgXVtjdpurUu3wiOpL/E+1G1dyGiS7lC06AByp?= =?us-ascii?Q?t3bJ3n7OUVbzPnlR0gH3z9PG0mZ10TPsEMoDzlqpMti1PrQK0/MIPgDIvJ+5?= =?us-ascii?Q?nMArBbJ6APkD9dowiodz1pCDRuGLXEesuQVeNQO5uGLCOHUoQpxGv/wZmr3o?= =?us-ascii?Q?qKIuu++iLO/gPcCWFiAovfbFFQzqkViqeJMDVT6GHTLv0h/+9gq/5fAsKKs9?= =?us-ascii?Q?Ga/3ScnTNtoACCpOnSlJxD8E20KheuToQHA9Dv3LFi2gTjToFWd+L2lY5Hm8?= =?us-ascii?Q?9dgtU3MYJpmdtWlovFzv3cmJd5+/WWm+o5oeKu8x7ekHuDBRcx4bUihmDh6z?= =?us-ascii?Q?7//QGFBqcwBkvKbMAvF7dhNxbTTaUGKMlcGH3QfdAb/FovvFWUxrKOdBD8ZY?= =?us-ascii?Q?5WEAiuBhfEbm7nX5vEhi3xgNZA5qVZMtyoz/HJV/vefUUey/Sxal+B9SZlZT?= =?us-ascii?Q?0X/sdqBP7P22arDH4Z+HGUgltKqXwOw0ZarN2F4vSoWN7jw0lk6C/BpRWxk0?= =?us-ascii?Q?X1Ja5SZ4WNgxG44wHGhnvLaAC8JipYvbgBwkDt49XTukOUj2W8HF2/veY8qh?= =?us-ascii?Q?pLMaLVD6J7oTHZvEvxoNRdPFKj2x6bhRsRHqkOstSkkBxlTnteKxyo/Y27sz?= =?us-ascii?Q?FeYz8Hq2Ky3vz2r9dGhNHkNbYdiWRzopq+COXp85r75MZfhsYTZNG1W4h7yU?= =?us-ascii?Q?W/7IY+o5qBKdPzAs3gR3newSb8xfZuG1aa1Rvht1QG+IF6G0kJHMx0n0xqII?= =?us-ascii?Q?P1B2ZEstbABtgD3noirMmxCPmffqIrJeQYPuomoNG/2HRg0BGxW8jTmQNku1?= =?us-ascii?Q?6xR/U75huh6XpJTgOn2W/zk=3D?= Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: fb.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA1PR15MB5109.namprd15.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: cd22fbbe-0d05-4ea7-ad12-08da611c437a X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Jul 2022 19:58:44.4969 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: WsxaT7Si3u8w7hlJYWsOysZ342Y9iFrtgNqsm5MAm2begE1knQW1WhZFB/N63DUOjkpiBPILNFAemHRmdeUeEg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR15MB1398 X-Proofpoint-GUID: TlAC0geYPQu-Kwo2vyub8EBX-3SwHTrh X-Proofpoint-ORIG-GUID: TlAC0geYPQu-Kwo2vyub8EBX-3SwHTrh X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-07-08_16,2022-07-08_01,2022-06-22_01 ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1657310342; a=rsa-sha256; cv=pass; b=xepXA9huR0DA+zgcon47DWntleqNyTXP+WrbkaUNNKAB6/41dpOTWgae/cCaq90qCkNx+G ckZEqjd3fgFUfenLmrkoukAA5Pk3WTitpmfAyN+7aBE79oze4Zl4EJFJBryP1y/mk4U+CP g81V4+rrnz7L/kwXqPmNS3dWrx6+m7E= ARC-Authentication-Results: i=2; imf07.hostedemail.com; dkim=pass header.d=fb.com header.s=facebook header.b=XAZwMhKu; spf=none (imf07.hostedemail.com: domain of "prvs=81887be565=songliubraving@fb.com" has no SPF policy when checking 67.231.153.30) smtp.mailfrom="prvs=81887be565=songliubraving@fb.com"; dmarc=pass (policy=reject) header.from=fb.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1657310342; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=l8pNSv5tpFtrTgEiZVJno9chqmRXhRia8c4jBfqgbUk=; b=f+hZNmXWXwGDa/LTF2MUX5Wr7bfPXoC+TIJsRmZCNhbfKmVMN6A7K2YPHFLZfk80tf3fE2 WJgzKs3O/AbJWJapOGpjHv/ElCT8Wc64mjTje2FfjiIGl515L2jZECex5+fZSaX9G7s4+j 1NMQ5R5p12pmQVikn9LzFK3u5WbaaK4= X-Rspamd-Server: rspam08 X-Rspam-User: Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=fb.com header.s=facebook header.b=XAZwMhKu; spf=none (imf07.hostedemail.com: domain of "prvs=81887be565=songliubraving@fb.com" has no SPF policy when checking 67.231.153.30) smtp.mailfrom="prvs=81887be565=songliubraving@fb.com"; dmarc=pass (policy=reject) header.from=fb.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") X-Stat-Signature: tuifmd5qbrtmeh157fbgypzoqzjsqyjt X-Rspamd-Queue-Id: CBA224001B X-HE-Tag: 1657310342-296970 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > On Jul 8, 2022, at 8:58 AM, Luis Chamberlain wrote: >=20 > On Fri, Jul 08, 2022 at 01:36:25AM +0000, Song Liu wrote: >>=20 >>=20 >>> On Jul 7, 2022, at 5:53 PM, Luis Chamberlain wrote: >>>=20 >>> On Thu, Jul 07, 2022 at 11:52:58PM +0000, Song Liu wrote: >>>>> On Jul 7, 2022, at 3:59 PM, Luis Chamberlain wrot= e: >>>>>=20 >>>>> On Thu, Jul 07, 2022 at 03:35:41PM -0700, Song Liu wrote: >>>>>> This set is the second half of v4 [1]. >>>>>>=20 >>>>>> Changes v5 =3D> v6: >>>>>> 1. Rebase and extend CC list. >>>>>=20 >>>>> Why post a new iteration so soon without completing the discussion we >>>>> had? It seems like we were at least going somewhere. If it's just >>>>> to include mm as I requested, sure, that's fine, but this does not >>>>> provide context as to what we last were talking about. >>>>=20 >>>> Sorry for sending v6 too soon. The primary reason was to extend the CC >>>> list and add it back to patchwork (v5 somehow got archived).=20 >>>>=20 >>>> Also, I think vmalloc_exec_ work would be a separate project, while th= is=20 >>>> set is the followup work of bpf_prog_pack. Does this make sense?=20 >>>>=20 >>>> Btw, vmalloc_exec_ work could be a good topic for LPC. It will be much >>>> more efficient to discuss this in person.=20 >>>=20 >>> What we need is input from mm / arch folks. What is not done here is >>> what that stuff we're talking about is and so mm folks can't guess. My >>> preference is to address that. >>>=20 >>> I don't think in person discussion is needed if the only folks >>> discussing this topic so far is just you and me. >>=20 >> How about we start a thread with mm / arch folks for the vmalloc_exec_* >> topic? I will summarize previous discussions and include pointers to=20 >> these discussions. If necessary, we can continue the discussion at LPC. >=20 > This sounds like a nice thread to use as this is why we are talking > about that topic. >=20 >> OTOH, I guess the outcome of that discussion should not change this set?= =20 >=20 > If the above is done right then actually I think it would show similar > considerations for a respective free for module_alloc_huge(). >=20 >> If we have concern about module_alloc_huge(), maybe we can have bpf code= =20 >> call vmalloc directly (until we have vmalloc_exec_)?=20 >=20 > You'd need to then still open code in a similar way the same things > which we are trying to reach consensus on. >> What do you think about this plan? >=20 > I think we should strive to not be lazy and sloppy, and prevent growth > of sloppy code. So long as we do that I think this is all reasoanble. Let me try to understand your concerns here. Say if we want module code to be a temporary home for module_alloc_huge before we move it to mm code. Would you think it is ready to ship if we: 1) Rename module_alloc_huge as module_alloc_text_huge(); 2) Add module_free_text_huge(); 3) Move set_memory_* and fill_ill_insn logic into module_alloc_text_huge() and module_free_text_huge().=20 Are these on the right direction? Did I miss anything important? Thanks, Song