From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22267C38142 for ; Tue, 24 Jan 2023 14:25:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8A5FC6B0071; Tue, 24 Jan 2023 09:25:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 855F16B0075; Tue, 24 Jan 2023 09:25:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 71D856B0078; Tue, 24 Jan 2023 09:25:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 5F73C6B0071 for ; Tue, 24 Jan 2023 09:25:25 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id CD3B3140B8E for ; Tue, 24 Jan 2023 14:25:24 +0000 (UTC) X-FDA: 80389915368.25.EEA65E4 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf21.hostedemail.com (Postfix) with ESMTP id EECF91C001A for ; Tue, 24 Jan 2023 14:25:21 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ZZoGKqNj; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf21.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674570322; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XO5A6WAtDgp5br3HLb+4sHFyIh5WN7cTJ94YiThUnn4=; b=G6kILYV6OgfYjuhM08QwSOJkN/RYtXBqdFMbT0r4rwrdD2o8TLk0qsqaqNOoIObgvmmdQw yt1L8cNvGaR2GxHAYULRuJqbS/bkufuZRAVlfvstlBmAXsrFUyI3wRtS2Qh0ywoz2Cj2xH pBAItFoJ8ZWcPq5fG31lgMY8Tm+D1HM= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ZZoGKqNj; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf21.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674570322; a=rsa-sha256; cv=none; b=oX8SqtjCZv2ka2zeirJn8DOps9wU8b9Gvh41gILsEdQU7LWo56AI9MDncywO9xfda5aagQ WgGW8E5jwHY77sEXDBi01fUTq5sO10riK22b798OVlkBrdAVxB90m0Q1mMwI0eqfI6CfUP KXfLom/ospAgr6YXvwNlSDf/gzLCbNs= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674570321; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XO5A6WAtDgp5br3HLb+4sHFyIh5WN7cTJ94YiThUnn4=; b=ZZoGKqNjgSrhcpy/ZLN8f+2yjRH1YGd1xycnP1e2zbNFA2my70XJsFLRZgA88iCYHU6oIe JBqoUpuCnXQdGXtAuzZkiyt6meIGIp/pnYXrnjBOQFzMlmBD2oJmFLy49GOV4dnCSLGm58 VOV6uKw3CotyB9ttBObk6BC0JOf1j20= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-38-vsV2wBhuNOufnzk2IHIz6w-1; Tue, 24 Jan 2023 09:25:15 -0500 X-MC-Unique: vsV2wBhuNOufnzk2IHIz6w-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 405A385C064; Tue, 24 Jan 2023 14:25:14 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.97]) by smtp.corp.redhat.com (Postfix) with ESMTP id A0FA040AE1E9; Tue, 24 Jan 2023 14:25:12 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <20230123173007.325544-1-dhowells@redhat.com> <20230123173007.325544-11-dhowells@redhat.com> <31f7d71d-0eb9-2250-78c0-2e8f31023c66@nvidia.com> <84721e8d-d40e-617c-b75e-ead51c3e1edf@nvidia.com> <852117.1674567983@warthog.procyon.org.uk> <852914.1674568628@warthog.procyon.org.uk> <859186.1674569545@warthog.procyon.org.uk> To: Christoph Hellwig Cc: dhowells@redhat.com, Jason Gunthorpe , John Hubbard , Al Viro , Matthew Wilcox , Jens Axboe , Jan Kara , Jeff Layton , Logan Gunthorpe , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Christoph Hellwig , linux-mm@kvack.org Subject: Re: [PATCH v8 10/10] mm: Renumber FOLL_PIN and FOLL_GET down MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <863856.1674570312.1@warthog.procyon.org.uk> Date: Tue, 24 Jan 2023 14:25:12 +0000 Message-ID: <863857.1674570312@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: EECF91C001A X-Stat-Signature: 8f8zdnenu54p3geeg8yyo6s3mzaxx1cy X-HE-Tag: 1674570321-528726 X-HE-Meta: U2FsdGVkX18XV3AF7vD9xHJH/6nCAVSxYW+ixaoisiHSqCTe9mI3GHGTdKW9si59HA8vRDqclLkcRv6IkvfV5/fGkiSCyUN7ObjXduLhcjUz/QldtITrF1KbfBNQRzyqbzmdVi7wHtlV84yrgBbGCR+Duo4mLir9KBN2K6AdbS2bARbHypcEtyYhXpYwcumUF4/0n4Kk8JeEuIz2DTB/A0jUU8JgrxeWGlwFccfl8GSUeJHnoWJFULL/Hun8RF1Cuh1qLP5AQsvkUMcPik2U7mhPMTk9UhHrTGrWJyWYwKFktqday7eONeRdg/3vbLFa719Oga5PKeaXnAx6Kk1UYudcuxzay36+Iw0RLbcKiMJcXvELCyyxkBglNvPJVcBGM9HVs2p2MtEtnd0/hSMzjAXYQq4gDQM9mS2I7URiCrzGo6tA8gT9cQUwmFmO/itF5tNKvUJ4FqqhCrLsPmwa4hHXurDitWpW5tV4cYOGkhhKjEjuELGAnrv9vVa/szRbwLuRK6PpqxJKZQ1gPhe1bIkUpAfNcGyGCnZpx9GY/kc/93vzm3NIrU5889wkCQ9F2RMUNVsxC6FqhRLWdSEiA/MmWbh/KFKC68DtICylAIGCtZfwAr8vfOV6OwQpZXcUtXQ3qDDLO0U1u5CgRDvBhXuHybDfkS+1nzDtaZ1YqeA2uUYzGDBKnFtavd0esnql1hb8zh8WEpJ8Gnm7mWQz3WbZs/kPxYpEbtElSPWSmRt9T1pabPFq8K0i8eSys14YX3SaSSomdBXqWNIGtBpt5KUM5XCqdyhPZ549b7zjlQEcJqzob6yHlyCIvALuXzvk2hER9jsqER6wkqArMUX7eBa0kWEyhIqTUeBsxDUnr4Gj2OGrVvYHEENeoHdZpK9c0+yXN+LuA8KCT/vPvuuFSSsS6ozC6/nmGmdoMvFkuMT0YXfeTG2VuFAvPeib+3cV/qB4eMeppp6tB+eiD8W WHL176kx FaqxvWBNqC3DZ6Ibsv0DtmX8TUFcLcF50GxSNRcFa2W+5mjJuq/gVmNAizqRGME61fuQ/nD3BWlL96Xe/ri2awpCHo2NkB11eeyV0VbiRvQoSt+tgtSpmR2Sp+gv5ODMWJQekZJe/1hMpsodBjo/d1BU0gW5TDFzx4I3hWkAwzkEAl2/I1R9qEm8lB3Mz0oBaQLfetQYg2XxOmBU4/As/aawBPkVZOkubxAsRH86SnvwFj+xDmk0Yj31pNPhBWB82P/soRef34sycPZRr6MOY9jgwxw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Christoph Hellwig wrote: > > > With the latest series we don't need PAGE_CLEANUP_PUT at all. > > > > We will when it comes to skbuffs. > > I'm a little doubtful of that. skbuff fragments will be and will have to be a mixture of allocated pages that need putting and pinned or non-ref'd and non-pinned zerocopy stuff. I have posted a patch that works for the limited amount of driverage that I use on my test machine. Think network filesystem messages where you have a mixture of protocol bits generated by the kernel and data provided by direct I/O being sent by zerocopy (libceph, for example). David