From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFEA9C282EC for ; Mon, 17 Mar 2025 09:28:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 62E95280003; Mon, 17 Mar 2025 05:27:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5DE69280001; Mon, 17 Mar 2025 05:27:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4A8FB280003; Mon, 17 Mar 2025 05:27:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 2D223280001 for ; Mon, 17 Mar 2025 05:27:58 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 899ACB9FC2 for ; Mon, 17 Mar 2025 09:27:59 +0000 (UTC) X-FDA: 83230516278.13.7C9FE80 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf11.hostedemail.com (Postfix) with ESMTP id 938BB40019 for ; Mon, 17 Mar 2025 09:27:57 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="dJYt/3k0"; spf=pass (imf11.hostedemail.com: domain of maz@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=maz@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742203677; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qKhoEkqZCXcPPxfM9H7ezBuzdyMwWiKlJTC0V69eh48=; b=gKH6sJWM1cm0O4r+krBPlwmfr8hCuhsgeg2FD6GmMaGjwz31vpM+Qp+SpL2PNYcqrIZUaR Ak8bkWmoWHHtVhNE1xGbf9KdlWwd01EYkN+W0hL5qIsvUgO5u6Jand3SxhsDiS+i8xSaWj 8G7grwaQMmSHayiwQLZGetb8YKYQdho= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="dJYt/3k0"; spf=pass (imf11.hostedemail.com: domain of maz@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=maz@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742203677; a=rsa-sha256; cv=none; b=0V5eTo8jBEfF+uN8nR1CPLgue0oL5m2r5l9FSyrJOOZBYtinzMsLzMRPQwkHpsUpb7FdFV sUwIykFC82BC+ZZ5szMUlJQWvPajFIp+Wk4ln/aTuEIkCIQvjTzXmE8QFlSLEbrO9V6eNR FC+MgTXVYRiUgkm3TLGqeUfR44d41nI= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id A25AE5C2C15; Mon, 17 Mar 2025 09:25:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 26A58C4CEE3; Mon, 17 Mar 2025 09:27:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1742203676; bh=xX7lHGFYnpplLSbCZnNB6JktC5keaB3sAg4LSZJ5VdQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=dJYt/3k016lB/8vi06XSanBCTpSfH2BWqga6pTd50rbE2MU/A6PFw/OCqXO4lpLe8 glDrZnSBuQ7f4tIJoORMWwOjJqPk/rQefvmcAjcR/+b3UDzghnaBl4sCTkwIF14InH 6hFHFDdDxPBm8D/YkpWbkhI9jgLdrhpFdqfIVTs7JoJ9mAV0xBjHHRyHm/ozfSICup KR5ykY+MrvkMnTLvNnn/qVQRTDbLRSDVFxGPOiba9ESYDDuN7dT/VCgWY50IG93ITl PibJq52FsdT0KMmRpkGFWFFPf1wWFVFwRzlwyDBECGzwY7/1SvO8XCkk7BK/3udQn/ yQuGUeiSEUOVA== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1tu6lE-00EDv5-WB; Mon, 17 Mar 2025 09:27:53 +0000 Date: Mon, 17 Mar 2025 09:27:52 +0000 Message-ID: <8634fcnh0n.wl-maz@kernel.org> From: Marc Zyngier To: Ankit Agrawal Cc: Jason Gunthorpe , "oliver.upton@linux.dev" , "joey.gouly@arm.com" , "suzuki.poulose@arm.com" , "yuzenghui@huawei.com" , "catalin.marinas@arm.com" , "will@kernel.org" , "ryan.roberts@arm.com" , "shahuang@redhat.com" , "lpieralisi@kernel.org" , "david@redhat.com" , Aniket Agashe , Neo Jia , Kirti Wankhede , "Tarun Gupta\ (SW-GPU)" , Vikram Sethi , Andy Currid , Alistair Popple , John Hubbard , Dan Williams , Zhi Wang , Matt Ochs , Uday Dhoke , Dheeraj Nigam , Krishnakant Jaju , "alex.williamson@redhat.com" , "sebastianene@google.com" , "coltonlewis@google.com" , "kevin.tian@intel.com" , "yi.l.liu@intel.com" , "ardb@kernel.org" , "akpm@linux-foundation.org" , "gshan@redhat.com" , "linux-mm@kvack.org" , "ddutile@redhat.com" , "tabba@google.com" , "qperret@google.com" , "seanjc@google.com" , "kvmarm@lists.linux.dev" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH v3 1/1] KVM: arm64: Allow cacheable stage 2 mapping using VMA flags In-Reply-To: References: <20250310103008.3471-1-ankita@nvidia.com> <20250310103008.3471-2-ankita@nvidia.com> <861pv5p0c3.wl-maz@kernel.org> <86r033olwv.wl-maz@kernel.org> <87tt7y7j6r.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.4 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: ankita@nvidia.com, jgg@nvidia.com, oliver.upton@linux.dev, joey.gouly@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, catalin.marinas@arm.com, will@kernel.org, ryan.roberts@arm.com, shahuang@redhat.com, lpieralisi@kernel.org, david@redhat.com, aniketa@nvidia.com, cjia@nvidia.com, kwankhede@nvidia.com, targupta@nvidia.com, vsethi@nvidia.com, acurrid@nvidia.com, apopple@nvidia.com, jhubbard@nvidia.com, danw@nvidia.com, zhiw@nvidia.com, mochs@nvidia.com, udhoke@nvidia.com, dnigam@nvidia.com, kjaju@nvidia.com, alex.williamson@redhat.com, sebastianene@google.com, coltonlewis@google.com, kevin.tian@intel.com, yi.l.liu@intel.com, ardb@kernel.org, akpm@linux-foundation.org, gshan@redhat.com, linux-mm@kvack.org, ddutile@redhat.com, tabba@google.com, qperret@google.com, seanjc@google.com, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 938BB40019 X-Stat-Signature: curfsodguw3ypmpnrxwifmbqbbowe6g5 X-HE-Tag: 1742203677-625001 X-HE-Meta: U2FsdGVkX1+TfEzcTNKVdvSx7egnmqvBwXalqFPbrRKdthceK543k9kL7O/TwaYAH+twN3AUofPmNQcWwR4G4+K7+ShNxWA4jPm55hymSQ9H9wEQl93GP7Whl/tsZ8dwD2bq53u7K5kMDVRaXtZa0Yf8H3F+hLZ5b35jZsnYoAfJgcRiO+MWofqqXyQMLtzAweUpdMbo9St69vKOl5rSlRFJKrcGqJ3nkr5IW5DWv67jhqI110ORLvh7/nZ7G1n2+3aAkYaLm1X1pitIkct8LDMKWi/HJx9hVEihNC/7rW2cfX2yyr0o/ART2Ea/xhT3ooXh9MQ2d+34fE0d4I/n9JKiHKJzCdhxMA8tjeQYbzRcsJpXHmRE4yViSQX4LmzGjvWfYU7/xgKoEJvRqir7E1s/JCl6N6Wo+l3uo4dOI/AJW/XdfcdAH81OdcZ033mdr7MNJiqOBSHJbHFrKCns10UUQqlIZwrHgjDrMVEEn8FRzdYrh32fS7jghWrZBhl2RhRTr0UciApnlcovgWFKDQe7o4PpmULeirQJyz0s8Xvn7C95f/OC7oG2s34FChou+FvmC4FCDH4AF+acqUcHxTzu+TSVOd5ZyKkBFiMCpXbEpd0lFvSrQa8yohNjyQW8Z6t/c30ZynvPLcccr/+cYpE7baaTlBwjsvYxRkgu2k8lJzZE9UvClhZ9ozMhqSXrPjgzzYjM78LD/AZbSeRVaE1mhdiqsq0MadQZx0q48xYZhOW5mCHWYqOva+V5izaGU32sOFlEhY7FPknYRZtUnsixPaTewiDOmcobPSYBAHI1wBQ+90+iRaFPfRVC/tdde0YLt7lUH4lLKqhNdYUhPeWh2o+3Wr8NSxa0ldAUdjaXL39uRhClVWSo1WytfJVkmqBONGhmI2ygkWZPkeGBZtj0l6WZP/KbUkFlnT7R2bepqHFkzjcpU2AbD1t642VZDGEyyh19ECIvR78v6uG 1lXHJjr1 mBvk46whBP0Yeb6Kw373+xjVOokCtaAowGoCiEBcvpqoMvlVRZIAA9chSee7lTWajpy5Z9z06qbsVDEo/RVFiL3AO+bRhaQTs0ybiG0uqT/s8f5wt0g3TfvIwTEBCx445lRrS9NsTx9E6/HOZCyJiWTnq1ZgwLkxO0W7WuJtBvbwTP9jyUf//cTfJFkdLeAtXu6KSI1HtA3RSjVsqO5kOlvdiDdGr9iQ+mZNMv2+O5j6dJqY1sSDy9mYzjvCubSh7mUf/NOxILrqsOglHb9KTu+TUFw/W8TbMEnWr X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 17 Mar 2025 05:55:55 +0000, Ankit Agrawal wrote: > > >> For my education, what is an accepted way to communicate this? Please let > >> me know if there are any relevant examples that you may be aware of. > > > > A KVM capability is what is usually needed. > > I see. If IIUC, this would involve a corresponding Qemu (usermode) change > to fetch the new KVM cap. Then it could fail in case the FWB is not > supported with some additional conditions (so that the currently supported > configs with !FWB won't break on usermode). > > The proposed code change is to map in S2 as NORMAL when vma flags > has VM_PFNMAP. However, Qemu cannot know that driver is mapping > with PFNMAP or not. So how may Qemu decide whether it is okay to > fail for !FWB or not? This is not about FWB as far as userspace is concerned. This is about PFNMAP as non-device memory. If the host doesn't have FWB, then the "PFNMAP as non-device memory" capability doesn't exist, and userspace fails early. Userspace must also have some knowledge of what device it obtains the mapping from, and whether that device requires some extra host capability to be assigned to the guest. You can then check whether the VMA associated with the memslot is PFNMAP or not, if the memslot has been enabled for PFNMAP mappings (either globally or on a per-memslot basis, I don't really care). M. -- Without deviation from the norm, progress is not possible.