From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC578CE7B10 for ; Fri, 6 Sep 2024 13:41:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C55E56B007B; Fri, 6 Sep 2024 09:41:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C066D6B0082; Fri, 6 Sep 2024 09:41:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AA5A16B0085; Fri, 6 Sep 2024 09:41:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 8711E6B007B for ; Fri, 6 Sep 2024 09:41:09 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id C1BD3A186B for ; Fri, 6 Sep 2024 13:41:08 +0000 (UTC) X-FDA: 82534424616.27.DBC7798 Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) by imf25.hostedemail.com (Postfix) with ESMTP id 9296CA0014 for ; Fri, 6 Sep 2024 13:41:06 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b=o5IpbmAM; spf=pass (imf25.hostedemail.com: domain of axboe@kernel.dk designates 209.85.210.176 as permitted sender) smtp.mailfrom=axboe@kernel.dk; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725629936; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JRirsGjPeUp2chDtEYW/fu/UMEDf6TFEgxx2jXP3/Pg=; b=LVsfwRfvTpmb59Ri2htqFi0lkR80Fl8Y1Gs/IxJmRKzCq4HUSGPM1IS2Z/F8IWenrIX2V+ RrfiebdHs/7gyLAv4nM+gh/RrePnj+e5j/TGPHP/CIqfj4AXS5UeW3TxUvagQkAQxK9Cb4 f8Dlud6jOILs8TE8KIuZ1Wjq1xPup0g= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b=o5IpbmAM; spf=pass (imf25.hostedemail.com: domain of axboe@kernel.dk designates 209.85.210.176 as permitted sender) smtp.mailfrom=axboe@kernel.dk; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725629936; a=rsa-sha256; cv=none; b=sRU6ie99VDZuABwk3LOXO6E/utrGTliK1+Sm2BqixDEekgdP1oOlVmrZznjBMU901urXyt P8phcdnI2wGKecHuZY5dG/fwZ3m1RJnYJyCedJTKa6Z9BPpSyXcTpDFByQ3r5ybnQATJQQ sqbBRDvyK8R3tznXmf0oOZOQLQ6lb7A= Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-71767ef16b3so1299289b3a.0 for ; Fri, 06 Sep 2024 06:41:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1725630065; x=1726234865; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=JRirsGjPeUp2chDtEYW/fu/UMEDf6TFEgxx2jXP3/Pg=; b=o5IpbmAMrpIAWu/t4QkZCq6MI1wxt+0sihiUIv2oDiIndlveB0LaIfaYIGcBCJYTFU gNzepyN1GP3cO0O2S2+FZf04kWOSov4BYVDfmLqTksJEMxeYzUMgiVHJl7/FNV2anaWp IhR2Rw+RRtWcLjLNaxQ200y1q9xFtgBrcFAgZpY7C3Ups9fxQGtDhTOzrOA1bDvXvlyu 8b04ugVrbjXXQMmbPI0KKbjsG/pXE4beQZGB3chUDRlK+zt8kuKAKesZe15/SgOirQDb MKzTxOPNGAhBLEixEGx2swuQayG+Mzl6YlUEIAuHvmPkwbpKfUkULI5U1NhcLOCN9781 hDWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725630065; x=1726234865; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=JRirsGjPeUp2chDtEYW/fu/UMEDf6TFEgxx2jXP3/Pg=; b=es46pKbSMkhjl38G4I0Oerd9cd0NooyCddvW2SS7XAXm/2LB4dEFYwkuh+l9a+n5Y+ YeHyNy5p2f9U1Udw9VI58kNpWRoKZSytb5tTs58Qi6/siEvjctjzqmt745eqFRlQedIG mmvznYzYQ+5Gv4lzqc6qBqhkGVLlV0Ld5B3kGjtET91ozl6w0yOUwolnpLLqr0zhnyZv M9QkljcUfL5uBUSWh8tbpzAKdCSTHrSLs+Q1cYIJba5fAi895trFYJWv18QvNZyxGH7Q Jtvcd2OfJIgwCqn3UQ3yrG97Q3N1q26sHsP5l5dz60LzvzsH3n7gqmvmGdzZywsjFsmO BvYA== X-Forwarded-Encrypted: i=1; AJvYcCXXpam/Tijs47Q5dvVfUctjzjLLsNr35WefJpSE76/y7XWyrenzVmT5tmCVL66YZhJVfimM8nh6pQ==@kvack.org X-Gm-Message-State: AOJu0YxeAuRt9PfCvEUNkoUzc06DDc2OYCRhCK2jdsUa9DM/O2iN+Ci/ cgAlIyGqsSXrOSLuIG7uwV5Vl3X1R+B1CyQp6VLqcIuqiLRKtKpYZxdxMxEbcaA= X-Google-Smtp-Source: AGHT+IGeJ6M6dQjSLqy1fgzqwmrtr3wk/1kaLXDHkr4qNURYJIsAGjcI6TVVPF8Mlyve939Cnkj3Lw== X-Received: by 2002:a05:6a21:3942:b0:1cc:dedd:d8ff with SMTP id adf61e73a8af0-1cf1d1e0709mr2780890637.43.1725630065079; Fri, 06 Sep 2024 06:41:05 -0700 (PDT) Received: from [192.168.1.150] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-717785331dasm4830923b3a.73.2024.09.06.06.41.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Sep 2024 06:41:04 -0700 (PDT) Message-ID: <862f125c-9710-4abc-a229-5f7eb9931ed5@kernel.dk> Date: Fri, 6 Sep 2024 07:41:01 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 7/8] block: add nowait flag for __blkdev_issue_zero_pages To: Pavel Begunkov , io-uring@vger.kernel.org Cc: Conrad Meyer , linux-block@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig References: <292fa1c611adb064efe16ab741aad65c2128ada8.1725459175.git.asml.silence@gmail.com> Content-Language: en-US From: Jens Axboe In-Reply-To: <292fa1c611adb064efe16ab741aad65c2128ada8.1725459175.git.asml.silence@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 9296CA0014 X-Stat-Signature: 8znhyaygrrwz91dmwxkx691infj3m8te X-Rspam-User: X-HE-Tag: 1725630066-446119 X-HE-Meta: U2FsdGVkX18bc0goGm2bdZKcbX8ymDCyifOdQf/ZNlD3ibDt2nVypqdbAPqyNLDFLucgLuqS2+ex1/ywqlI3O0K2XfltHlhpKwuc1Zhf0PYkbOLyngBcsgFi1XpulQvhh5NLUdQe/ja2RcB5jRZo0BIX3kLSfO7Du/A6llVbbhPemQeO4IiojRD+tj8kJajflxGpPgtPxbnsyaqrjIOuEVStpQT1RbS9PaKCERYpJbepQ44hCpV05X/KnT9WelTccBBgokzstV8i6FX3Tvh006jUvw6x6fWyVY1BbKfZBVgo93ATew6zoegLaj5D0EgpJpuzVkEECZdVVUBELa85wgIsbo96x2FJzZZ2UJuSUHb8JV8rI4nEoJM4ESEhwK53SWlDQb/fxQw7CTSeVI725Yw7h8PHee6vV0mmTp7WrN4l3eDpgH0jy+wVC8rlOGGLTpx4GEl0k2Wf5SaBRLYsOuyXC4PYfYHfj7S8BpDzra/+/Enu7k0BaOpqS58Tt6knwgxo/bGLWBRR2iluN9q8J2T+WGT9t/J+YiC7RaH4ej2H22ClG8OFn6bRhKDm3L40hbHyGRQ0hXjsI2+m35DXGeiwPG5M0izQsqns/tOk2No2T4bVskXETns/d8aQECPqDGT/c2u3SGkrje5MfiCMwlRZUHEDfazM1VDZ1C8ytaMN4DycJD64eQONyjaJwQeXAVcX5Zun3hTwxH9CwtX2R1UV0zlHse7QoDYJexmIpv0/2dQ7pZLHVN3S7SWvZCbJsKqwiRSpbEUuoYiLo+L5ju9nNomaODza2KzfjM23/jR7yggvpV4gnDQJ02KGUhFyHGh8DKpWBx3PisWLxmtMackzwV/L+hp5Lmtr1Rk3vzXi9QUUaP5TvTfNmRu+lbvRVkIcdrhuhcgI4BGMLGPgWpVKQi2cPMkuh/FO3mD75ibSi4iBXCdLl7UcoupRS5eJWAJnZroaW09KiZp+JOx 6IKpE1yt m5pl2RZwygBJrpHs8LBu2LSwwI/3BXtP51FnB1oLXYt+7O8iEjPTQZqk0QkOycsIW+Qnl1CyIquCIMWIS/NBQfPcTq3+7zmuLjL+V4Tt/WqZ0yoV+GiloNqSVuiuORUaIzCXGeo9Y33M7HvaFjOqyQ4UeBhIvVA3qmBFOYhDLouHg/zo004G+IfLmiNKVSXc5PlQ2K8UmWgJmQQ6z6hoz/wiBCZtTymoHIF1FXLqKIPk+XhGloKeWwTIyXwoASUTDO24MF596kFQb528v3L0onkwfLCuwgrBGS2OKOsJnKyo5ZyBK5fPyQUiTlQ2a7epQ0te5Ro0yQVQFm09SGM41NC2tV8//wQ13BWJUtMaKMFi4y0G8JYkCK2qK4EdXWgQQYbEXOgUuVv5z5N59V7ep2OqsB0b1+r8RI8oWWd3c135RiXK9BUcobSpf9ROMyZhg5b96Ae99t6Lcbs+r9XofVGGWtw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 9/4/24 8:18 AM, Pavel Begunkov wrote: > diff --git a/block/blk-lib.c b/block/blk-lib.c > index c94c67a75f7e..a16b7c7965e8 100644 > --- a/block/blk-lib.c > +++ b/block/blk-lib.c > @@ -193,20 +193,32 @@ static unsigned int __blkdev_sectors_to_bio_pages(sector_t nr_sects) > return min(pages, (sector_t)BIO_MAX_VECS); > } > > -static void __blkdev_issue_zero_pages(struct block_device *bdev, > +int blkdev_issue_zero_pages_bio(struct block_device *bdev, > sector_t sector, sector_t nr_sects, gfp_t gfp_mask, > struct bio **biop, unsigned int flags) > { > + blk_opf_t opf = REQ_OP_WRITE; > + > + if (flags & BLKDEV_ZERO_PAGES_NOWAIT) { > + sector_t max_bio_sectors = BIO_MAX_VECS << PAGE_SECTORS_SHIFT; > + > + if (nr_sects > max_bio_sectors) > + return -EAGAIN; > + opf |= REQ_NOWAIT; > + } > + > while (nr_sects) { > unsigned int nr_vecs = __blkdev_sectors_to_bio_pages(nr_sects); > struct bio *bio; > > bio = bio_alloc(bdev, nr_vecs, REQ_OP_WRITE, gfp_mask); as per the kernel test bot, I guess this one should be using opf rather than REQ_OP_WRITE. -- Jens Axboe