From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E853C41535 for ; Sun, 17 Dec 2023 02:03:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 699996B0074; Sat, 16 Dec 2023 21:03:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5FAFF6B0075; Sat, 16 Dec 2023 21:03:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4EA0D6B0078; Sat, 16 Dec 2023 21:03:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 3EA8B6B0074 for ; Sat, 16 Dec 2023 21:03:48 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 0DF9E12078E for ; Sun, 17 Dec 2023 02:03:48 +0000 (UTC) X-FDA: 81574664136.28.3FECE75 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf30.hostedemail.com (Postfix) with ESMTP id 669948001A for ; Sun, 17 Dec 2023 02:03:45 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=1SC7We7T; dmarc=none; spf=none (imf30.hostedemail.com: domain of rdunlap@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=rdunlap@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702778625; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wSxaOslInFaYonzYXDSErFQurFpPyX2ZAWJ45tnIxmU=; b=21JeAj9v922dVVfpWgKXqy2tBwQYr4QHmnNuLU4xcKhr4dGcjaE3VI/vk2FWg1ujJ2cSNw 9YzwW0BLYFTkObuAPQyfI97gCcxtJGgOjI6yH+XZOw7D9TL9pZ4ZEJ4BgbQYQXgwr+/1g7 gSVc4BhJLCOwjh4CrwBKGL6qQ7d7/7o= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=1SC7We7T; dmarc=none; spf=none (imf30.hostedemail.com: domain of rdunlap@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=rdunlap@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702778625; a=rsa-sha256; cv=none; b=Y4Zut1Mv/0wPD5RdNgmy4XWmZcMUUrMLNmQSOZYNwMTkWGYd/pDTueQbv5zB4LuLtoWInk tUg3I9V27ddLAR+09UskHqg21I64lvd+0W4T4wv1y55Ut0wl5lmwja97o77tmY5WwbfY1e 5wTMDCXNMUfjOE7yCzGkk7YGSRuzIZg= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Sender:Reply-To:Content-ID:Content-Description; bh=wSxaOslInFaYonzYXDSErFQurFpPyX2ZAWJ45tnIxmU=; b=1SC7We7TfTkAliYcUVp07bbaHo sEKhmoTHHkl+lZeeuq9Z7k5SLs66o8RXWdkUTSw5Oeq9lzilQeiRBzD1RjJNTlkQVm8jBq+9Gdmwm KabnLTExPA5zrWt5QpMWLVPPujApVtez+zmVUASsNzhEmHS2ihFLO4Ln82TRfsxa2DcrblKgUs5nx WpdAA1sz91RwOztxpm9W+v+TSAu68OhQ/QojCdTyo4ZbRnBDg1xU/eST1X1ZYQuxAEUHc2Lxha7Gx uS0PFSz9HfrcyX/rekKwkv2RFIHwbpDY+YaJTi4qSskTQbef8Un5o0/Z7mOgzjxqbPat2iVmaFI6e hR/Pb9lw==; Received: from [50.53.46.231] (helo=[192.168.254.15]) by bombadil.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1rEgVF-0070Vy-0E; Sun, 17 Dec 2023 02:03:37 +0000 Message-ID: <8625718c-b8c2-448b-a2a8-7153aa74ce29@infradead.org> Date: Sat, 16 Dec 2023 18:03:36 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 46/50] preempt.h: Kill dependency on list.h Content-Language: en-US To: Kent Overstreet , Matthew Wilcox Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, tglx@linutronix.de, x86@kernel.org, tj@kernel.org, peterz@infradead.org, mathieu.desnoyers@efficios.com, paulmck@kernel.org, keescook@chromium.org, dave.hansen@linux.intel.com, mingo@redhat.com, will@kernel.org, longman@redhat.com, boqun.feng@gmail.com, brauner@kernel.org References: <20231216024834.3510073-1-kent.overstreet@linux.dev> <20231216033552.3553579-1-kent.overstreet@linux.dev> <20231216033552.3553579-3-kent.overstreet@linux.dev> <20231216223522.s4skrclervsskx32@moria.home.lan> <82ed43c2-2a9d-4c5e-8ccd-8078397b7953@infradead.org> <20231217002028.shjg6p7wa2cmtkq2@moria.home.lan> From: Randy Dunlap In-Reply-To: <20231217002028.shjg6p7wa2cmtkq2@moria.home.lan> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: mj1g7wa54fcd5kfxip7qp3ctth3d7u6f X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 669948001A X-HE-Tag: 1702778625-567951 X-HE-Meta: U2FsdGVkX1+3fMxT8xddcNXjQxNuOGeTloQsVv3gq1fCdOjCZlJKNwfx5pwNAEQlPRefAAG7qOMGS/QMVNykqvT5GcpszFv/avHlD35bjHsHDrq+24cmUXLmDRf95qBXFn1Xmx/842tfzoHb9G4FmQAqRmynOLzpl9SQ4zjbdnlweJguOIiUOGeJrUwNkAy1Y+rdRm0rVuVxhn/I4J/2NIhWTQSUAzamRvcCLgeL4gZhsFmXlMTO5LD3slok4QuJjC+YaagdEg6kQdY8Lql0lfIlae/0PypriV6zZMkQzDDzZJqksXrbFe/4Ew6/zqa97ZWzWvOFrsH9Lu9rxB6LtJHhKf7s0HJz+ip2ctiau9LooCtKryZiloxZZZTeOfDutliq6O2GdGtQjrcQiNA5lsnFEQpPaxoJOVvGWMALWUl2uIQ/tjw9u8bAFl8kElBBmd1vmeI9v2XwjHvDV09/c/e3Dz0BgmaQhsZtg1D4N6w3csqcfhhdP6GA1EFJyFPOyj/qfrbryZxfGOxCBBwtRH/Os+8aQMyrMYHucmyb9BoQD1IeJbAIX291V9MJAyjoJrn3QQxAJ9NFbjvFVHLMQqDT6jPT8sJiMBCQPhfYu3L58Wo3ra30GAbQHVzb/1bcueDsmuXCiwCUNtvWpl76Gq0g6j2lLSTTGTLXZaaQWOe25F/Wwlwrn2lkBmE0z1a8f6Gdo/MWYq0rLCpoTYm5/hW/WkB0Lu9WuUCRcSCyfu8g7gcdhQmXKco6LMX1URn/Q0ThsyeHHIKrnsDDK17AfNE+3KzC54B2jygF2kjytMqsefZVQ9Cj8DqWXktHs0/cJlgewbuVH7J8qBdCPApAwaTSE5S0x1bARMM6xXPOAy238Vvgw1mYgwX67gAB5+8yOF7F0CDFGgZI9g8uMyBMod/NzZoGhzQj4cfyD42GvwFx5qfNIPk5KEK7PmA9kwF12wsV3jY6jTEhhXe5PZ7 2aDjN4By a1AcZvgEzKTLG3gAmV7aX+LFea+YdIH6UonvIhfn+v6KIgcvNLqBk3LQEzdszkVD2euCTdTNLIrkiWI9EpnaJ2XGz4g3/jiN5d+t5hUlhxRy/bkhjiUiF3q+uEGy/2Y6MYesN0PkHhVSIKkKNUWMKol3JHBQ2V6hS0isorF2zbHX+rzFcR2BSdFG0SdbYLdge0YQfEsE1CWh7RS4m5KvvcpExw5O0FApJfgZa8s8BpfkDy4PRLJrM3dQL2aw0sJYKr6E4t3O9QoPCN2bI704LTg8IQkitYQ5CAgFE1Z8+cbMpDr4QtAFJATAzeeB2Au+3c1k6UGIldML3clpILCzmEjAN36+neGRCPnUtCmh3b9B9B4RdeUPXCnNQddzf6eVGZa9OOGxSsYBV9/wrlpeOL9EIKdDYYODz/kUjO6JvXzjFAtYz9Fr1ygpgyw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12/16/23 16:20, Kent Overstreet wrote: > On Sun, Dec 17, 2023 at 12:18:17AM +0000, Matthew Wilcox wrote: >> On Sat, Dec 16, 2023 at 04:04:43PM -0800, Randy Dunlap wrote: >>> >>> >>> On 12/16/23 14:35, Kent Overstreet wrote: >>>> On Sat, Dec 16, 2023 at 06:13:41AM +0000, Matthew Wilcox wrote: >>>>> On Fri, Dec 15, 2023 at 10:35:47PM -0500, Kent Overstreet wrote: >>>>>> - INIT_HLIST_NODE(¬ifier->link); >>>>>> + /* INIT_HLIST_NODE() open coded, to avoid dependency on list.h */ >>>>>> + notifier->link.next = NULL; >>>>>> + notifier->link.pprev = NULL; >>>>> >>>>> Arguably INIT_HLIST_NODE() belongs in types.h -- we already have >>>>> RCUREF_INIT() and ATOMIC_INIT() in there. >>>> >>>> I think I'd prefer to keep types.h as minimal as possible - as soon as >>>> we start putting non type stuff in there people won't know what the >>>> distinction is and it'll grow. >>>> >>>> preempt.h is a bit unusual too, normally we'd just split out a _types.h >>>> header there but it's not so easy to split up usefully. >>>> >>> >>> I don't feel like I have NAK power, but if I did, I would NAK >>> open coding of INIT_HLIST_HEAD() or anything like it. >>> I would expect some $maintainer to do likewise, but I could be >>> surprised. >> >> There is another solution here (although I prefer moving INIT_HLIST_HEAD >> into types.h). The preprocessor allows redefinitions as long as the two >> definitions match exactly. So you can copy INIT_HLIST_HEAD into >> preempt.h and if the definition ever changes, we'll notice. > > I like it. Possible to revert 490d6ab170c9 ? although with something list this inserted: struct hlist_node *_p = h; and then use _p instead of h (or the old macro's 'ptr') The code looks the same to me, although I could have mucked something up: https://godbolt.org/z/z76nsqGx3 although Andrew prefers inlines for type checking. -- #Randy https://people.kernel.org/tglx/notes-about-netiquette https://subspace.kernel.org/etiquette.html