From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9801DC7618B for ; Tue, 14 Mar 2023 22:53:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 202616B0072; Tue, 14 Mar 2023 18:53:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1B2926B0074; Tue, 14 Mar 2023 18:53:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 053C68E0001; Tue, 14 Mar 2023 18:53:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id E97926B0072 for ; Tue, 14 Mar 2023 18:53:02 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id C3F4C160E25 for ; Tue, 14 Mar 2023 22:53:02 +0000 (UTC) X-FDA: 80569005804.07.19A34FD Received: from mx.manguebit.com (mx.manguebit.com [167.235.159.17]) by imf15.hostedemail.com (Postfix) with ESMTP id D131DA0012 for ; Tue, 14 Mar 2023 22:52:59 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=manguebit.com header.s=dkim header.b=tEVGR4Cp; spf=pass (imf15.hostedemail.com: domain of pc@manguebit.com designates 167.235.159.17 as permitted sender) smtp.mailfrom=pc@manguebit.com; dmarc=pass (policy=quarantine) header.from=manguebit.com; arc=pass ("manguebit.com:s=dkim:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1678834380; a=rsa-sha256; cv=pass; b=EbMdt8QuOwwOedoM7m+yJtrduL5cVrwFVfgyiR40mtxNoe/v4flakK4m8F1aNrLd39YSvJ OX4U5kqb8eMt0SbD+CI57hCdETDIfelawNk4afV+sCB44d2FLhztnDwKZ4I5qKMszZ55lr dyvBCdA10dqJllB1/tMYLWbtz1f5SyI= ARC-Authentication-Results: i=2; imf15.hostedemail.com; dkim=pass header.d=manguebit.com header.s=dkim header.b=tEVGR4Cp; spf=pass (imf15.hostedemail.com: domain of pc@manguebit.com designates 167.235.159.17 as permitted sender) smtp.mailfrom=pc@manguebit.com; dmarc=pass (policy=quarantine) header.from=manguebit.com; arc=pass ("manguebit.com:s=dkim:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678834380; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OfTmHuG7/JVkukj6i9UvqcVneAXUFxJc9BrAXcIEPfA=; b=8O66Db9Fsy+JhgKlHK04/BwbJ4Bmsj/bYSnUzj8aBzEPGQHjNuj/QUA48yeYgehAlM9vc2 akb2YuoOp6YT4LaMq4FxobUb39mhp210ytjsJw7P3y1Bbdt5IH2FZdSsD6akmOHLWQxLr/ ej8+oyTo2zWJqEHwy1n6fBkY7VDomnQ= Message-Id: <8621e53ca50226823b1ee6c1ec9d40ce.pc.crab@mail.manguebit.com> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=manguebit.com; s=dkim; t=1678834375; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OfTmHuG7/JVkukj6i9UvqcVneAXUFxJc9BrAXcIEPfA=; b=tEVGR4CpZY6tuUOTQ+3sKHsqALva5ESHJluPSSoqSsI0dXFvQZro05N1h/xvBmw2W71ipD n/bt4/sGwgCgve2usmycJaqjlobl5cnG9qnK+jumdZoginAwg6GcwMmd1tEST6UU/FdpAT V0z0CZAOmzJv+T9HuAcs+9FvBCVLOhJlDCZxA+NIfb0xXFTdVEyXSMRJSk8zu5GFeusn9w /pPZnDRX780vT1JMZBaz0DyzJxVy1kvlES6NnnI/9hvoGSLSVuut53xCd4KHlIpqZU99RG yYD9JV8ey82aMiUkNfWjg70xKGtSmSlZb9MQWh4/fWmHuUdEWx8bwcOmt/fMtQ== ARC-Seal: i=1; s=dkim; d=manguebit.com; t=1678834375; a=rsa-sha256; cv=none; b=irWPiCIKBmyUp/1SgHmr27JoNn+cRe6BWTFWBeaWgKShG3kcum929GJ1JWT9yhB1qh1LC9 QYTdtvQoHWMiFUhlwfOT8tfzESQ9ixVy/pTpfkFJtaHkE3o+A8+fZcIptLJaAXml/nnAev cHOiqAiBwxbx0Fgaz+N0JH+6W/rsFzns6hqlnHUoK7yKtXB9eM+3yf0rtRU3TU/epNhCNB 7B6iPfE4z45/+Q0gm2fvPsW2u8cWbDStCHl89r8Jit56F2EVXXqDpYArEHNRnlwnM2ksQ4 uRR1VBNdP84FBbPeTlXDOTY8J8PDTUDgDarTALGpMok7HdvMvDYa/MQFsTvPmw== ARC-Authentication-Results: i=1; ORIGINATING; auth=pass smtp.auth=pc@manguebit.com smtp.mailfrom=pc@manguebit.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=manguebit.com; s=dkim; t=1678834375; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OfTmHuG7/JVkukj6i9UvqcVneAXUFxJc9BrAXcIEPfA=; b=HHNOdTIrWMStj6EtyFNq+tmH8Uc/RD1UGUqPD0NTxnJ8fVPAuTlhouw26AfWasZAGshT5C INLA7884qP/NYT2whmwTIH+gvLz+uIPEUFkvxsczbw0AhSspkiLUY98GirkY70BUtRnrdt PsSegNawVvpUNuBnTNWsv7bkK9lAo8Fdk9KYzLp5uaX2tEDo72TTzzzc7hIBivoKorlBJL 6QUS4+7Bsq3VEQl2s6+ZVsJVet21x57JzBOnqApPi7+wJPLdLW8HAtsEC1fBr56A3Lg74h bB3YBIgWLoan8BmWoeUnOCnnV0cdff3t0sc1vst9D9pu9/2H5FiOZYjzchJJFQ== From: Paulo Alcantara To: David Howells , Jens Axboe , Al Viro , Christoph Hellwig Cc: David Howells , Matthew Wilcox , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , Christian Brauner , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig , Steve French , John Hubbard , linux-cifs@vger.kernel.org Subject: Re: [PATCH v18 08/15] cifs: Use generic_file_splice_read() In-Reply-To: <20230314220757.3827941-9-dhowells@redhat.com> References: <20230314220757.3827941-1-dhowells@redhat.com> <20230314220757.3827941-9-dhowells@redhat.com> Date: Tue, 14 Mar 2023 19:52:49 -0300 MIME-Version: 1.0 Content-Type: text/plain X-Rspam-User: X-Rspamd-Queue-Id: D131DA0012 X-Rspamd-Server: rspam01 X-Stat-Signature: 35fgjbfow43g9wy4g8as8ecqmfrbin89 X-HE-Tag: 1678834379-408126 X-HE-Meta: U2FsdGVkX1/9gVxStLUJq8qBs9zz0eT4tmM+RQzeBL/g2sJDxMnkx4gNs8xNNdOnXXZcFwxFlzqLwX3/yGL4BtBEs5RB6Fz5D8CPZcNLRH09YoGJtBAgevxQe0Hrv4nX+kGpUEsIQgB17an3Rle4mqN9rRahPIRVhDxRZXrbfWU6pt9aueSmcN9UwhuhKrqInERSQdAqBpYtHfgINGIbNpDt9KlUls3+JsQ/o34CgmW0N+wrOrJR09pVv1FNFZG/PVnUDHQG40MZdvUFb/mEGiyb6/+BQS6LcwlVePaPdEKIi9SdpkVhivnfn29RqdU+rqu36W/KrecWxyjYYqpaJNDTSwbrJdvcnL5h9H0GXX76qLpyHGxVnQJTBTCUG1BvpzlhxdR3OSbc6KIvIwShY8GjY8KVHXw3U8+46OyONm5+GLxTIkP1XVYAhpC5h2vPJkxPn/Yk8lcdMK7zRQ1zwx8bWGK9IP3nQR1yvMM5MM59vqdhP5eeHfYYyx8TGe7x9tUKP4JsJN2LedyJpYZnO9+PPLpOdAylenvjvWeYN+B/5ATu2umr6eCZiCUwU7o1DEMU6uYYQyvAEuruGVAxMXsigbJLy9Y+TuApvobBM0+37tPKbpbtwRBmocvCf9soULEbPXBobOIAyStRIMNWGjH/iHMALtXBiH4agNWh+R4F122DNigONVDPJRHW255PVOhLe31R85I8h1ikr6EBbFb4hW4hLViNZYgGWsF17rza/YB4l739ovHtsga+Rk724ZHWboSNF+FpJpKGZnUDr+e3NG1QtbnZolFX2A9FYgKlZ1uk8AiTciiDCKth1S2We0kgj75gHEvV/s5/CU4l1m6cYeiO+xqI0KqJXRhD4cBSPoP3HsitvUo6XzfaVUBn5rmy5LjQUAaHg0lk6LuvLzUWYsAH3J8GzwDj0Bf5iKzn4qZNUTAzW1Kt1iafkm3IuWoCtbnos3cYzdMyrdp 8VnZk+W8 yshSNeU7NBVFRpDw7M7TVUxrd6OOxPGB/gjS6NTG8cRDGEIicTTjwIwPei7nC9MMwIIXYW1mqCrLKqQXx1X+u67cLQpyV/l71auxNzNQmNRYk6KWNgFYZiuZ8LzDCh+qyq5fcumz25eizZzpkBfPa2qaosmoSSHffj8mEH+bzLn5n00CmQmMZ9Tln7XFmNe8fuMXSDlueoVSgY5BuIIOA4JwEjMlyQU4rbatPeoodPy8+iRxiq4DD6D7ibWb8WX+0ijIrHFuigYJ4pWaKxFQef6gpcr+mW8/oNxmoAIrHEhFnpqvnTVffayY6jYuaaplFhKyKk0yF7raT+KVEvlQjbIJYAUDoVC/zg2tGVtSSy2sIc6x1QgiBnvyKOSd0h6X01TnzNc7YB81+o4UIzFR1Ggv0sPPqEolrLNy8KzOXcFJeq0zIBPZc0QioqfiadMOAKZqfb6SQAQDDgvdlHZONAPiD0w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: David Howells writes: > Make cifs use generic_file_splice_read() rather than doing it for itself. > > As a consequence, filemap_splice_read() no longer needs to be exported. > > Signed-off-by: David Howells > Reviewed-by: Christoph Hellwig > cc: Jens Axboe > cc: Steve French > cc: Al Viro > cc: David Hildenbrand > cc: John Hubbard > cc: linux-mm@kvack.org > cc: linux-block@vger.kernel.org > cc: linux-cifs@vger.kernel.org > cc: linux-fsdevel@vger.kernel.org > --- > > Notes: > ver #18) > - Split out from change to generic_file_splice_read(). > > fs/cifs/cifsfs.c | 8 ++++---- > fs/cifs/cifsfs.h | 3 --- > fs/cifs/file.c | 16 ---------------- > mm/filemap.c | 1 - > 4 files changed, 4 insertions(+), 24 deletions(-) Reviewed-by: Paulo Alcantara (SUSE)