From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8330CA0ED3 for ; Mon, 2 Sep 2024 08:56:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5C0348D00A7; Mon, 2 Sep 2024 04:56:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 56E658D0065; Mon, 2 Sep 2024 04:56:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3C1088D00A7; Mon, 2 Sep 2024 04:56:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 1728A8D0065 for ; Mon, 2 Sep 2024 04:56:37 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 90954C1A8B for ; Mon, 2 Sep 2024 08:56:36 +0000 (UTC) X-FDA: 82519192392.25.26076CF Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf26.hostedemail.com (Postfix) with ESMTP id D56BF140012 for ; Mon, 2 Sep 2024 08:56:32 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ZAM78zw9; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725267299; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LfF3KeynC9sZLbgUnP2jKMumdR02uRRJTldDSGFHy9s=; b=WMcSmTlAo1KA8f/8Xry7PGe3+b5gWMEzFLJVwSIgJuYj87AT10LrakQFZRZw1EObb+IS12 A+QcZQLiMJeh28vpUr+BYZMnZqoMJ458N/Flg1LBMecex6Usga+ZwDLAQPkCX9/B/z4ml3 wqRD/2Br+xv1P2D3gDv2kpG4x+aZSYc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725267299; a=rsa-sha256; cv=none; b=NZpHlup6QODUaZEA686BlvOz6r3sRVenho8M8V+TyCtghUMtgFYVc4JKB8D4JoQnc5MIac dV2Ni/gZhnZ5wp5KMuM2s2dIxudxRiDtrZ1ING82GRUGj9ffv4kBerDs7uM/NciOoEiMhj gAndGmFUuNWjb5SaFngWeQYfafNyf/k= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ZAM78zw9; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1725267392; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=LfF3KeynC9sZLbgUnP2jKMumdR02uRRJTldDSGFHy9s=; b=ZAM78zw9ibAUeD77rEzKjOaUV/zitKqqmg5j8jqzCJgugCwZMLGuVfeb7Go3CXrYGUIG09 x5rB2TcsaK4lYNkMvafZ/igiIYv9ROzjmPeqsA75qXZxSdOWHm/dbUY2TlzAd+yoFRHDtT GTpZ8zgWB7LKK7D0v3kmgYjDTQmi4OM= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-385-7-N3fJiSOFqx-vv7qwkqPQ-1; Mon, 02 Sep 2024 04:56:30 -0400 X-MC-Unique: 7-N3fJiSOFqx-vv7qwkqPQ-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-374c3a31ebcso904475f8f.1 for ; Mon, 02 Sep 2024 01:56:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725267390; x=1725872190; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=LfF3KeynC9sZLbgUnP2jKMumdR02uRRJTldDSGFHy9s=; b=XeTjjN/TgW0OA/2Y2d36ZZTqiTfEMXoAV5VSuH/LKYduMQLBJlgLkIW5sCvgeId86R P66sAvFp8WjLIoQ8cCD28yzz1CFcNOgJWRqui7mnpmR/Q9icC5SCaoPiYDZf94XBpuwW 2CmIVbcggeTmevdjVlmoIpXy79/4e5MKSNggRTIzIIav3QmykxSYcL/8LR0AG07ewp9X ao9VruGtK3SmjPCYTAOre9m6BfLTf/VG35b8N5QsQ1t+3rw9wtcDN+6ezbrUHIYtZ7PK ww+tx5UF5zTtQ8yTbc9koKCf/kO8uS5qEH4d8JQZnc4VCb6nLF33Tln1MxW5MW8dJkjf cv/g== X-Gm-Message-State: AOJu0Yy59QuTu29bBdkOie+2TC6sNz1XZ93wY5n37SN5gyO3bbMXp+vq e1pDVYYxXM+lEi5hXnAu87e6XHwWqq60cL9MkVZHIR4eGXnelI1x3cJ/Rrpsuk9Vm6bdTskhUkb GPL6U0rcQhGNwHfxm3pp3P8pNUqp11u4SP2Jlrfiz3ntLkKwD X-Received: by 2002:adf:e452:0:b0:374:ba7b:42af with SMTP id ffacd0b85a97d-374ba7b434dmr4372630f8f.26.1725267389507; Mon, 02 Sep 2024 01:56:29 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE4sDToXZ9iQK2Utdqm24ufRZ+5W5OXr8AgS3H0PwzzxL8rRkjavgydF0LfAh+ynJv8zMPifw== X-Received: by 2002:adf:e452:0:b0:374:ba7b:42af with SMTP id ffacd0b85a97d-374ba7b434dmr4372598f8f.26.1725267388554; Mon, 02 Sep 2024 01:56:28 -0700 (PDT) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-374cd32fa01sm1307043f8f.85.2024.09.02.01.56.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Sep 2024 01:56:28 -0700 (PDT) Message-ID: <861d448c-ce1d-4b74-87eb-9b211dfebbb1@redhat.com> Date: Mon, 2 Sep 2024 10:56:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/2] mm: make copy_to_kernel_nofault() not fault on user addresses To: Omar Sandoval , Christophe Leroy Cc: linux-mm@kvack.org, Andrew Morton , Christoph Hellwig , x86@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-um@lists.infradead.org, kernel-team@fb.com References: <5fa50d78-6764-4f99-87b3-7bd7edbeea5a@csgroup.eu> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Stat-Signature: ou3935xt84sdrp4eez6gd33d6yxf3f6e X-Rspamd-Queue-Id: D56BF140012 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1725267392-4876 X-HE-Meta: U2FsdGVkX1/oc+8D8Msyd05W7vusZZ3gA0zzGnIvddOxkVdp3UZHuAcC8lH5cFJt2mUg4irM1HUyhAWoApz9+ZcAw5z1dB79c2YQT+vavAZjXWx4o5A4LOVNrA2odrv4w1ozyp950H5x55eaU1OiM/+4LI/QTS/M7Cv+JCxgmjm+fZzOGR4KKoQpaFZlBeY3ujAxE0HIklNahfneW2pfeRbarC80sOnWcc7b3qV7ULorWPbn7RcpCKD/BwfTRsQZfJOoCEB54/r91x68JYlGCVdXg+Ahd+85NHx5q1Zgx1oT6imVrNsbQOSrxdJWbL3fKea5dn2YhvMS5EoGzQ3JgxnkPLe4Xng4QLKpx/G5eDxn6HiVTgEIzhE2ejbc51bgZ3RNYjbt0ujqTUOeZFCooCzqU9SIGv53GDd7Grm1uOK4Ebf8OPbpStOrmD5DMQ0Wyu/v5+Ugzt466Dc+E0zIDtpaGZzZvA8GHW4VkSMu/W6BY+SqE0W3Kiuf1Ab3Lw0OisNEhB9hylDZhqqAKnNt6fim5MwbWLl+bxHOvFMCvw8LP7BhdUuwRt7DloY00BkVrKv8UCdPZzOEG/iYKIFJnCb+7diIVNsm6dF3eAWqSD3YZcKSe4tfXKTncg8moWcYp67BRyxdegGNoaicNOPxu2S3+V3T8L5Kn6YO0/6cGZi4JoHMS3oUcQW1cL+dGXUEJhZ4Mu6jnYymqV37c5X/4eD4C6lv9qzLZTo5UGjCyVMIHe7T/S6GZb/kYa69Oct2ZFcqctTWxtEbcIJCxSgOm3jAskC49YLYUQy7qLCwbiF0jUDYJoNuXCcJzUNg0rRilVTKYGkBCD2hA+ZDOtXOVjz8Tv9fs0jDY3IUni9kO7XwvuHlbmYCtmmB6Wfe24XLuYrju/wJs1EFoz4UrLgecH19kHm88ulz+tqxfrLe9+Te4GK07fUUzmmd95TYjparYi6MoyQVzayPwY34lFz sDbSghO3 nWNDwDCZY8rzCXimTWTpfPNH9vjduzllT/OEWG9da0q1AdahwvMzYAhhRYIqQ6H+eXri09xl5eoDk6/au9GdWMjtTRFdPTLjPQiN+Cbj1uP5nwFFQajmqkUirDIAubBFhTQxzjV0P6vc2QIgLHPHmeSaTVk0ltfqQy7idMVovOd1TbaJb5wPomgEc/0vdN3tk5GG/ojhRPu3t9E699ZT92/Q/0R1Rw7SFcRRBl/gfPnCR77UaFwncW34HB1K1udbMpM/3g5lGYWN6oZpRMYTB1f75oJX8hJvtKizUBJSAc/COE8EIkyT7E8dURvG7eSpv3jXYSWo3jByavMGK2p9gQ8UGFoWLy3YThBDuBCwUhslEVzpK7ipxgcxYMrLagjOZC8DcR5XdeWHQdg0ccF8OHfTVHlgJv2Xr7LEG7J9Go8tFgeTj+EsNWUF+UMun1r9Fgu5zSm7Dp0kl983Revuz7XC24A1U8I/bed+cHZRakMht3eAuaX7ztrcb1WD6LowNGJqjVKhbb8x8fqym9ZkW8yIl0c5WukK91I3OzfwQ9t20CQ/zK0NJF4Xyd0ekMeyjKhmeIcwXLbA/tt6Xm8lzCSADgjK02nAXA3WL7ZhUXuLZSxFTVijEiEku53O+oP4B49bj X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 02.09.24 08:31, Omar Sandoval wrote: > On Mon, Sep 02, 2024 at 08:19:33AM +0200, Christophe Leroy wrote: >> >> >> Le 02/09/2024 à 07:31, Omar Sandoval a écrit : >>> [Vous ne recevez pas souvent de courriers de osandov@osandov.com. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ] >>> >>> From: Omar Sandoval >>> >>> Hi, >>> >>> I hit a case where copy_to_kernel_nofault() will fault (lol): if the >>> destination address is in userspace and x86 Supervisor Mode Access >>> Prevention is enabled. Patch 2 has the details and the fix. Patch 1 >>> renames a helper function so that its use in patch 2 makes more sense. >>> If the rename is too intrusive, I can drop it. >> >> The name of the function is "copy_to_kernel". If the destination is a user >> address, it is not a copy to kernel but a copy to user and you already have >> the function copy_to_user() for that. copy_to_user() properly handles SMAP. > > I'm not trying to copy to user. I am (well, KDB is) trying to copy to an > arbitrary address, and I want it to return an error instead of crashing > if the address is not a valid kernel address. As far as I can tell, that > is the whole point of copy_to_kernel_nofault(). The thing is that you (well, KDB) triggers something that would be considered a real BUG when triggered from "ordinary" (non-debugging) code. But now I am confused: "if the destination address is in userspace" does not really make sense in the context of KDB, no? [15]kdb> mm 0 1234 [ 94.652476] BUG: kernel NULL pointer dereference, address: 0000000000000000 Why is address 0 in "user space"? "Which" user space? Isn't the problem here that KDB lets you blindly write to any non-existing memory address? Likely it should do some proper filtering like we do in fs/proc/kcore.c: Take a look at the KCORE_RAM case where we make sure the page exists, is online and may be accessed. Only then, we trigger a copy_from_kernel_nofault(). Note that the KCORE_USER is a corner case only for some special thingies on x86 (vsyscall), and can be ignored for our case here. -- Cheers, David / dhildenb