From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 670FCCD3420 for ; Sun, 1 Sep 2024 19:34:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D9D628D0053; Sun, 1 Sep 2024 15:34:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D4D368D0052; Sun, 1 Sep 2024 15:34:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B516E8D0053; Sun, 1 Sep 2024 15:34:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 96A608D0052 for ; Sun, 1 Sep 2024 15:34:49 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 2ADFB1A1650 for ; Sun, 1 Sep 2024 19:34:49 +0000 (UTC) X-FDA: 82517171898.06.6C8108B Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf14.hostedemail.com (Postfix) with ESMTP id BA63010000B for ; Sun, 1 Sep 2024 19:34:46 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=zI4puSLH; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Fyg5qDA7; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=zI4puSLH; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Fyg5qDA7; dmarc=none; spf=pass (imf14.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725219218; a=rsa-sha256; cv=none; b=kzw7af5p4/VEiEezzLp0wQDJDSSkSSyDympDOtFCcy7JVOIwc3FopuHRjUm63lWfXpdpbB tDw4OEpsK0IeGwY4BRvNgNyyuJsd4S+lktV38QLJRXi/j3f+YapWRvRu0BmrJoueTxPh3Z L+iCdwuNuv8rOAuMquS/HWj5v9GYTa4= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=zI4puSLH; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Fyg5qDA7; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=zI4puSLH; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Fyg5qDA7; dmarc=none; spf=pass (imf14.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725219218; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uVt9tFDX8tcgIBy4MepYpkLV3qFHyZuUB2GQ+7GiRWg=; b=Yi+2g6mv4ekfzr6c8Q8UefoOmUPZa/374Rk6+fGOvq6f/hBwdpYhUMqMOZzdWRdVVTGfts XSA/dJX+hiwK1+jEycdRUaOIXZbhm2dB7NnXKCUT2dQKHt2U9ZIduAOhm1qmvPjP8Gm6/H tOA6vIAy0XsNeYF4EygYb6PQXgLy3ew= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 3B4311FB66; Sun, 1 Sep 2024 19:34:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1725219285; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=uVt9tFDX8tcgIBy4MepYpkLV3qFHyZuUB2GQ+7GiRWg=; b=zI4puSLHr8pT+Z4p4UgDqiDEPBwvNgXCydVO7wvYs0QUDx/YwXerELaKkIHYPrLpFZeLhs La41IWAf1hg3P9G8SA0OeCekxWwkBPFk9y4LKF+KJsv4vMY5Vo7RlQjkUh1IjMWYksNb3O hx+OOw0dr8gaSG9SgEAqsf1a5gBlHoQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1725219285; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=uVt9tFDX8tcgIBy4MepYpkLV3qFHyZuUB2GQ+7GiRWg=; b=Fyg5qDA7BOi6FWAyHBfE/8bDSO5idwfi1+Eh1uUp6nkzsz/MHQE8SGFP558Pl8pXzWHerc JO81FZkXDqfKJCBw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1725219285; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=uVt9tFDX8tcgIBy4MepYpkLV3qFHyZuUB2GQ+7GiRWg=; b=zI4puSLHr8pT+Z4p4UgDqiDEPBwvNgXCydVO7wvYs0QUDx/YwXerELaKkIHYPrLpFZeLhs La41IWAf1hg3P9G8SA0OeCekxWwkBPFk9y4LKF+KJsv4vMY5Vo7RlQjkUh1IjMWYksNb3O hx+OOw0dr8gaSG9SgEAqsf1a5gBlHoQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1725219285; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=uVt9tFDX8tcgIBy4MepYpkLV3qFHyZuUB2GQ+7GiRWg=; b=Fyg5qDA7BOi6FWAyHBfE/8bDSO5idwfi1+Eh1uUp6nkzsz/MHQE8SGFP558Pl8pXzWHerc JO81FZkXDqfKJCBw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 140221373A; Sun, 1 Sep 2024 19:34:45 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id VN8+BNXB1GaIdAAAD6G6ig (envelope-from ); Sun, 01 Sep 2024 19:34:45 +0000 Message-ID: <860c4f66-0327-4fd0-bd49-5be742c6931d@suse.cz> Date: Sun, 1 Sep 2024 21:34:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] memcg: add charging of already allocated slab objects Content-Language: en-US To: Shakeel Butt Cc: Andrew Morton , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , David Rientjes , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Eric Dumazet , "David S . Miller" , Jakub Kicinski , Paolo Abeni , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Meta kernel team , cgroups@vger.kernel.org, netdev@vger.kernel.org References: <20240829175339.2424521-1-shakeel.butt@linux.dev> <76079f79-2e72-4a59-9eae-3b05ae6b9a9e@suse.cz> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: BA63010000B X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: ki8ymea3iyx79xonufzdc7r17wgfxrcf X-HE-Tag: 1725219286-49278 X-HE-Meta: U2FsdGVkX1+n1IOhx5Xo3S26tjEW0qA+SfIYBAjVQjZkKmubj6es2BPJzQ3kouSeQqAlVvqz9n/KLDXCIQGYTLsSQLEWfTqNWLdddQEp84bX1+hEyAkjvcFagtPbwIzkuj1jCJEeerz+9w+oGgdNJg5KmnSJKGSJIVzrxZOvppLONZkmlvTfUP5ACgu8GpHx4fsaWvXuoREdkHHXK1I+rbfQFZEksQlROVXj5gyoUwtyGtzwcjnQQoXwCAlKSrSgoNxiBx+LOQQkxKfQtwi3bvmiBW9eU0PP/Lav7Kljygi28jAm08yezJgv3el5UZ66GB63I8rogeW6LRugwZMcGi6ZDbGvIEwn5BQm+K+hcxUYLTnNXjw/OG2kq4ufFpi1R4zTyPkigvjp+1z9T+0gEd1RDdhr67781x4bidwMdj1UhUWVg86QMiJDeLswvCU3Hs1wTpAsvn3NDyjtOWqkh7MCUxIe+qD5n0QcQWIDzEwaxxRosIAJ++0hV/iYtjMTjvYUpo65I1fyfnYAr+UvtjjrP1FJeIQ6gEYDjDerfJj/H5lCZuk647wBBoW7ay4alCnSw/9UKRng0Ab1wIuqfHcsaPNgTR1vh34GOIQVanC+KEelO9zC6HDgITxr6HnMUGVgWiukZzMhtrhBc1rpHyV/zZ0MSrHNZ1vwOEleBQ4l0UW+F0BW24KY7L77FRXSXUSZEpYJY9fouOQAmn+CgY6OoRTm9m/Y9Oi722RFWI2Nln83t6eUcZMG93nSlPfR6lYXWPPnS3ZAo00TGP4/4dIG+SO8Rzcoa/FECQ8S0K0NTZAJ04wG0OaJTXi+JilDtQJkXJijqdntdMH3Y6/dxpE1Q4uNqPqt2fi060cgJ7ja8CSWPwN/1rv1POOBVhisEhgaZDN993iL77hV07J0yfHSNPP+Zu+5cWAHgNSBzPNZY4Cp0/ssrL7+AAMUJjt9yEv5E7m1K1LdSblPUtB ZYZHqe4a XI0+IcS7CBMKkCbKa0cLbLhNRFSSIxKsjtVUByCgA5eaV1SvbnEF0h5v3q8a+bXHcWP5MVMOXaZMhkS2tIfhU70Hrr6KMxiiyqxSRhIkFeN4jcJsU4A0bMvUZ6FhxsJz3O2qEfDsMRV2XrQn5zurEF4ST6WvbpfSPA56J/aFTjyXXo93LPGwgNVtKPy56DOsX5C2pXBHYN0b5yim45+74Eoko3USaMlopr1WSziTZ3t71D2j0jnnZ9nTkMSh2yIIuRiFFNLcUUdaUtSM8j0WgfHpKvg4Qhu7uwsRhpWT0SKicYBBUNCIC6qhdvycMvjURiOfGqTmQfSaejulZRvP40QlDaxybgAjaI9fUa3Cpx2FSMxg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 8/30/24 21:44, Shakeel Butt wrote: >> >> Also one thing: >> >> We should add some kernel doc for this, no? Explaining when people are >> supposed to use this, that objects from KMALLOC_NORMAL will be ignored, and >> what the return value means (including where it's faked to be true). >> > > Yes this makes sense. I will add this info similar to the kmalloc() > have. Should I send a v4 with this details? Yeah please, will replace v3 with that. Thanks