From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DE75C4167B for ; Fri, 16 Dec 2022 12:28:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 97D938E0003; Fri, 16 Dec 2022 07:28:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 92E028E0002; Fri, 16 Dec 2022 07:28:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7F5BE8E0003; Fri, 16 Dec 2022 07:28:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 6FD4E8E0002 for ; Fri, 16 Dec 2022 07:28:33 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 4363240381 for ; Fri, 16 Dec 2022 12:28:33 +0000 (UTC) X-FDA: 80248097706.09.7868915 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) by imf24.hostedemail.com (Postfix) with ESMTP id 8FD03180011 for ; Fri, 16 Dec 2022 12:28:31 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=gTmjQHIt; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf24.hostedemail.com: domain of bagasdotme@gmail.com designates 209.85.216.42 as permitted sender) smtp.mailfrom=bagasdotme@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671193711; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XN2BUIyyxfcPTn0lH7csIpbvsG2W/DIuROkPMqaCcZA=; b=w4EA9a4HiSnjxG1/bwI6Oijax6tH6AKZcxwGJNXMAC8X+EHJbDWMIiEyL1GeNv3+F3oI4a F/7Yc11G+3sLv9OxQy8GXqZEhadRyCDKZG5ropTepxb1Epz0bcsDXuHYqtpkJI/Klsxsrk 5MFnWrXFnQsvx5pXVq7T9KD9MG3w9Ls= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=gTmjQHIt; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf24.hostedemail.com: domain of bagasdotme@gmail.com designates 209.85.216.42 as permitted sender) smtp.mailfrom=bagasdotme@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671193711; a=rsa-sha256; cv=none; b=ZD35A3mazm+fF1ZFbSw1ZDXYEmuD1+oxsQ0Qft0vp+701jjrdYs6DBWCF98vemfdR6aGLr 6tb1iBzGli1LaYnfN/KlLExn3h0IYUbqiV9cAXypg/ra6bw9OvtRuJcEDstH6xvl/ZXjF2 2ApS939FvsdNZ83ozOipmylwtJI6cgI= Received: by mail-pj1-f42.google.com with SMTP id u15-20020a17090a3fcf00b002191825cf02so2225080pjm.2 for ; Fri, 16 Dec 2022 04:28:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=XN2BUIyyxfcPTn0lH7csIpbvsG2W/DIuROkPMqaCcZA=; b=gTmjQHIthgTaarmTiJIFcOmKO18lOJx70K41j/h8aKXjh6KsuWGEkZFj33q3evneNQ Z2aOHDpL36LFgscqFBHNKzMVJ9mYIx0ZAod72hmvUaLZsAbM7hZrGu12f8gqDapCACMi 41FVVH0qwRa4z0G6jmKXty6+LfGNMpKKDSTCYx8cJ/m33BMfthqrsxXH+AzoxBx8M9Yn C/3DIhGswmw+wRwrjR6uyzMYIeKhpQu3fKP+73cPXx9rO1TkIqOY+++ZfmE+EG9Mnlfb Id6KF6Rn3DAwHZhYd2fmrXGE5W6ntZV+znP4hk8sgPNWBl6FZtqOqmGU/m0AG/lTtkaW KYyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XN2BUIyyxfcPTn0lH7csIpbvsG2W/DIuROkPMqaCcZA=; b=Q9M8CsG3XjVK0z1EL6pQceo5nzRIL+ypa43HHeuPfUFVIAfmIVaEpT+emTYgMoyyv0 5+oI8kkx/QDhfjLtHSaPlAHRm2USaS35X3LX9VOyfD76Uy13xFf/OjAFSDv8WoOZPmXj BbfIXdbqhkgNZ4wtp7wMajY/wCmhUE3JNJfxyESWOPtXkPQeVntDGxwA3W1pdVEAZa1B yxdiDdl4udsBxca400BYahWQObjZWfdbp6058GYJzXu4lTVsU+MF0eNNqEIpij9c1GUC VU1B2D7Igu/J2rvPAaDRatrNVP0uO7YZjkFusYyTPYoNDiG4yBk7onXAAkc6OjMz9wTQ 4vmg== X-Gm-Message-State: ANoB5pmp16Rti/t8h8YdIivzfAR4u/1Yf4TsjeycCgpryWN1Z/nkjbY+ ye5LkNdovRx6MNtC7Y+pRMo= X-Google-Smtp-Source: AA0mqf6d7oqZU2G/xjT5P7wiQ6Ao9vsN4Z35ejH9yc72sa2sgRGO8RLbwwQKenbvXgNM8+nnx4ulRg== X-Received: by 2002:a17:902:e285:b0:189:fd83:eb80 with SMTP id o5-20020a170902e28500b00189fd83eb80mr30939639plc.62.1671193710453; Fri, 16 Dec 2022 04:28:30 -0800 (PST) Received: from [192.168.43.80] (subs32-116-206-28-27.three.co.id. [116.206.28.27]) by smtp.gmail.com with ESMTPSA id i6-20020a170902c94600b00189847cd4acsm1474100pla.237.2022.12.16.04.28.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 16 Dec 2022 04:28:30 -0800 (PST) Message-ID: <85f627d5-7572-1fc7-db1f-bc1337767a68@gmail.com> Date: Fri, 16 Dec 2022 19:28:13 +0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH] Revert "mm: add nodes= arg to memory.reclaim" Content-Language: en-US To: Michal Hocko , Mina Almasry , Andrew Morton Cc: Tejun Heo , Zefan Li , Johannes Weiner , Jonathan Corbet , Roman Gushchin , Shakeel Butt , Muchun Song , Huang Ying , Yang Shi , Yosry Ahmed , weixugc@google.com, fvdl@google.com, cgroups@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20221202223533.1785418-1-almasrymina@google.com> From: Bagas Sanjaya In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 8FD03180011 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: 86hq6fgeptukwocr33wihotr5w3hndn1 X-HE-Tag: 1671193711-265581 X-HE-Meta: U2FsdGVkX1+lgXyCyduer1jra9D8NIRfm19SWBKBR8qcZ611h+Yv/9u5DCT2xwbSoJpiN8ZjzKZtZiZOgVvW61BJTcrw42DDOc05MFMp1CJ839x4It/DCbDeEZJmX4duMUD87esUEQn2jhfV72+9CEC53VLw6uku5kC8LRTY1tXIO6DG+PPqVAOre+38aze8fet96aFEnNq/McZebfkjkdaybvZkpE3NMI7J7Xm6E6Y68U8wX4eM6SSXJrxXV1G5zlbH0XgncFa0bq1JBIej+eM9B3RIjL1IJx3GZc+CHSJUam02eY9+SCNnxAYFd6n9QGf8d8fUelBmIa9hYgJ7KdD60z7C1mhbs9PtVMOVDhXn1nQPpmnJwgUMXzcbk+vruQn2JStJU0eiKzwOlUo7ls+Bm+rTuqgpJIRrmz8RW+1WPi4CzLg0kDJcQlMKQbwLiIo/akGTor8V716nxpavKg0VDo2T53HwYEqgX1DHlnIkHfgg9YFtFhV32tXDxPr+nuSB+PnKdSVJj8wQ3VsISeqNqOgNGHSQibcBBS7U35W4b3ntl3DEERuJl1oD4wd3Wbmrg3JZB2jfTtuoOCd7nqiGn0UPXqzaNLG3u/e2cvg9xbSW+q4AA8frTnNWPAHYpXJEPfA6Y8V5c0AZM1XjHv6OQIy5w+nFA5T9ONEW97pWXrstbJ+XgMWqqKZpj3YCaRRfa+R76c/wg8H5exMgn75nVx/8UoQQC7GpRR90Bvtvf6NwQWxo9zlysBIHvBJq2mrBK0sL143htGLxwoA6r7sAlLafOSOlGjPI6+YFp6KUaIwUezAYHo2bfCETdjpc53mKm8S2aMb8P7LuzHCejC024r8DsKGN4RYiQtLuMJTZ1cIqRp4tmR+ckYorUyu/qqqw+Yo00MQd91sENdyRTCnG3UG1GzZj9zfboCYSh/6RsEdnyG7sr/pshjjOXZF/cFurvoLU7HKGMle+bvA 0lMAM6+h 0qM1ANEUeVSuo6Alzhk/kmCz/ebjVwraeW/WZbWkGSEL8UQnsHWrAgcL8atA7MsPkiacI+kYsCtoOAEovRz8h9bBEHt1v3BX55/qM X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 12/16/22 16:54, Michal Hocko wrote: > diff --git a/Documentation/admin-guide/cgroup-v2.rst b/Documentation/admin-guide/cgroup-v2.rst > index c8ae7c897f14..74cec76be9f2 100644 > --- a/Documentation/admin-guide/cgroup-v2.rst > +++ b/Documentation/admin-guide/cgroup-v2.rst > @@ -1245,13 +1245,17 @@ PAGE_SIZE multiple when read back. > This is a simple interface to trigger memory reclaim in the > target cgroup. > > - This file accepts a string which contains the number of bytes to > - reclaim. > + This file accepts a single key, the number of bytes to reclaim. > + No nested keys are currently supported. > > Example:: > > echo "1G" > memory.reclaim > > + The interface can be later extended with nested keys to > + configure the reclaim behavior. For example, specify the > + type of memory to reclaim from (anon, file, ..). > + > Please note that the kernel can over or under reclaim from > the target cgroup. If less bytes are reclaimed than the > specified amount, -EAGAIN is returned. > @@ -1263,13 +1267,6 @@ PAGE_SIZE multiple when read back. > This means that the networking layer will not adapt based on > reclaim induced by memory.reclaim. > > - This file also allows the user to specify the nodes to reclaim from, > - via the 'nodes=' key, for example:: > - > - echo "1G nodes=0,1" > memory.reclaim > - > - The above instructs the kernel to reclaim memory from nodes 0,1. > - > memory.peak > A read-only single value file which exists on non-root > cgroups. Ah! I forgot to add my Reviewed-by: tag when the original patch was submitted. However, I was Cc'ed the revert presumably due to Cc: tag in the original. In any case, for the documentation part: Acked-by: Bagas Sanjaya -- An old man doll... just what I always wanted! - Clara