From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A9E2D31769 for ; Tue, 5 Nov 2024 17:30:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EA7946B007B; Tue, 5 Nov 2024 12:30:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E56E86B0083; Tue, 5 Nov 2024 12:30:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CF7AB6B0085; Tue, 5 Nov 2024 12:30:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id AB7656B007B for ; Tue, 5 Nov 2024 12:30:28 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 538231C7555 for ; Tue, 5 Nov 2024 17:30:28 +0000 (UTC) X-FDA: 82752729570.12.8831F94 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf19.hostedemail.com (Postfix) with ESMTP id 36C021A0026 for ; Tue, 5 Nov 2024 17:29:44 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=R67Cl5UV; spf=pass (imf19.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730827660; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=afEv9GEFv9ZYOvN0eXrvv63Lz1O4DC9pouw/Ti/HkAE=; b=Kx5hrFxGyDTrCePTvy7NKDnutfwjPXWE5Gbbo15+jUumPt72O/Lfn2v+1ZZioeDOQmIkBa mhNkbBIlj0rUWOeWzfPSt2N3qRlkoTfqwnkdCaJEA85qB+LiTk68lGh7kceQJHx4wxgjk6 8W6Qep56YKGH99L/Ih4sIIlnJ9kvydg= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=R67Cl5UV; spf=pass (imf19.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730827660; a=rsa-sha256; cv=none; b=A2grpyyqlwQ9Ek6j9adJmhDRBGRI82fcI3YZN6CjFq11f/SBacljKxsGTnraCH2F5xrFy5 kmF91LPh789p+M6eCxcZL77RPHEMey9cz88/lEwdMeo3QOlMT+Fmw2QNBiTpFBnb4VNFaC pPIodYsYPrFgdc0tz9mKSkRbHQqoj9M= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1730827825; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=afEv9GEFv9ZYOvN0eXrvv63Lz1O4DC9pouw/Ti/HkAE=; b=R67Cl5UVdOQb9+qGjWb8P8Ulq6rsIr4zqm4jDIAh4R+fhtrmckDAr6saKn1DcXsjmLm4J4 82GSQyJOVWcULe165JFqD2cg7FzK7AkLPnlnrDE6igxQGV23XaZPTtYYsxxc53VvDN219u Tg6PAzpgGuuuOapK27Rz+y0SUhNnIIY= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-68-lPawB9RUMw2TQxKuCWPxRA-1; Tue, 05 Nov 2024 12:30:24 -0500 X-MC-Unique: lPawB9RUMw2TQxKuCWPxRA-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-43159c07193so48940105e9.0 for ; Tue, 05 Nov 2024 09:30:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730827823; x=1731432623; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=afEv9GEFv9ZYOvN0eXrvv63Lz1O4DC9pouw/Ti/HkAE=; b=t6aOBWjmhZwZoNdqyHJenf28W3lrQ24FVo7hfrY+LUKsZa6mJNFfp+6XDniU5sGCsQ BOv2shS26n3jRihBpEtG2bwdvmW/l1jeutCp6HqyuIhk3LQfuXoZWGidoDPhoWf1lzvF QvoNFIms6f7inBYqSEP7AQnQrwVwwg6tL+OwtWcBhFSC1yfM5Yo7P0R1wSd6c1hdpL7p D8EGlTcuVO7oK3x1h4FpA/YIi3AZlQ5pTUhRnFF6SIwPQfChCFZ8jPe6+L31ibkIJVKM O+G0aCiKfjAGbicftvHE95o1QOH1ZzqEynhIPN5mVD0gTGKyagQ8jVJ3TzVZR8RJfjnj bCzg== X-Forwarded-Encrypted: i=1; AJvYcCVk35LAb8yKTLVnGC0HkYqc6oLjHrZiD/9JYA8cTm5nfrFcpqM+i/JBkGh6gf6KMOgPzLExsmiEdA==@kvack.org X-Gm-Message-State: AOJu0YzrUOqIJorLPcKO+/5S6cGv/ociEZnbU1DsGAUeuvD/iusw+1T8 tS/4b3N/bsKyHcIyqXulaXMaeWFpxwvmAC+z7rrViChtVSTeMPMIzgeteD60rajqq3rJBARro9t NS9juRLmWn25sDTpMB75JhbwkbIT1WcphU+ESP4xOjWEm3Oqz X-Received: by 2002:a05:6000:2ce:b0:37d:52fc:edf9 with SMTP id ffacd0b85a97d-381c7a5cf91mr16782770f8f.20.1730827822891; Tue, 05 Nov 2024 09:30:22 -0800 (PST) X-Google-Smtp-Source: AGHT+IEfbmKWhZJf5mJv47Dm8DcJ0zBX0x3r/SrUb57O3943S/LTobo7w+YYS2O6RSnBG3ychpCp+g== X-Received: by 2002:a05:6000:2ce:b0:37d:52fc:edf9 with SMTP id ffacd0b85a97d-381c7a5cf91mr16782741f8f.20.1730827822458; Tue, 05 Nov 2024 09:30:22 -0800 (PST) Received: from ?IPV6:2003:cb:c73b:db00:b0d7:66ca:e3e9:6528? (p200300cbc73bdb00b0d766cae3e96528.dip0.t-ipconnect.de. [2003:cb:c73b:db00:b0d7:66ca:e3e9:6528]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-381c10b7a9esm16701247f8f.21.2024.11.05.09.30.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Nov 2024 09:30:22 -0800 (PST) Message-ID: <85f36754-a05d-40b7-b606-2515ac921c82@redhat.com> Date: Tue, 5 Nov 2024 18:30:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] mm: Opencode split_page_memcg() in __split_huge_page() To: "Matthew Wilcox (Oracle)" , Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt Cc: Muchun Song , cgroups@vger.kernel.org, linux-mm@kvack.org References: <20241104210602.374975-1-willy@infradead.org> <20241104210602.374975-2-willy@infradead.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20241104210602.374975-2-willy@infradead.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 36C021A0026 X-Stat-Signature: 9e51ttje1m1pg8omirhhknm57qsi81hx X-Rspam-User: X-HE-Tag: 1730827784-639187 X-HE-Meta: U2FsdGVkX183M60W3jdWSv1xZCqHqZn/WMxOuIhUdjesUSPrEwejx+TCYE6hJhcIeiTLlsKkWZrgIFt+pFSK6dsMQLXwy8cSmtLmoyCvuub/03/Mqoze0A8YYHsVhSBrR36GQzOMrhKjji3Sh45gy4RxfCPqSCrNbictIARhuQx/udaCu1py0z0SsKWd9MhWw2v0NXXgP35uDnUr+TQEJGgW9WqT8H/6CMpsx/1+shnonC/cLOYnx9Rq/tL7H6hnBnc78u1YvN0jW0o0YrIG36VawOr7A3kKZcAQLY4/PY3HV+1qxF6kwIi3XKQvqtECecVYZswl0srrlEh67EZ5sdNIa1qYl12U5mK4Vz97nc6dOy7VxwG4Hq0FJAgckkOL0j3xcaMcqCrgAh34pvOHATTQpq0imrycFn9rUSTM53oKqZmcVUpA/FGfeB/rllfLKW6zS6GG2o4WIV52mSVljVnWDuuQcAu5CeGtMcXjFJRF7SGYEwp3EXNVZ5ybFWYPLm3pdvtRLIsqsb6vkGjJeIzyCGS4KeVV72GTzhLA7GABNrosmS4nX1DsJns54iwUi35ymkrwadoSxUkuHki6dI6clJvP5Vgs+DL0xcinkxHq82WAE3SsD6PVD8T1DWEdWjlQQp3OgZKjNHgjnlcpBp5lgPDAfPIVddaXDZntqau94k3/qsezGFzQLFsuia1mupLYSsPF7ubMe9gKN9E6tFPQ7yclALXbMPFbsHMsDkbw0DK2VdoqT1rZ5Qx1wPUQ2LGrh0LNiMQa0xwa68bIj+TNqr9G4Q3nVpIAn60vbABwUgRf9Cag90IE8ziP0KqgwEQg4QA6vASdbgqA+GSrBt1bBBbgQp05ea0cnvjVRN9+GE+59+6ctB6BqgAgL2IQH852L9TDBN5eYjaxVy1W2picHQyy1EfphF4yHXVvMv5jyjqnRYIrkcyjoHWhDOHBEbuHpbcVRyskmPFfEiY QfknGG7V L9PFEVRpRdGYiCWbL5VN+E6GQbR2dXqxnjEEeg1cuxHN90kFw+PXcnjvay7wvxZtymdc0wrJpMPzLeMhY//AFqxrTeqagD6/D3zetTYNEVIqJDOR79j8BlO+Mgyvqg79ic+6YKRc6W55DvnXSEqaL+R5giFuqVqVqLqDDYd7EMGTak6b/onYVcOanH3J9S3VGZqn6UP/XR4Gidnm0cypfu9DmyMBuVKIPFHuOgtPwCXeaJTTiKZl/tL9CykdUuPXNqJb2BdYzEhJ27bbhvqtatuMzpg5xQ3yQ4ynDYnmZdf5hH1XLopxWn0TIkmRdLVbGvX/7kObsmD6EzdqlL6IDOH+PICMqi3JAwaPRXJxQQXvNjiGvJAc2OVqXS/LLV2HzdtsKy3HUyt3j8eKjG/Bm0OmWNLKlu+MZoZ4M4meoS82/7C+Ooh1fx1GG2aei7T/1/0bHqTwhw7RCKS8apz+bie6fRnhGJ3wOhzwaMFmctUDQvWByRqllMRbnPA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 04.11.24 22:05, Matthew Wilcox (Oracle) wrote: > This is in preparation for only handling kmem pages in > __split_huge_page(). Did you mean "in split_page_memcg()"? > > Signed-off-by: Matthew Wilcox (Oracle) > --- > mm/huge_memory.c | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index f92068864469..44d25a74b611 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -3234,6 +3234,10 @@ static void __split_huge_page_tail(struct folio *folio, int tail, > folio_set_large_rmappable(new_folio); > } > > +#ifdef CONFIG_MEMCG > + new_folio->memcg_data = folio->memcg_data; > +#endif> + > /* Finally unfreeze refcount. Additional reference from page cache. */ > page_ref_unfreeze(page_tail, > 1 + ((!folio_test_anon(folio) || folio_test_swapcache(folio)) ? > @@ -3267,8 +3271,11 @@ static void __split_huge_page(struct page *page, struct list_head *list, > int order = folio_order(folio); > unsigned int nr = 1 << order; > > - /* complete memcg works before add pages to LRU */ > - split_page_memcg(head, order, new_order); > +#ifdef CONFIG_MEMCG > + if (folio_memcg_charged(folio)) Do we have the mem_cgroup_disabled() call here? Apart from that LGTM. -- Cheers, David / dhildenb