From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29FBCC433EF for ; Wed, 13 Apr 2022 16:37:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7B82E6B0074; Wed, 13 Apr 2022 12:37:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 766726B0075; Wed, 13 Apr 2022 12:37:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 62F2E6B0078; Wed, 13 Apr 2022 12:37:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.26]) by kanga.kvack.org (Postfix) with ESMTP id 54E116B0074 for ; Wed, 13 Apr 2022 12:37:31 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 1EECB256CF for ; Wed, 13 Apr 2022 16:37:31 +0000 (UTC) X-FDA: 79352411502.06.72E6E1C Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by imf17.hostedemail.com (Postfix) with ESMTP id 2962540004 for ; Wed, 13 Apr 2022 16:37:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1649867850; x=1681403850; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=AYwbAQA51GI7OS3SDP9g0rw3x5qDpayrqhQKsx+i7bU=; b=mYhpEbixW1tohK23W5HDblExEdAHmC9Z5EZy85L4mDdQvWtVo68GFiaO 3jMmY2E7XS14eUVR5/0/Vz47XydyK5uReVx4A2HJoNMFbGFw0J9J+r7rO Qr+KT7GOTdSWatyrW+mDJR5r05jwVr/SuVBEdjBuebLsKFcOZQbQklcBU HT3SGk0WyTEFy2XIVO8ERBayfk8gASU9Ul2RoC7hTqcwYYoYsPgkFPskB O8H+B7sgBTH0/KiscbZwFmuUCILe8nntAxIAC7XdyG+F3x7glwG+n+XIe 2UbiJtSC4KHr5uM7DZtQl/bV6mgbIRj/6MWQe/LA1PSM7TS/LxtK398Ra A==; X-IronPort-AV: E=McAfee;i="6400,9594,10316"; a="287747028" X-IronPort-AV: E=Sophos;i="5.90,257,1643702400"; d="scan'208";a="287747028" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Apr 2022 09:37:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,257,1643702400"; d="scan'208";a="854854774" Received: from linux.intel.com ([10.54.29.200]) by fmsmga005.fm.intel.com with ESMTP; 13 Apr 2022 09:37:28 -0700 Received: from [10.212.225.84] (kliang2-MOBL.ccr.corp.intel.com [10.212.225.84]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by linux.intel.com (Postfix) with ESMTPS id 1DA765805BD; Wed, 13 Apr 2022 09:37:26 -0700 (PDT) Message-ID: <85eed89f-e4a8-2887-a0b3-579704304357@linux.intel.com> Date: Wed, 13 Apr 2022 12:37:24 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [LKP] Re: [perf vendor events] 3f5f0df7bf: perf-sanity-tests.perf_all_metrics_test.fail Content-Language: en-US To: Ian Rogers , Carel Si Cc: acme@redhat.com, alexander.shishkin@linux.intel.com, alexandre.torgue@foss.st.com, ak@linux.intel.com, mingo@redhat.com, james.clark@arm.com, jolsa@kernel.org, john.garry@huawei.com, mark.rutland@arm.com, mcoquelin.stm32@gmail.com, namhyung@kernel.org, peterz@infradead.org, eranian@google.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, lkp@lists.01.org, lkp@intel.com References: <20220304083329.GC20556@xsang-OptiPlex-9020> <20220413070529.GA1320@linux.intel.com> From: "Liang, Kan" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: prbj5f1ortn87e763z4t1rhs459nqq1k Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=mYhpEbix; spf=none (imf17.hostedemail.com: domain of kan.liang@linux.intel.com has no SPF policy when checking 192.55.52.88) smtp.mailfrom=kan.liang@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com X-Rspam-User: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 2962540004 X-HE-Tag: 1649867849-825210 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 4/13/2022 12:03 PM, Ian Rogers wrote: > 3) Weak group doesn't fall back to no group: That's because the group validation code doesn't take pinned events, such as the NMI watchdog, into account. I proposed a kernel patch to fix it, but it's rejected. It should be hard to find a generic way to fix it from the kernel side. https://lore.kernel.org/lkml/1565977750-76693-1-git-send-email-kan.liang@linux.intel.com/ Maybe we can workaround it from the perf tool side? For example, for each weak group with cycles event and NMI watchdog is enabled, add an extra cycles event when opening the group. If the open fails with the extra cycles event, fall back to no group. After the extra cycles event check, remove the extra cycles. What do you think? Thanks, Kan > $ perf stat -e '{BR_INST_RETIRED.NEAR_CALL,BR_INST_RETIRED.NEAR_TAKEN,BR_INST_RETIRED.NOT_TAKEN,BR_INST_RETIRED.CONDITIONAL,CPU_CLK_UNHALTED.THREAD}:W' > -a sleep 1 > > Performance counter stats for 'system wide': > > BR_INST_RETIRED.NEAR_CALL > (0.00%) > BR_INST_RETIRED.NEAR_TAKEN > (0.00%) > BR_INST_RETIRED.NOT_TAKEN > (0.00%) > BR_INST_RETIRED.CONDITIONAL > (0.00%) > CPU_CLK_UNHALTED.THREAD > (0.00%) > > 1.001690318 seconds time elapsed > > Some events weren't counted. Try disabling the NMI watchdog: > echo 0 > /proc/sys/kernel/nmi_watchdog > perf stat ... > echo 1 > /proc/sys/kernel/nmi_watchdog