From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C23EFE77197 for ; Tue, 7 Jan 2025 08:49:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5D4FD6B0089; Tue, 7 Jan 2025 03:49:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 581006B0098; Tue, 7 Jan 2025 03:49:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3AD216B009A; Tue, 7 Jan 2025 03:49:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 1AD5F6B0089 for ; Tue, 7 Jan 2025 03:49:28 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 8BC901407D4 for ; Tue, 7 Jan 2025 08:49:27 +0000 (UTC) X-FDA: 82980031974.10.037057B Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf15.hostedemail.com (Postfix) with ESMTP id 0B37EA0005 for ; Tue, 7 Jan 2025 08:49:24 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Qq9Bfhws; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736239765; a=rsa-sha256; cv=none; b=fidOvo6XMH99CSHgu+//4h+NbgDN4jeDC/DtazmO+QxEZGOgIgSD/pZM6upIaAmQnLht9a lRh0Yi6VXL4Kp0eRBmn4MRtvRQzeHr6jkDjfk96kV/a68c3vFqy4qwHY+N4mJXLPjvzKzy ufmfyds3HVHmX/5Npi6c1O3pHQXbmbA= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Qq9Bfhws; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736239765; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LGg2HgBxxkq+HSeUhG7rZz+ADaUvalQmRHFX1L6pNmk=; b=t2xbnD6NbD8NqbogsLd5r23eQnr92Zdstmm5y0K+0h0zPBih3lW2xOScEcvXt5H2sPQgfH sTJ7o8WU9hIakDjWl9A7kqc8SiqVwG8eER/pM05cng4zdL0jN3Kv2LWoDzZouDciJdo9lE R4P7mYmFlNBcrypBRFL2mDHgEE2X+D8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1736239764; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=LGg2HgBxxkq+HSeUhG7rZz+ADaUvalQmRHFX1L6pNmk=; b=Qq9Bfhws3MIhWtuHJPMW9EwlcNSAzhGJfnzl0PiA0RvC6LR5SVXaoVF+C6C54eys/yrgnO /X1F645O4/4mI94Sfb8xh4DpI9zFFVuPdjuSTi37ogogTtv6RadYkl8zsGCMcrKQRMFn7F 9wlzdvc2vFWaxN0BE4lUFQ8LNTsYLJE= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-645-yvUIJ_AWPP-FOKJKMTWT5A-1; Tue, 07 Jan 2025 03:49:23 -0500 X-MC-Unique: yvUIJ_AWPP-FOKJKMTWT5A-1 X-Mimecast-MFC-AGG-ID: yvUIJ_AWPP-FOKJKMTWT5A Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-436723bf7ffso98774925e9.3 for ; Tue, 07 Jan 2025 00:49:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736239762; x=1736844562; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=LGg2HgBxxkq+HSeUhG7rZz+ADaUvalQmRHFX1L6pNmk=; b=ChtszkrJKSndQpVK6XIQ+lRQ1zaIEqYj8qAZeMiFKKakH9zJSG1F9se36tOqHzfkfj AGDhXBSq5i7LfXLkjLMexAGNVmoM1NJZm/DBqV52tB6/JZHw4+W4UuwqYfUk/k49Gh4h NQYqbleIAD9MtftEfdsfgj5XsJ4lF5GyGWMj7Sr8avjBah7D0qZs3PpbGwiUY+5gsBga OseWw1S1hlN6QE+vrvEjfoNI+y4m9dMT2MZO9FTJstd/UiswUMWljEI3XH1JnNSPaRmD dt80SUZ2/xpaoSUbV/2t0Pk43lQTvcUhyfld2vtzKItb15H94xOce3+DGI/6vg00WCQt UfAQ== X-Forwarded-Encrypted: i=1; AJvYcCXHpSv17RJIpbcVZiaEgzV9/kFM2DDbO4AAb7JoSokFfuQUqnMgqjG/NvoyX0v86dsgBTbBqFMk+g==@kvack.org X-Gm-Message-State: AOJu0YzMz6lHczE0Bf95doXWYfkQqtj37vR+fJDgRVcolhsufh38YV/p pwvKBvAi3KdnOGJ37oy5tV1CpoBe6o9MuJqAHcWwvzeRXGykGSgjESab+kjnIqGXIbiaxGw7WiG hm46S+cPLxezm+r+4Z8utw8jaDyxfH80gb0i/fIN3163mWoY1 X-Gm-Gg: ASbGncvbmt0zae2kZFWdhsd6CP9rlBgzoLQF4YIQlDMMi+FHHJYxauGlldKz+rS55zW Bbp4qYfeBOnyDPGoBay/v8IyGfu2HxvTBncaShu0b4tAK8Ug8KGjWOWMrxgZjhn18kw47PMVBIb PXYGNj1tY2tqRnVplB3fqxu+cMQ6gSqlAlpFY7wjipFxmj6NIiAbbuo4H5V7uy6Ln7aj4Fidwhy dgWvVPHCKybE/5M/gNGoF2nTdDVPfZPecNyKUZvokcGdsY47DDDgxDeFaorQy7gfXQHw5efxscR bnm2vQBqc+IQPJegS8Nmr0uk8Alg49JXM4nZP+CwpauNZROQWt/zxKY0uhKQsb4dyhg9XjHuzrR ZZPNLHFAp X-Received: by 2002:a05:600c:4f95:b0:428:d31:ef25 with SMTP id 5b1f17b1804b1-4366854c111mr556191115e9.12.1736239761752; Tue, 07 Jan 2025 00:49:21 -0800 (PST) X-Google-Smtp-Source: AGHT+IHXa3p6QI+qrOF8gbYMvgK+KHEfmIBfNhBlVgfOqfPyvZZZju3UsMifa+Sa1vivxlaIqmkBrQ== X-Received: by 2002:a05:600c:4f95:b0:428:d31:ef25 with SMTP id 5b1f17b1804b1-4366854c111mr556190875e9.12.1736239761405; Tue, 07 Jan 2025 00:49:21 -0800 (PST) Received: from ?IPV6:2003:cb:c719:1700:56dc:6a88:b509:d3f3? (p200300cbc719170056dc6a88b509d3f3.dip0.t-ipconnect.de. [2003:cb:c719:1700:56dc:6a88:b509:d3f3]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a1c832e69sm49347658f8f.35.2025.01.07.00.49.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Jan 2025 00:49:20 -0800 (PST) Message-ID: <85ea0bc9-0892-489d-b42b-430ff8a1f368@redhat.com> Date: Tue, 7 Jan 2025 09:49:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH mm-unstable v1] mm/hugetlb_vmemmap: fix memory loads ordering To: Yu Zhao , Andrew Morton Cc: Mateusz Guzik , "Matthew Wilcox (Oracle)" , Muchun Song , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Will Deacon References: <20250107043505.351925-1-yuzhao@google.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250107043505.351925-1-yuzhao@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 2NXFobBervRi6lK0v5NmnrvxHdEiOZlsuU05HWRKAqo_1736239762 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 0B37EA0005 X-Stat-Signature: 1bu1ibzwta7aq3abyynccb5efmgftk48 X-Rspam-User: X-HE-Tag: 1736239764-340948 X-HE-Meta: U2FsdGVkX1/csrUfrtMKkBqje78KAlHv5tcVm4PhKU3Ryw+2GYileuvU+cdJdp18gdqajcCn2v4BGXKgJwBKBEYdPPnGGZ/czNt2PWUR1HkXTQTXSUx/9Igcyt/uG6J17WQ1ip7XA+l4WJkSdpX9Coe2IfwfkjIdKWpfJrXsd84KOz89JfCH9BX39xGyUCnlAQTSIgHmov1RyyH38AHRuiUW0YGzilZF6rr1XQmTH/60v08ZtSfm388efht10tX2+fkDROV8RWz/rViJAs43WLrgMY3p9qZ7cVREPISeERUmrcpdU6gRRrXLr+JyUP0mnHagedPhWeg3Q46PoVbvIHOowdEZCgOJ/hT4Lt3h/ml78z/X7fmMh/Dq5Sx4dC4t81nbI6++NtczfQP44SteqqDJVU2J9kNjgVQB/AOnYHZbwuqCUG5kX0PU7XYlmCEKhB69gJsfNdF3S9+3UpgE+ARnAMUAI0fIcpfnGCQoZYLizjRy0B3/GE9YMkoFS+Gue5yhAojsg+YQ722wsHre+L4wk9LTAYVuptoaPVbwVBw7ACA1Q11I7SR2J1l4nHzozJxTeY/rQXysgzr391sYJd7x2u6u8Wn4TwDsFaVcKCC8CUcZAJ7AozHkhIUE5svwpJFswiI4OcqpbTX3h1DQZq7+bcWrqEp9rdGjDBYzzqNQ1ahsacsAZpss7qMiG8yUM/0JSV4Al9RSYWxMR2Koa7zWrxjvo27rorwg0doY4qWXOJ32F/vth72bbZJ0mZsHLKivCg0HLBGmK/3OsroAwuvICMfXAQsMhjiYu+st30U8K/ize/ixSAzT31aQZHUY6bwqQrbdAcMyV4mUNK6sx//NhFKfWc/L7pOI+5FNZSX0SQNldK8/bpM+MdGJFWQTaIArEtV2i+PdI2lB40YFvPNo72IpB++UcFqknz1L91hy1n7sDb3oTaQltONKK/2lVYSozLLFj9wy98ZmBrz i6V32w6U psFTNG8R/o9rZTYHw4y0IF0Zqfd38P4csJbTt3NpVhigGV8oKvEQn/j36+K2J75XpATTnAtu0tuD08B1Jp4kZguAL1J7J5uJMP/XvU+38tzjTvJ5zMof/HeyAgo9zRTiqKij60OfG9m+Qz4pIbdJTq2+Z1vVBoM5DiVfNVWCPBw7Pv6E0TZHdokD1/iZdzxSjMOllCe52tkmqd74THm9MJIWtOJ4TdwzEy4Z6dbNXZ1hrDT4xlpNvgkz5/q3pgPmZVU9o3GSMxsTXGfHbj2NfcgF7VAZArOgbihtObL0oUKi0gnz5CCsDg2WeTQCRb4kbVR6Qarnd3+52sM4cy5GkJPWZzrUafFhfLzI9orxhYn7U3oHiqIzY4HHXMbuLqpwxpLVeuE9ixrkBVY7YxR57EynZp7ejKb0QlQWrt+2+X+AZ2ZpYhFypaK0FTVXyrPgBFhBwCsFCYpm33JDufBlSJw1PrVdgArDGCbdHJHCD5FTxhEA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 07.01.25 05:35, Yu Zhao wrote: > Using x86_64 as an example, for a 32KB struct page[] area describing a > 2MB hugeTLB, HVO reduces the area to 4KB by the following steps: > 1. Split the (r/w vmemmap) PMD mapping the area into 512 (r/w) PTEs; > 2. For the 8 PTEs mapping the area, remap PTE 1-7 to the page mapped > by PTE 0, and at the same time change the permission from r/w to > r/o; > 3. Free the pages PTE 1-7 used to map, hence the reduction from 32KB > to 4KB. > > However, the following race can happen due to improperly memory loads > ordering: > CPU 1 (HVO) CPU 2 (speculative PFN walker) > > page_ref_freeze() > synchronize_rcu() > rcu_read_lock() > page_is_fake_head() is false > vmemmap_remap_pte() > XXX: struct page[] becomes r/o > > page_ref_unfreeze() > page_ref_count() is not zero > > atomic_add_unless(&page->_refcount) > XXX: try to modify r/o struct page[] > > Specifically, page_is_fake_head() must be ordered after > page_ref_count() on CPU 2 so that it can only return true for this > case, to avoid the later attempt to modify r/o struct page[]. I *think* this is correct. > > This patch adds the missing memory barrier and makes the tests on > page_is_fake_head() and page_ref_count() done in the proper order. > > Fixes: bd225530a4c7 ("mm/hugetlb_vmemmap: fix race with speculative PFN walkers") > Reported-by: Will Deacon > Closes: https://lore.kernel.org/20241128142028.GA3506@willie-the-truck/ > Signed-off-by: Yu Zhao > --- > include/linux/page-flags.h | 2 +- > include/linux/page_ref.h | 8 ++++++-- > 2 files changed, 7 insertions(+), 3 deletions(-) > > diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h > index 691506bdf2c5..6b8ecf86f1b6 100644 > --- a/include/linux/page-flags.h > +++ b/include/linux/page-flags.h > @@ -212,7 +212,7 @@ static __always_inline const struct page *page_fixed_fake_head(const struct page > * cold cacheline in some cases. > */ > if (IS_ALIGNED((unsigned long)page, PAGE_SIZE) && > - test_bit(PG_head, &page->flags)) { > + test_bit_acquire(PG_head, &page->flags)) { This change will affect all page_fixed_fake_head() users, like ordinary PageTail even on !hugetlb. I assume you want an explicit memory barrier in the single problematic caller instead. -- Cheers, David / dhildenb