From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 996C2C433F5 for ; Sun, 3 Oct 2021 05:47:53 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1A10A61B29 for ; Sun, 3 Oct 2021 05:47:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1A10A61B29 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 731586B006C; Sun, 3 Oct 2021 01:47:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6E1CB900002; Sun, 3 Oct 2021 01:47:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5A99D6B0072; Sun, 3 Oct 2021 01:47:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0064.hostedemail.com [216.40.44.64]) by kanga.kvack.org (Postfix) with ESMTP id 4AF6B6B006C for ; Sun, 3 Oct 2021 01:47:52 -0400 (EDT) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id DEBFC8249980 for ; Sun, 3 Oct 2021 05:47:51 +0000 (UTC) X-FDA: 78654044742.10.C3AACF1 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) by imf15.hostedemail.com (Postfix) with ESMTP id 97632D000CF1 for ; Sun, 3 Oct 2021 05:47:51 +0000 (UTC) Received: by mail-pj1-f50.google.com with SMTP id pg10so8817306pjb.5 for ; Sat, 02 Oct 2021 22:47:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:cc:references:subject:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=savTH8tOINZ2J99oLslSAWNZa5Ho6D9RgvdIZJ7bFnA=; b=Y7uNNINBrkq5cxVztJ3SYWUhJ4cqOz8cuJbfN83wQn95FC/D2R99w+R2PGb9+omyw9 oUMBBOL7Q2qXknqyn+ueCjhRRkGnQvpvwzbs+lH1kJcT7mhA/Sv5L5QSKRg4csmSP3i7 KQf0X+t+NalR3wLVAXSHYb4TC8CIkajx690fgi5nQq7/ONabkjke8DE4NrtX3mbsKCov 6GKUAjmQjbUU46Au+jp8B3bHxUi4dgI9/hNH0sygbvUe0nxcWAjC9QFLyx8xMU0L23zo 3MbZYv6rWeB3f/d/ixsniSvPVzZlDq3h4NGCPXkQIMFaUYbnnngJuLp7T857lqiStDFe WmlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:to:cc:references:subject:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=savTH8tOINZ2J99oLslSAWNZa5Ho6D9RgvdIZJ7bFnA=; b=XRxV5xk7lmqyIc8pyUMYyx1vX502PhQkTgMlgoKQDNbK+pBGFcGFCIUb8uqvL2+DCY ViQ7IMrTj9uLP4rvve72/ytrMr5GJvlETgGbphRPlA8M2X/IwnEciuloX8CUluhmxN4z 1NXSXKseFie6eZOIAQ7QuPiac9vWXa3RoElHgOdGRMu8gc3srTxst7Q1Hvxh18aqjMrn xkMiuEmtUt7ZZk4v/3kEOQsLuEn/4dtzjJW1Ggz2OpHTkR2N1ra0vQ9ThyEE1Db59fl5 RBhAEk1JG6pGUJ2vhiiCwjHRJLwQ5xN1jsbRc5iYvwrOL27YVTXSMi45ZjQ0HFSeCCqA 2bzw== X-Gm-Message-State: AOAM530pprw4TrqUzcx6jlsQMR0cUOAbXuachNrBcdU+xn2YH3pCipJF kWn34X6gIKosxiypF2U1GlA= X-Google-Smtp-Source: ABdhPJy5HRxA5o6Rs+cSxf9+J2Z0L3aQbAXv7HdqnVMMAbnAdw/SICL9EIXJilE004Mcf5mNUIhaVQ== X-Received: by 2002:a17:902:d2c6:b0:13e:9bc9:1ae3 with SMTP id n6-20020a170902d2c600b0013e9bc91ae3mr5601433plc.87.1633240070503; Sat, 02 Oct 2021 22:47:50 -0700 (PDT) Received: from [10.12.152.158] ([154.21.212.155]) by smtp.gmail.com with ESMTPSA id y7sm10286631pfr.33.2021.10.02.22.47.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 02 Oct 2021 22:47:50 -0700 (PDT) To: seanjc@google.com Cc: djwong@kernel.org, kvm@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, stephenackerman16@gmail.com References: Subject: Re: kvm crash in 5.14.1? From: Stephen Message-ID: <85e40141-3c17-1dff-1ed0-b016c5d778b6@gmail.com> Date: Sat, 2 Oct 2021 22:47:48 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 97632D000CF1 X-Stat-Signature: cdi99a1wfauety1z896tniqmqoebuciu Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Y7uNNINB; spf=pass (imf15.hostedemail.com: domain of stephenackerman16@gmail.com designates 209.85.216.50 as permitted sender) smtp.mailfrom=stephenackerman16@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-HE-Tag: 1633240071-548125 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > I think this should fix the problems? > > diff --git a/include/linux/secretmem.h b/include/linux/secretmem.h > index 21c3771e6a56..988528b5da43 100644 > --- a/include/linux/secretmem.h > +++ b/include/linux/secretmem.h > @@ -23,7 +23,7 @@ static inline bool page_is_secretmem(struct page *pag= e) >=C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 mapping =3D (struct address_= space *) >=C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 ((unsigned long)page->mapping & ~PAGE_MAPPING_FLAGS); > > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (mapping !=3D page->mapping) > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (!mapping || mapping !=3D page= ->mapping) >=C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 return false; > >=C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return mapping->a_ops =3D=3D= &secretmem_aops; I have validated that my system was stable after several days on v5.13.19. I'm now booted into a v5.14.8 kernel with this patch, and I'll try to report back if I see a crash; or in roughly a week if the system seems to have stabilized. Thanks, =C2=A0=C2=A0=C2=A0 Stephen