From: David Laight <David.Laight@ACULAB.COM>
To: 'Joe Perches' <joe@perches.com>,
Nathan Chancellor <natechancellor@gmail.com>,
Nick Desaulniers <ndesaulniers@google.com>
Cc: Nathan Huckleberry <nhuck@google.com>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Michal Marek <michal.lkml@markovi.net>,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Linux Memory Management List <linux-mm@kvack.org>,
clang-built-linux <clang-built-linux@googlegroups.com>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>
Subject: RE: [PATCH v2] kbuild: Change fallthrough comments to attributes
Date: Tue, 13 Aug 2019 09:48:01 +0000 [thread overview]
Message-ID: <85e25647ae404bf38bc008ea914e08b3@AcuMS.aculab.com> (raw)
In-Reply-To: <3078e553a777976655f72718d088791363544caa.camel@perches.com>
From: Joe Perches
> Sent: 13 August 2019 08:05
...
> The afs ones seem to be because the last comment in the block
> is not the fallthrough, but a description of the next case;
>
> e.g.: from fs/afs/fsclient.c:
>
> /* extract the volume name */
> case 3:
> _debug("extract volname");
I'd change those to:
case 3: /* extract the volume name */
Then the /* fall through */ would be fine.
The /* FALLTHROUGH */ comment has been valid C syntax (for lint)
for over 40 years.
IMHO since C compilers are now doing all the checks that lint used
to do, it should be using the same syntax.
Both the [[]] and attribute forms look horrid.
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
next prev parent reply other threads:[~2019-08-13 9:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-12 21:47 [PATCH] " Nathan Huckleberry
2019-08-12 22:14 ` [PATCH v2] " Nathan Huckleberry
2019-08-12 22:40 ` Joe Perches
2019-08-12 23:11 ` Nick Desaulniers
2019-08-12 23:23 ` Joe Perches
2019-08-13 6:33 ` Nathan Chancellor
2019-08-13 7:04 ` Joe Perches
2019-08-13 7:43 ` Joe Perches
2019-08-13 9:48 ` David Laight [this message]
2019-08-12 23:06 ` [PATCH] " Nick Desaulniers
2019-08-13 7:15 ` Christoph Hellwig
2019-08-15 21:07 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85e25647ae404bf38bc008ea914e08b3@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=clang-built-linux@googlegroups.com \
--cc=gustavo@embeddedor.com \
--cc=joe@perches.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=michal.lkml@markovi.net \
--cc=natechancellor@gmail.com \
--cc=ndesaulniers@google.com \
--cc=nhuck@google.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox