From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1F2DC61DA4 for ; Thu, 16 Feb 2023 09:56:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1AC6F6B0071; Thu, 16 Feb 2023 04:56:11 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 15C6C6B0074; Thu, 16 Feb 2023 04:56:11 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 022D06B0078; Thu, 16 Feb 2023 04:56:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id E77096B0071 for ; Thu, 16 Feb 2023 04:56:10 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 908A1811D7 for ; Thu, 16 Feb 2023 09:56:10 +0000 (UTC) X-FDA: 80472699300.16.B69A9D3 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf25.hostedemail.com (Postfix) with ESMTP id 61710A001A for ; Thu, 16 Feb 2023 09:56:08 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="IxvjWXm/"; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676541368; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uSf4rPxDI4PK5WHfG9t2gwXH78HiPuNdnpkIgDcejxM=; b=rTV3zhb26x95kVqJUb6jPoA8GvXbCn2Tv+jjyZ0r4jSrCOMpJdQuhZKWKs6u4pGa4XIuo6 TJXsvZEpfa4S/yhkYJlINP9r7xu7+ojwWmyCXOjKMQANPrMk//MnUxch7kvUOnonMO7G/+ bfAuSaf3w9/LIykznLiOnUzvoA2ZskE= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="IxvjWXm/"; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676541368; a=rsa-sha256; cv=none; b=nRv9/xHVc8XRFH4aF3SqNwUpdta+m8RR9x4CgTFQV4ozEcV04PZxStne/wdhfmWWl/5R14 vJ8CEISO1kAahdeSmdZhf9MbSYjOmt1yZ+4gKkIkPRY1rCgyhpuUhj2fBoNl2fYQInJu5W 43UQxBz6fVpANc/NAuTwpfdIn5fB8To= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676541367; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uSf4rPxDI4PK5WHfG9t2gwXH78HiPuNdnpkIgDcejxM=; b=IxvjWXm/nUFjnpfp+VjG/zsc88MRCzQRHrUY7GsySTyvHf8sIAarvpUrCiyipAu2IiJrKr gQJJzMmEaoSEVq8iSPSkL2yZZ00fROxPUqtMgYhsJWzmmLTPca6M9mLKmlkcsChSFG8Yv2 dUF3b1TdMeaitO6cWR5mndQIEYy0+iU= Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-662-p29LdrIJMoqO7u4o_Zdmgw-1; Thu, 16 Feb 2023 04:56:06 -0500 X-MC-Unique: p29LdrIJMoqO7u4o_Zdmgw-1 Received: by mail-lj1-f197.google.com with SMTP id o19-20020a05651c051300b002934fe0289bso312280ljp.0 for ; Thu, 16 Feb 2023 01:56:06 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=uSf4rPxDI4PK5WHfG9t2gwXH78HiPuNdnpkIgDcejxM=; b=cgdL7SKPt3qaDD8vE8QPxZRs8KdBOhasApRQD56O+6Ff6Di7V65vN7t4PJ92HCbJHv zmM5Sweaix4ofpZbQlcjxI0L47Aa1pVHQGLNCZfniyIeSobRGB74zTVRvW6hUcjUWs2Y 3dlydolj1fa8yU7IIAsqhR3fA5bNkiw0I/5ZhY0U9oNaqDPZR+/g0/sLC3cxSakIQpDm zg2y525r66GnNjdR6lzoYB/xYkq11zr6rrUqnxe8ZESRtqfls39aqfZbAb0ehcxdR01r 47boeA4V65nbyzZbwuoVEqbMrj0GmgOXMGfLR8+Nw7Q0P7lnZi8Ul3PdfLvINY8aqERt +rZw== X-Gm-Message-State: AO0yUKWD0PUovG+T22H7QLnqtSwRndyhrlw1WS7P+Cw9fqDWPqWJYD+J TSTgJpFojUMyELX6MfJ1mG938OFcR/giV6A6W42+r6rcAXKJC5elTMfPntkKiZky6Yg6lFsAwHp bXf0aDdXZjuXJS3vW X-Received: by 2002:a05:651c:b20:b0:293:3dd6:89a4 with SMTP id b32-20020a05651c0b2000b002933dd689a4mr2644398ljr.34.1676541365207; Thu, 16 Feb 2023 01:56:05 -0800 (PST) X-Google-Smtp-Source: AK7set86Dteipgj8wYxbQ5+bF8BJUjd+1l5fPmvG52JGhNgza9RUkZ4v6+ebNPF3JYs/1oa95PuUVg== X-Received: by 2002:a05:600c:a292:b0:3d9:fb59:c16b with SMTP id hu18-20020a05600ca29200b003d9fb59c16bmr4388625wmb.36.1676540965378; Thu, 16 Feb 2023 01:49:25 -0800 (PST) Received: from ?IPV6:2003:cb:c708:bc00:2acb:9e46:1412:686a? (p200300cbc708bc002acb9e461412686a.dip0.t-ipconnect.de. [2003:cb:c708:bc00:2acb:9e46:1412:686a]) by smtp.gmail.com with ESMTPSA id n27-20020a05600c3b9b00b003e206cc7237sm3546085wms.24.2023.02.16.01.49.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Feb 2023 01:49:24 -0800 (PST) Message-ID: <85d0ddcb-4e47-4f2e-2897-a785872b860c@redhat.com> Date: Thu, 16 Feb 2023 10:49:23 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v2 2/2] mm/memory_hotplug: cleanup 'ret' variable usage in do_migrate_range() To: SeongJae Park , Andrew Morton Cc: Oscar Salvador , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20230215230300.61125-1-sj@kernel.org> <20230215230300.61125-3-sj@kernel.org> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230215230300.61125-3-sj@kernel.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 61710A001A X-Stat-Signature: ugebxq9he3atewnxn1czy35pphcfkf9d X-HE-Tag: 1676541368-373673 X-HE-Meta: U2FsdGVkX1+hlZ7vfIzSX4TKyX5nSkyXETpE9VlNIh3li6nXyeDMdcHZKT4JbhTpXEnTlmNU9AaKVz9uQBk8B4J3PB7u3ppZzPH5UYG6UKHcKj6WjuQIpwO8OX51KYkdJWWkhSM3jqmzemEi6Z3os5aBL5vQyh8yTVzdjjcvVcL2U7o1JDCPqnQVz/7bxfOWjZlXMrYnt6g7yR47chXRJqxmP8Qq+02QJSqc1Osl+blTMq/HS8WSqyoCQ5p0S20NM1bfdk969NeeX2mihqrtiA+4gLZ4AKK87LK2q+fkCr5giFKGbwnivL050bu2aZWS3BppjkuNin3kUmmNbT46UMNWw52ktj+ZpwZAMIvlHDxoAUomi0/9Suqb9xOKaDbERMSQ36f6e58qsrb85b7uLxiMsWYa+LmZC2U0t8pRA0HE2QPUfyEKbSyho1FHFcQDzzm2auLYVzM/wwkJtu0EqbU+jI4sP8+w0PHSI3fbBQYGUwGwK9ve4w0rcdRNhSiAFoLd7wdYK+91xIFWMOqVOvhP1yJqiVAnKr5jIpph3xhOTd/wrUNKZrjnVrJbXvcpEm17KGEvaaSp40eHhIw/yC7Z6lsqx+oJnLvqXSeujyDcbsU+as04sXMeDi4a6kKZpw+9MNvhwCgcGBd3WKurT/W66v9+e3y1yXN33IUeMexSA3mSmStLJjd1euFRAVwrbLpoe4TNDYiMoM5q1hKi1KOjrvPRDtm0fiw9ZbwIDo323ZXN4vLzPGfQbiDyMH6VYRVgbiiV+AgQaXNjO/wRh86ewfqeT9gofYZT5xYa9q6nXhkcTbyJ6uXYEUtXh0m3PfriOn4U6Gb6rpjy6uveCPsdQQnLCzLhb0IJQuubVfuCuDh4jXRR3C9Y0H2U0G6w3EneF+U5olpYZUZAjIdPjNP9gy7mKQ1iRXopJmD7qvv0stAWdeHj76fuRsn5z4qosB8MvFjqdui89c4rTj/ ViDGNly+ EyV5WTvG9p9o1FRrZ4HZnUTvFffFhOu6kpcwm1Z99BfnLzX6BCHFhWpYZL0bur/chbh4AklGmNWfh9JBJphgWTCdM+6w9VqpoOXrvxVgPjUrSYjFJzP+d0bKYGTKBowHRrvU3nQ3eIvacnR/gNr+KIB2TmLKB66Y7tQJ3sqpQs2/QaLzhKK58EfQfr26D/wJZuRi160ifue+2fzdmxzusTRJsaQzrs962XQ6OToNq0XH4nHV25RFdaZI7HfoaeAUWxAYPWDi2BM4ekrN0k6tmaxl4Pmuy4RTVC8CdfaUfenqTsqrlhq1QrnI2WBcxrNSwgZ88AEtfEnSKLMpFGU8RW80Eb/gLhiNM4oi/j5tYexLGiykDMsHwPCAxDM4Mjonqsf/8SjuO/e46VudlaU0MmalAMggOeRbD2ax0UF40Nu1+dCELg4rDfkOSTpAHVBmR7N4RR20oHUrBowyU4zioOAsHiBUDcj2QmBnwdUq/HQoHT3RvI4B4ElxOWq3I8qXABhBw X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 16.02.23 00:03, SeongJae Park wrote: > Because do_migrate_range() is returning nothing, some 'ret' variable > usages are unnecessary. Remove unnecessary usage and reduce its scope. > > Signed-off-by: SeongJae Park > --- > mm/memory_hotplug.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > index 6c615ba1a5c7..6df3072d11df 100644 > --- a/mm/memory_hotplug.c > +++ b/mm/memory_hotplug.c > @@ -1624,7 +1624,6 @@ static void do_migrate_range(unsigned long start_pfn, unsigned long end_pfn) > { > unsigned long pfn; > struct page *page, *head; > - int ret = 0; > LIST_HEAD(source); > static DEFINE_RATELIMIT_STATE(migrate_rs, DEFAULT_RATELIMIT_INTERVAL, > DEFAULT_RATELIMIT_BURST); > @@ -1678,7 +1677,6 @@ static void do_migrate_range(unsigned long start_pfn, unsigned long end_pfn) > page_is_file_lru(page)); > > } else { > - ret = -EBUSY; > if (__ratelimit(&migrate_rs)) { > pr_warn("failed to isolate pfn %lx\n", pfn); > dump_page(page, "isolation failed"); > @@ -1692,6 +1690,7 @@ static void do_migrate_range(unsigned long start_pfn, unsigned long end_pfn) > .nmask = &nmask, > .gfp_mask = GFP_USER | __GFP_MOVABLE | __GFP_RETRY_MAYFAIL, > }; > + int ret; > > /* > * We have checked that migration range is on a single zone so Please squash that into the previous patch, just calling it "mm/memory_hotplug: cleanup return value handling in do_migrate_range()" or similar. -- Thanks, David / dhildenb