From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03196C83F1B for ; Wed, 16 Jul 2025 09:43:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7C70C8D0007; Wed, 16 Jul 2025 05:43:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 777FB8D0001; Wed, 16 Jul 2025 05:43:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 667038D0007; Wed, 16 Jul 2025 05:43:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 5544D8D0001 for ; Wed, 16 Jul 2025 05:43:52 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id EC5861402F6 for ; Wed, 16 Jul 2025 09:43:51 +0000 (UTC) X-FDA: 83669641062.12.F4F9D7F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf28.hostedemail.com (Postfix) with ESMTP id 7B046C0004 for ; Wed, 16 Jul 2025 09:43:49 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=LoLUj0gw; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752659029; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/EZXRrxsf4hYE6kRrn8jWim6/VvZEve3WV0swLXkTVY=; b=Wq7lCaUcD2+SxUS86A27hKD4h+9IQwSIvkxnTh08AQqjPqjeat3v8y3y/0oY1iVtV4W+x9 N1LWbuEdaD2TTUrRJBd9AeeYDgS4Pds68gojWWkNLxMAMAFS0BZVqm9X93/mG50NvP6S5n 81B9CnJkkdgCtFe+2XE7PeQYiph5HN0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752659029; a=rsa-sha256; cv=none; b=1V/D58qpo6nWdWN4RE36xEjdxa1bPu/hZ5HDJujUbQ4g00cTaDFU25jbLwCPC0CyINRdLX 1lynb2MHw4HirNecSyZ6yEcY+MMK57TE5LBXGBdDL1txgfUxzAu0WZae+OdU+zVo0cs0LU XTTbpHkFvYE0kSYygnOV1ahsvEORHJ8= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=LoLUj0gw; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752659028; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=/EZXRrxsf4hYE6kRrn8jWim6/VvZEve3WV0swLXkTVY=; b=LoLUj0gw5ODg9nJPaIgNyaHlkPmziiR4uOcBmtoJDezL3XHcSmmV2m+tB5eYerLDGt5mzg P7m9iNr7Zc+zG1hy98Gl5In8ASJy+MLpOvc7MruTCmW/0UubCAJR9+Fsfz9VzfWumB9dpE XmN5ct/Z/LeJv0ggxTl276Sl3LD0v7k= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-608-vNnC4T3NP9e-NTG65bcwkA-1; Wed, 16 Jul 2025 05:43:47 -0400 X-MC-Unique: vNnC4T3NP9e-NTG65bcwkA-1 X-Mimecast-MFC-AGG-ID: vNnC4T3NP9e-NTG65bcwkA_1752659026 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-45617e7b82fso17536995e9.3 for ; Wed, 16 Jul 2025 02:43:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752659026; x=1753263826; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/EZXRrxsf4hYE6kRrn8jWim6/VvZEve3WV0swLXkTVY=; b=RBXBSHw8+9hE6MQZf5xaHG4Rx/zA1HMn8MERj7DB10g0++8F8hR4ZMpQ7RIfdvWD93 8Lkk9MhXH87IOv75LE5LRQzSajw4TugmPcZzp1494s3BlxWVWhwyP5rwWv2OQXRD5ZRw h4bu48Z79NAcigghU8ZJfNtWIWE+nyyG4w8YCpJoO7SMUzYGpn6Wj3eBIYiYHiKrh+gE CkiFyGnmWptaCRQ8l/x9OzJ4AJkzdz1ibE5o9gZ5dHwCrOQyJ7ioSMUSlUh7e/8qnVHy 5jl6+CWYLIfoarwua6V8AXX1UuoM1vx3xk8lc/nIJg6e/xULBnmkEFdJYEBV6Z21mlI/ xVcw== X-Forwarded-Encrypted: i=1; AJvYcCVeG/Oje37oU+tzQ5RIAicJyJ2VxIRZmbEh/hMlMzzjKxppwMJV5wynToge5AIM0OSQM0Uf1EtJgw==@kvack.org X-Gm-Message-State: AOJu0YyDpNK0Hej4BTKtZbWOzvKTMFurEyLkGwbP2bkmNocxSc3HlPv5 UnrI1iaxCUueaPWTCowcwPh9ShGaqUq0GJ7kBCs2z3r5TxTz0E4HW+2k/ahuoxYEOnvFQ9EpNPE P0ic30X1YbzolMJh9F2ynlqnw2yOEmkl2URYnjzxOuNSxtmB+6SIA X-Gm-Gg: ASbGncvHNXJN47jm+Yz1kpT+sorxkg7fddtzHTsMp5vkOW27mrRzHrHb5Sq42cRAheU AHKnJXTRDr/27tb7TCJ4p0FX08dFjbW9XQiZyX5HlyOkbpn7Jdx4qXuHf6+K4K7gk9Tu0kGzhsz SBwdxJv6QZhsZhZXeXNCuJP09mp3/9psAygAZwmSI3WtvoOg3Wu4kSaWxdjup6LSPM0RphRyFY0 dwHxGUQDdcfYrCOJttiAkf88T2Bzco/BIT27w57269j2a+vxkITJvjWkEyha+NiPn8tuOwfKE3j YLLj2EviNkP271eowV2SUYbOFtjmv9H+2lftDV0PkX860gxjrvgta9EbVmKiIzUa7a4BIFawYh4 saEXsMeQKMLYzD7K/ds/0oJIk2gY1JhNLRnK1MiThZ92H4Ah1DSCmUh2CLwJwNNiEaEM= X-Received: by 2002:a05:600c:450f:b0:456:2981:2d6 with SMTP id 5b1f17b1804b1-4562e34dc2amr20718975e9.14.1752659026007; Wed, 16 Jul 2025 02:43:46 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHOTvAkZYlnUiMKWPHkmso+B0Carde0PiVJl54H4YFpST7Qr1kk5OYhcs8Luh+rMMtmr1Qd2A== X-Received: by 2002:a05:600c:450f:b0:456:2981:2d6 with SMTP id 5b1f17b1804b1-4562e34dc2amr20718615e9.14.1752659025580; Wed, 16 Jul 2025 02:43:45 -0700 (PDT) Received: from ?IPV6:2003:d8:2f1d:ed00:1769:dd7c:7208:eb33? (p200300d82f1ded001769dd7c7208eb33.dip0.t-ipconnect.de. [2003:d8:2f1d:ed00:1769:dd7c:7208:eb33]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b5e8e0d70csm17635386f8f.62.2025.07.16.02.43.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Jul 2025 02:43:45 -0700 (PDT) Message-ID: <85b79e18-8c67-47d9-8520-0dfd31a5a6fd@redhat.com> Date: Wed, 16 Jul 2025 11:43:42 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] "fork: reorder function qualifiers for copy_clone_args_from_user" To: Dishank Jogi , Kees Cook , Andrew Morton , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Christian Brauner , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20250716093525.449994-1-dishank.jogi@siqol.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAmgsLPQFCRvGjuMACgkQTd4Q 9wD/g1o0bxAAqYC7gTyGj5rZwvy1VesF6YoQncH0yI79lvXUYOX+Nngko4v4dTlOQvrd/vhb 02e9FtpA1CxgwdgIPFKIuXvdSyXAp0xXuIuRPQYbgNriQFkaBlHe9mSf8O09J3SCVa/5ezKM OLW/OONSV/Fr2VI1wxAYj3/Rb+U6rpzqIQ3Uh/5Rjmla6pTl7Z9/o1zKlVOX1SxVGSrlXhqt kwdbjdj/csSzoAbUF/duDuhyEl11/xStm/lBMzVuf3ZhV5SSgLAflLBo4l6mR5RolpPv5wad GpYS/hm7HsmEA0PBAPNb5DvZQ7vNaX23FlgylSXyv72UVsObHsu6pT4sfoxvJ5nJxvzGi69U s1uryvlAfS6E+D5ULrV35taTwSpcBAh0/RqRbV0mTc57vvAoXofBDcs3Z30IReFS34QSpjvl Hxbe7itHGuuhEVM1qmq2U72ezOQ7MzADbwCtn+yGeISQqeFn9QMAZVAkXsc9Wp0SW/WQKb76 FkSRalBZcc2vXM0VqhFVzTb6iNqYXqVKyuPKwhBunhTt6XnIfhpRgqveCPNIasSX05VQR6/a OBHZX3seTikp7A1z9iZIsdtJxB88dGkpeMj6qJ5RLzUsPUVPodEcz1B5aTEbYK6428H8MeLq NFPwmknOlDzQNC6RND8Ez7YEhzqvw7263MojcmmPcLelYbfOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCaCwtJQUJG8aPFAAKCRBN3hD3AP+DWlDnD/4k2TW+HyOOOePVm23F5HOhNNd7nNv3 Vq2cLcW1DteHUdxMO0X+zqrKDHI5hgnE/E2QH9jyV8mB8l/ndElobciaJcbl1cM43vVzPIWn 01vW62oxUNtEvzLLxGLPTrnMxWdZgxr7ACCWKUnMGE2E8eca0cT2pnIJoQRz242xqe/nYxBB /BAK+dsxHIfcQzl88G83oaO7vb7s/cWMYRKOg+WIgp0MJ8DO2IU5JmUtyJB+V3YzzM4cMic3 bNn8nHjTWw/9+QQ5vg3TXHZ5XMu9mtfw2La3bHJ6AybL0DvEkdGxk6YHqJVEukciLMWDWqQQ RtbBhqcprgUxipNvdn9KwNpGciM+hNtM9kf9gt0fjv79l/FiSw6KbCPX9b636GzgNy0Ev2UV m00EtcpRXXMlEpbP4V947ufWVK2Mz7RFUfU4+ETDd1scMQDHzrXItryHLZWhopPI4Z+ps0rB CQHfSpl+wG4XbJJu1D8/Ww3FsO42TMFrNr2/cmqwuUZ0a0uxrpkNYrsGjkEu7a+9MheyTzcm vyU2knz5/stkTN2LKz5REqOe24oRnypjpAfaoxRYXs+F8wml519InWlwCra49IUSxD1hXPxO WBe5lqcozu9LpNDH/brVSzHCSb7vjNGvvSVESDuoiHK8gNlf0v+epy5WYd7CGAgODPvDShGN g3eXuA== Organization: Red Hat In-Reply-To: <20250716093525.449994-1-dishank.jogi@siqol.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: ZiFwkyvwJBgggJ10CZnLSUTGroKU2_cot-K0Yls2krU_1752659026 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 7B046C0004 X-Rspam-User: X-Rspamd-Server: rspam09 X-Stat-Signature: j5j7g154cittga5kp34cz6t9u1ito5ya X-HE-Tag: 1752659029-713925 X-HE-Meta: U2FsdGVkX18zIbM2A7sZE7kdENStn87l6JTx8huKrd7Sp68ngbWdijen7AlwJigmopdCia5L6H8Lw/G44kFcaZ3o+6WkMzwHg1IBHnn7n5l9lRH8w2rwPqWYiHDvunUNEI+lJnUwugHo9b7+6AumeGJyLhxmRwOAEDxjeWFHJHb0DmkRPj3y5Foi8+5hMP62gCKcCAw8KhzTt6rYhlS9S9LfdWghn5OZryGhyRwH6YSBTOlOWJcMXOKNZizu+4oExmVDhwDA7sNlvIwcX/GwwzECU1brvrHpZqjE9J25CkdQdQjrMeToN5pYN4PT5Ho2HqcGGkSz/f/GV4p1Yx7fovWAX5N1yTmsAez3eJtiiuy2Cm/ZneKo8lGyMRP+epqVNQNBYRlq9GCtvUnp1Y5dCa993iXEuHeNpBmmhPuQP3dXEGQxTUM85dIOakwMpMZcYMkzv1d5DSQ4vkzj63vK/jxXNkGcP8l2bfCdWxfMeUixqK2aFIM9SiTStMorEFc5qEvw08wq4L8KyF3C78iMPDlClxoh5M1peNlN7PUA3qVssIQOd1r5GyN9GsMfPW9Jkarnfzwla6LItvCQDiuWvu/MGfwjf9t4rykfYS/h9IW4ODF8Egemxcu6liLJu2ZEiKqDGfbLOX2x1WxCStG6qKb7TS7EDYJhncWEM5zY/sRc98NgjIvtrQfLGvVCVCXWQ/GQYdqbxa3u+1l3kuCtxnLSPdl/8onzzJmqX5qz2aPBb3poE+3I6yelx/NI87eILE+Wy9wWis+QH3GVy4W9T2OKdTCmpht9jlTMWv+JoIpnZfH7zjG59RZgNoQI6/0uqllkrvQ3e2hNMJkS+SmgJVN6RYbswYsPJPCOEYeBEJ0w0m7AZB0yBghPrueCaihAUbh9SPFO4GlsiueKXq5ZB4hm+IaS6n7B304mAY0tip3iJ5xIVpAjo4pDJDNkfCXfG9Z5b79Inx6ZGu6eOz8 dkczrLxt KC54qzEYZM2r9szDj1QxRholobhYYNdQLf7QPqOh4BcxvVz4aKHrXW1keYjzsPS0d0aiOUeyrUNrtfrevdCRrlUhjljUC9I5WpP3UvIa3FgHMMmQzMmWaOUyilkNv0rdCO5fYpIMpzpFVIujP3u8vcyvswOW2gQyYi3h+KTpuYCJRPmwyzi9xcLmryZjqPfgUF2ZfS/PUC4rzLbQA/tBq8azYJRqfXHE+J6yFyCUWeezYfus1RD8wp/2lfKI6KYsMskU5sY4EoKMebSxte8tTLxXcpJTWaBcRN9iQR5BfNlrgW+i9olAPFnO5k9XJraje7lxf/IXlhGm5abFd2yieLKSWv+czI005hjoToyndr99XRuT3DgaGAY8U1Rv+dOXG0XV/cdXZLlFwT0+KtJK164+zk1O1rKZVqv5o8U2OM24VCHdyKDDgStTuMLDGM//fnXx9BgTaFrFOwQrbBoZDVLU/pQPVGpxZFljF4/HU5kx+/UWdBNDAn2Ubk2rlqr+DBALW3163oLSiX1GITC2RJzHrEemQKBWDS+Xu23PM7rzXIdu4Fx34PhaGwwMldN1eHVPzYJoB1g4GVSPEFor/yv1/sQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 16.07.25 11:35, Dishank Jogi wrote: "" in patch subject is weird > Change the order of function qualifiers from 'noinline static' to 'static noinline' > in copy_clone_args_from_user for consistency with kernel coding style. > > This is a non-functional change intended to improve readability and maintain > consistent ordering of qualifiers across the codebase. Simplify to "No functional change intended." All the other stuff can be dropped from this sentence IMHO -- I'd even drop the whole sentence. > > Signed-off-by: Dishank Jogi > --- > kernel/fork.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/fork.c b/kernel/fork.c > index 1ee8eb11f38b..574ff0d983db 100644 > --- a/kernel/fork.c > +++ b/kernel/fork.c > @@ -2743,7 +2743,7 @@ SYSCALL_DEFINE5(clone, unsigned long, clone_flags, unsigned long, newsp, > } > #endif > > -noinline static int copy_clone_args_from_user(struct kernel_clone_args *kargs, > +static noinline int copy_clone_args_from_user(struct kernel_clone_args *kargs, > struct clone_args __user *uargs, > size_t usize) > { Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb