[PATCH] mm/mm_init.c: remove redundant pr_info when node is memoryless

[PATCH] mm/mm_init.c: remove redundant pr_info when node is memoryless

[Yajun Deng]

There is a similar pr_info in free_area_init_node(), so remove the
redundant pr_info.

Signed-off-by: Yajun Deng <yajun.deng@linux.dev>
---
 mm/mm_init.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/mm/mm_init.c b/mm/mm_init.c
index 50f2f34745af..6be6f50813b1 100644
--- a/mm/mm_init.c
+++ b/mm/mm_init.c
@@ -1871,8 +1871,6 @@ void __init free_area_init(unsigned long *max_zone_pfn)
 		pg_data_t *pgdat;
 
 		if (!node_online(nid)) {
-			pr_info("Initializing node %d as memoryless\n", nid);
-
 			/* Allocator not initialized yet */
 			pgdat = arch_alloc_nodedata(nid);
 			if (!pgdat)
-- 
2.25.1

Re: [PATCH] mm/mm_init.c: remove redundant pr_info when node is memoryless

[Andrew Morton]

On Wed,  6 Sep 2023 17:11:13 +0800 Yajun Deng <yajun.deng@linux.dev> wrote:

> There is a similar pr_info in free_area_init_node(), so remove the
> redundant pr_info.

Please quote the before and after dmesg output so we can better
understand this proposal, thanks.

Re: [PATCH] mm/mm_init.c: remove redundant pr_info when node is memoryless

[Yajun Deng]

September 11, 2023 at 5:30 AM, "Andrew Morton" <akpm@linux-foundation.org> wrote:


> 
> On Wed, 6 Sep 2023 17:11:13 +0800 Yajun Deng <yajun.deng@linux.dev> wrote:
> 
> > 
> > There is a similar pr_info in free_area_init_node(), so remove the
> >  redundant pr_info.
> > 
> 
> Please quote the before and after dmesg output so we can better
> understand this proposal, thanks.
>

before:
[    0.006314] Initializing node 0 as memoryless
[    0.006445] Initmem setup node 0 as memoryless
[    0.006450] Initmem setup node 1 [mem 0x0000000000001000-0x000000003fffffff]
[    0.006453] Initmem setup node 2 [mem 0x0000000040000000-0x000000007ffd7fff]
[    0.006454] Initializing node 3 as memoryless
[    0.006584] Initmem setup node 3 as memoryless
[    0.006585] Initmem setup node 4 [mem 0x0000000100000000-0x00000001bfffffff]
[    0.006586] Initmem setup node 5 [mem 0x00000001c0000000-0x00000001ffffffff]
[    0.006587] Initmem setup node 6 [mem 0x0000000200000000-0x000000023fffffff]

after:
[    0.004147] Initmem setup node 0 as memoryless
[    0.004148] Initmem setup node 1 [mem 0x0000000000001000-0x000000003fffffff]
[    0.004150] Initmem setup node 2 [mem 0x0000000040000000-0x000000007ffd7fff]
[    0.004154] Initmem setup node 3 as memoryless
[    0.004155] Initmem setup node 4 [mem 0x0000000100000000-0x00000001bfffffff]
[    0.004156] Initmem setup node 5 [mem 0x00000001c0000000-0x00000001ffffffff]
[    0.004157] Initmem setup node 6 [mem 0x0000000200000000-0x000000023fffffff]

Re: [PATCH] mm/mm_init.c: remove redundant pr_info when node is memoryless

[David Hildenbrand]

On 06.09.23 11:11, Yajun Deng wrote:
> There is a similar pr_info in free_area_init_node(), so remove the
> redundant pr_info.
> 
> Signed-off-by: Yajun Deng <yajun.deng@linux.dev>
> ---
>   mm/mm_init.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/mm/mm_init.c b/mm/mm_init.c
> index 50f2f34745af..6be6f50813b1 100644
> --- a/mm/mm_init.c
> +++ b/mm/mm_init.c
> @@ -1871,8 +1871,6 @@ void __init free_area_init(unsigned long *max_zone_pfn)
>   		pg_data_t *pgdat;
>   
>   		if (!node_online(nid)) {
> -			pr_info("Initializing node %d as memoryless\n", nid);
> -
>   			/* Allocator not initialized yet */
>   			pgdat = arch_alloc_nodedata(nid);
>   			if (!pgdat)


Reviewed-by: David Hildenbrand <david@redhat.com>

-- 
Cheers,

David / dhildenb