From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D71D8C38A29 for ; Sun, 19 Apr 2020 23:40:51 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 833AB20771 for ; Sun, 19 Apr 2020 23:40:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 833AB20771 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=acm.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E14BF8E0005; Sun, 19 Apr 2020 19:40:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DC4A48E0003; Sun, 19 Apr 2020 19:40:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CB26F8E0005; Sun, 19 Apr 2020 19:40:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0213.hostedemail.com [216.40.44.213]) by kanga.kvack.org (Postfix) with ESMTP id B07348E0003 for ; Sun, 19 Apr 2020 19:40:50 -0400 (EDT) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 796A0180AD81D for ; Sun, 19 Apr 2020 23:40:50 +0000 (UTC) X-FDA: 76726227060.16.burst74_5e9fdef069263 X-HE-Tag: burst74_5e9fdef069263 X-Filterd-Recvd-Size: 2941 Received: from mail-pg1-f195.google.com (mail-pg1-f195.google.com [209.85.215.195]) by imf23.hostedemail.com (Postfix) with ESMTP for ; Sun, 19 Apr 2020 23:40:50 +0000 (UTC) Received: by mail-pg1-f195.google.com with SMTP id j7so575312pgj.13 for ; Sun, 19 Apr 2020 16:40:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=3pB9t58pK0EznN9S4Sd0+htiX+z00NIIdr4sNq8MWCA=; b=IyxNzvv3VkB/BheWPrPkGr/cz38nZTqUGg0snAixwk4B/ASAOhJ3Gg8F/uMW7FBZK6 tBWubRSPpYoAgptOxjxG26UY37mxsiqL2wP3309fTowDfOW9n1ZvG80C4J1EmdeyeHy0 J7rIdhloDdNoNoIwVLrUWQkf1HSraX5VEd0vK2WGuMOFuDLUBh/9772/gFiaC7oNTKfz 4cTwUitEhbxafFQjCRZCnjzRRkJj24uUWpv2qnlbq+bfIit70/SbptkxANM9JqakveBp UqmVUsGsmeT36wUHV0N0A1VjZblGNE09KAA++7S5MGqHWh6X10LY2dzYUWPx91TmurFY Sn0Q== X-Gm-Message-State: AGi0PuYJ0wg6zlVf3MTUdLxw6WleT1FekDmXcARg1PaEVyNy+1sADt1k 9e5LrnPyb7OP4XwDTDZ5EUk= X-Google-Smtp-Source: APiQypL0M8AzubBb/6HiLPC5OQyscP2rx0fUGaKDKO6l3uGUZ9dFwn1hO/YwT+koWYrl57dC2MDzaA== X-Received: by 2002:aa7:8d81:: with SMTP id i1mr14698377pfr.34.1587339649205; Sun, 19 Apr 2020 16:40:49 -0700 (PDT) Received: from [100.124.11.78] ([104.129.198.54]) by smtp.gmail.com with ESMTPSA id o21sm11906838pjr.37.2020.04.19.16.40.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 19 Apr 2020 16:40:48 -0700 (PDT) Subject: Re: [PATCH v2 10/10] block: put_device() if device_add() fails To: Luis Chamberlain , axboe@kernel.dk, viro@zeniv.linux.org.uk, gregkh@linuxfoundation.org, rostedt@goodmis.org, mingo@redhat.com, jack@suse.cz, ming.lei@redhat.com, nstange@suse.de, akpm@linux-foundation.org Cc: mhocko@suse.com, yukuai3@huawei.com, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20200419194529.4872-1-mcgrof@kernel.org> <20200419194529.4872-11-mcgrof@kernel.org> From: Bart Van Assche Message-ID: <85a18bcf-4bd0-a529-6c3c-46fcd23a350e@acm.org> Date: Sun, 19 Apr 2020 16:40:45 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200419194529.4872-11-mcgrof@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 4/19/20 12:45 PM, Luis Chamberlain wrote: > Through code inspection I've found that we don't put_device() if > device_add() fails, and this must be done to decrement its refcount. Reviewed-by: Bart Van Assche