From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3ACCFC43464 for ; Sat, 19 Sep 2020 17:14:56 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7F9BC20878 for ; Sat, 19 Sep 2020 17:14:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=zytor.com header.i=@zytor.com header.b="RVdbsWF0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7F9BC20878 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=zytor.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 864326B0037; Sat, 19 Sep 2020 13:14:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7EDB26B0055; Sat, 19 Sep 2020 13:14:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6B5196B005A; Sat, 19 Sep 2020 13:14:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0230.hostedemail.com [216.40.44.230]) by kanga.kvack.org (Postfix) with ESMTP id 4E81E6B0037 for ; Sat, 19 Sep 2020 13:14:53 -0400 (EDT) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 1B75F180AD804 for ; Sat, 19 Sep 2020 17:14:53 +0000 (UTC) X-FDA: 77280460866.09.cork04_3d017b927135 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin09.hostedemail.com (Postfix) with ESMTP id F2EE3180AD801 for ; Sat, 19 Sep 2020 17:14:52 +0000 (UTC) X-HE-Tag: cork04_3d017b927135 X-Filterd-Recvd-Size: 3735 Received: from mail.zytor.com (terminus.zytor.com [198.137.202.136]) by imf26.hostedemail.com (Postfix) with ESMTP for ; Sat, 19 Sep 2020 17:14:52 +0000 (UTC) Received: from [IPv6:2601:646:8600:3281:3892:da5e:7968:73ae] ([IPv6:2601:646:8600:3281:3892:da5e:7968:73ae]) (authenticated bits=0) by mail.zytor.com (8.15.2/8.15.2) with ESMTPSA id 08JHEM9L2313785 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NO); Sat, 19 Sep 2020 10:14:23 -0700 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.zytor.com 08JHEM9L2313785 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zytor.com; s=2020082401; t=1600535664; bh=TomeH5PNcgCZORugcfr47WwuZ6caRoe13lS8klRI7FE=; h=Date:In-Reply-To:References:Subject:To:CC:From:From; b=RVdbsWF0vN/r1byPIFa+D4/5xhRqE5r5iFnS9koO9lEmqPLZuHRSQffS6Fa8JP1Sh O9ah5EJazBZMEzz68apZaO0d54DX4jsb0qkjZQKjSAbFdXoZHhQSevkbjwIjA0NJkl I8ioFyQFROS0bYKb/YpZ6+r4gkfiXQpEpUyNXhM7Qx4g9SxJg+LDavWV98Hg3xPKUr gKzZm+f5SnmGR4pwSY+CGoLXzD3AlcAWlNuW0DZmjyL+I8wj2r+YYFWTYlClTh+GCm /ln/hVW0Ju5cvNREPAAwdvDcCpvc0aH2Xvj2p2LzdQYeTrrSsbjierhVMGddz7uVeR TC9s0a40rK/kg== Date: Sat, 19 Sep 2020 10:14:13 -0700 User-Agent: K-9 Mail for Android In-Reply-To: References: <20200918132439.1475479-1-arnd@arndb.de> <20200918132439.1475479-2-arnd@arndb.de> <20200919053514.GI30063@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH 1/4] x86: add __X32_COND_SYSCALL() macro To: Andy Lutomirski , Christoph Hellwig CC: Arnd Bergmann , Alexander Viro , Eric Biederman , Andrew Morton , LKML , linux-arm-kernel , linux-arch , Linux-MM , kexec@lists.infradead.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , Christoph Hellwig , Brian Gerst From: hpa@zytor.com Message-ID: <85F32523-4E9E-443A-A150-10A9E5EB0CE3@zytor.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On September 19, 2020 9:23:22 AM PDT, Andy Lutomirski w= rote: >On Fri, Sep 18, 2020 at 10:35 PM Christoph Hellwig >wrote: >> >> On Fri, Sep 18, 2020 at 03:24:36PM +0200, Arnd Bergmann wrote: >> > sys_move_pages() is an optional syscall, and once we remove >> > the compat version of it in favor of the native one with an >> > in_compat_syscall() check, the x32 syscall table refers to >> > a __x32_sys_move_pages symbol that may not exist when the >> > syscall is disabled=2E >> > >> > Change the COND_SYSCALL() definition on x86 to also include >> > the redirection for x32=2E >> > >> > Signed-off-by: Arnd Bergmann >> >> Adding the x86 maintainers and Brian Gerst=2E Brian proposed another >> problem to the mess that most of the compat syscall handlers used by >> x32 here: >> >> https://lkml=2Eorg/lkml/2020/6/16/664 >> >> hpa didn't particularly like it, but with your and my pending series >> we'll soon use more native than compat syscalls for x32, so something >> will need to change=2E=2E > >I'm fine with either solution=2E My main objection was naming=2E x64 is a widely used synonym for x86-64, a= nd so that is confusing=2E --=20 Sent from my Android device with K-9 Mail=2E Please excuse my brevity=2E