From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F895C433E0 for ; Mon, 25 Jan 2021 18:19:54 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 33E9B22ADC for ; Mon, 25 Jan 2021 18:19:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 33E9B22ADC Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 808066B002D; Mon, 25 Jan 2021 13:19:53 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7B8AD6B002F; Mon, 25 Jan 2021 13:19:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6A96D6B0030; Mon, 25 Jan 2021 13:19:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0126.hostedemail.com [216.40.44.126]) by kanga.kvack.org (Postfix) with ESMTP id 521616B002D for ; Mon, 25 Jan 2021 13:19:53 -0500 (EST) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 0FD621EF1 for ; Mon, 25 Jan 2021 18:19:53 +0000 (UTC) X-FDA: 77745111066.20.stick26_3f15d2727587 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin20.hostedemail.com (Postfix) with ESMTP id C3DA8180C0616 for ; Mon, 25 Jan 2021 18:19:52 +0000 (UTC) X-HE-Tag: stick26_3f15d2727587 X-Filterd-Recvd-Size: 5663 Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) by imf48.hostedemail.com (Postfix) with ESMTP for ; Mon, 25 Jan 2021 18:19:51 +0000 (UTC) Received: by mail-pj1-f49.google.com with SMTP id gx1so125094pjb.1 for ; Mon, 25 Jan 2021 10:19:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :mime-version; bh=0c4KjDt9RqUgbcxyXAyGUkPhwWC8rpyfeee6wZQAFco=; b=AqNbyr+0wl4qPhxc3CH+99Y1/W6aQeouqpdR58sNIYDkGf5WmwV5MgeLJBM+IJ1Pvc dioGNRhcggbnIEy9SigRQFGl8trx8Oxl81+dLdOAiLTHheihfnqS0qNI5qKQ51G6PrWi AjxiMB4vDodzkwLRjltgGxDQrHLTXzNrsIXnVtWs2KYQTZTQ3pIGDts5Yr21ui0aaIQi 4bSnWwkHoSrHG0JHeaBj3YOZKvkMqu3AnHvqU6KZCxOoYOENDNIxXW9TJT6Fpy/alZj4 lOQ5W05p4mQz8efM/bPfTOaLOcBGbqYkFi5TwVKa1jIVc91DXYFZhhGlS/2/K5IOi6+O Zr0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version; bh=0c4KjDt9RqUgbcxyXAyGUkPhwWC8rpyfeee6wZQAFco=; b=XbZVdh8gs9OXnuvd95Xzrsa7m7lp5V+SNIHhs+S2FlzG1MDV/6/R8rxpCBSbtMUaVo RRr5gmvWPmbVoZIzp95hUnWMcvaze8a2iIVheID9ck93VGwPkpLPFe2F8kDOCDOKelM/ QbPJdWLwRkpoEdW+eJqzX9y7jkuRsexZv1Cr0cAb8a3pLvO9oSJibEK9ZDw+2wnurkVD EvhOQH/ngsvrOfS/CjUxQ53xqkTTQSn124jVWk1vZaEZU0Z1EtHT7Fw36TZs7mbv17dh ygeHKOwJpSqCTjTQ8bVY/EMTNSs6J6NtmVfKbKdxU6ogZj2Glz87zs15yVpc+6a1R8U3 O2qg== X-Gm-Message-State: AOAM531Sj5P/2JiyMJFcQddzUsqJHc2m/AxAkFO4XehU77IzkiZdH4qY abzSIvAelUxcD8UsP9a47xkgFA== X-Google-Smtp-Source: ABdhPJx4cEmVf7ft4lmXwGwBrpz2zFbNGi/QGjI/RQLigXVw/jFM6+G/RZb7dQlNfHWGfUuyCC1KTQ== X-Received: by 2002:a17:902:f54e:b029:de:19f9:c45f with SMTP id h14-20020a170902f54eb02900de19f9c45fmr1958100plf.48.1611598790601; Mon, 25 Jan 2021 10:19:50 -0800 (PST) Received: from [2620:15c:17:3:4a0f:cfff:fe51:6667] ([2620:15c:17:3:4a0f:cfff:fe51:6667]) by smtp.gmail.com with ESMTPSA id w21sm16351255pff.220.2021.01.25.10.19.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Jan 2021 10:19:49 -0800 (PST) Date: Mon, 25 Jan 2021 10:19:48 -0800 (PST) From: David Rientjes To: Alexander Lobakin cc: "David S. Miller" , Jakub Kicinski , Yisen Zhuang , Salil Mehta , Jesse Brandeburg , Tony Nguyen , Saeed Mahameed , Leon Romanovsky , Andrew Morton , Jesper Dangaard Brouer , Ilias Apalodimas , Jonathan Lemon , Willem de Bruijn , Randy Dunlap , Aleksandr Nogikh , Pablo Neira Ayuso , Dexuan Cui , Jakub Sitnicki , Marco Elver , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-rdma@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH net-next 2/3] net: constify page_is_pfmemalloc() argument at call sites In-Reply-To: <20210125164612.243838-3-alobakin@pm.me> Message-ID: <85978330-9753-f7a-f263-7a1cfd95b851@google.com> References: <20210125164612.243838-1-alobakin@pm.me> <20210125164612.243838-3-alobakin@pm.me> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 25 Jan 2021, Alexander Lobakin wrote: > Constify "page" argument for page_is_pfmemalloc() users where applicable. > > Signed-off-by: Alexander Lobakin > --- > drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 2 +- > drivers/net/ethernet/intel/fm10k/fm10k_main.c | 2 +- > drivers/net/ethernet/intel/i40e/i40e_txrx.c | 2 +- > drivers/net/ethernet/intel/iavf/iavf_txrx.c | 2 +- > drivers/net/ethernet/intel/ice/ice_txrx.c | 2 +- > drivers/net/ethernet/intel/igb/igb_main.c | 2 +- > drivers/net/ethernet/intel/igc/igc_main.c | 2 +- > drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 2 +- > drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 2 +- > drivers/net/ethernet/mellanox/mlx5/core/en_rx.c | 2 +- > include/linux/skbuff.h | 4 ++-- > 11 files changed, 12 insertions(+), 12 deletions(-) > > diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c > index 512080640cbc..0f8e962b5010 100644 > --- a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c > +++ b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c > @@ -2800,7 +2800,7 @@ static void hns3_nic_alloc_rx_buffers(struct hns3_enet_ring *ring, > writel(i, ring->tqp->io_base + HNS3_RING_RX_RING_HEAD_REG); > } > > -static bool hns3_page_is_reusable(struct page *page) > +static bool hns3_page_is_reusable(const struct page *page) > { > return page_to_nid(page) == numa_mem_id() && > !page_is_pfmemalloc(page); Hi Alexander, All of these functions appear to be doing the same thing, would it make sense to simply add this to a header file and remove all the code duplication as well?