From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFE3CC64E8A for ; Wed, 2 Dec 2020 12:17:12 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 60C2922203 for ; Wed, 2 Dec 2020 12:17:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 60C2922203 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9F5156B006C; Wed, 2 Dec 2020 07:17:11 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9CC138D0003; Wed, 2 Dec 2020 07:17:11 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8E2BE8D0002; Wed, 2 Dec 2020 07:17:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0114.hostedemail.com [216.40.44.114]) by kanga.kvack.org (Postfix) with ESMTP id 7662C6B006C for ; Wed, 2 Dec 2020 07:17:11 -0500 (EST) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 3F97F8249980 for ; Wed, 2 Dec 2020 12:17:11 +0000 (UTC) X-FDA: 77548241862.01.guide91_2016a3d273b3 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin01.hostedemail.com (Postfix) with ESMTP id 1FF7F1004DD73 for ; Wed, 2 Dec 2020 12:17:11 +0000 (UTC) X-HE-Tag: guide91_2016a3d273b3 X-Filterd-Recvd-Size: 3963 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf12.hostedemail.com (Postfix) with ESMTP for ; Wed, 2 Dec 2020 12:17:10 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A6641101E; Wed, 2 Dec 2020 04:17:09 -0800 (PST) Received: from [192.168.0.130] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D1D823F718; Wed, 2 Dec 2020 04:17:06 -0800 (PST) Subject: Re: [RFC V2 2/3] arm64/mm: Define arch_get_mappable_range() To: David Hildenbrand , linux-mm@kvack.org, akpm@linux-foundation.org Cc: linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, Catalin Marinas , Will Deacon , Ard Biesheuvel , Mark Rutland References: <1606706992-26656-1-git-send-email-anshuman.khandual@arm.com> <1606706992-26656-3-git-send-email-anshuman.khandual@arm.com> <1861413c-fd23-f3e2-14f3-00feec6ff2fb@redhat.com> From: Anshuman Khandual Message-ID: <85975346-d5ae-d971-e50f-9c0b77649910@arm.com> Date: Wed, 2 Dec 2020 17:47:01 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <1861413c-fd23-f3e2-14f3-00feec6ff2fb@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 12/2/20 2:56 PM, David Hildenbrand wrote: > On 30.11.20 04:29, Anshuman Khandual wrote: >> This overrides arch_get_mappable_range() on arm64 platform which will be >> used with recently added generic framework. It drops inside_linear_region() >> and subsequent check in arch_add_memory() which are no longer required. >> >> Cc: Catalin Marinas >> Cc: Will Deacon >> Cc: Ard Biesheuvel >> Cc: Mark Rutland >> Cc: David Hildenbrand >> Cc: linux-arm-kernel@lists.infradead.org >> Cc: linux-kernel@vger.kernel.org >> Signed-off-by: Anshuman Khandual >> --- >> arch/arm64/mm/mmu.c | 14 ++++++-------- >> 1 file changed, 6 insertions(+), 8 deletions(-) >> >> diff --git a/arch/arm64/mm/mmu.c b/arch/arm64/mm/mmu.c >> index ca692a815731..49ec8f2838f2 100644 >> --- a/arch/arm64/mm/mmu.c >> +++ b/arch/arm64/mm/mmu.c >> @@ -1444,16 +1444,19 @@ static void __remove_pgd_mapping(pgd_t *pgdir, unsigned long start, u64 size) >> free_empty_tables(start, end, PAGE_OFFSET, PAGE_END); >> } >> >> -static bool inside_linear_region(u64 start, u64 size) >> +struct range arch_get_mappable_range(void) >> { >> + struct range memhp_range; >> + >> /* >> * Linear mapping region is the range [PAGE_OFFSET..(PAGE_END - 1)] >> * accommodating both its ends but excluding PAGE_END. Max physical >> * range which can be mapped inside this linear mapping range, must >> * also be derived from its end points. >> */ >> - return start >= __pa(_PAGE_OFFSET(vabits_actual)) && >> - (start + size - 1) <= __pa(PAGE_END - 1); >> + memhp_range.start = __pa(_PAGE_OFFSET(vabits_actual)); >> + memhp_range.end = __pa(PAGE_END - 1); >> + return memhp_range; >> } >> >> int arch_add_memory(int nid, u64 start, u64 size, >> @@ -1461,11 +1464,6 @@ int arch_add_memory(int nid, u64 start, u64 size, >> { >> int ret, flags = 0; >> >> - if (!inside_linear_region(start, size)) { >> - pr_err("[%llx %llx] is outside linear mapping region\n", start, start + size); >> - return -EINVAL; >> - } > As discussed, I think something like a VM_BUG_ON() here might makes > sense, indicating that we require the caller to validate upfront. Same > applies to the s390x variant. Sure, will do. > > Thanks! >