From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BE94C43334 for ; Fri, 10 Jun 2022 07:09:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1A5A78D007C; Fri, 10 Jun 2022 03:09:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 156E18D0064; Fri, 10 Jun 2022 03:09:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 01DE58D007C; Fri, 10 Jun 2022 03:09:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id E7CCE8D0064 for ; Fri, 10 Jun 2022 03:09:41 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id B8231C19 for ; Fri, 10 Jun 2022 07:09:41 +0000 (UTC) X-FDA: 79561450962.11.E234074 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf26.hostedemail.com (Postfix) with ESMTP id 97513140073 for ; Fri, 10 Jun 2022 07:09:40 +0000 (UTC) Received: from canpemm500002.china.huawei.com (unknown [172.30.72.54]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4LKBp571kXzRhWY; Fri, 10 Jun 2022 15:06:21 +0800 (CST) Received: from [10.174.177.76] (10.174.177.76) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Fri, 10 Jun 2022 15:09:35 +0800 Subject: Re: [v3 PATCH 1/7] mm: khugepaged: check THP flag in hugepage_vma_check() To: Yang Shi CC: , , , , , References: <20220606214414.736109-1-shy828301@gmail.com> <20220606214414.736109-2-shy828301@gmail.com> From: Miaohe Lin Message-ID: <85932a40-a05b-3610-5836-aab36d2664f0@huawei.com> Date: Fri, 10 Jun 2022 15:09:35 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20220606214414.736109-2-shy828301@gmail.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.76] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1654844981; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=G1dlQgBFwdkBwbFSsGf40XBPBLpoqiopslNmRhp1KQU=; b=DRq5bbcZtO1JfL/aMzMWEdsqlNTRFYBRvCUArrLo2uJ5vRj2Pk2lamwCRagR3BZmEgpIgS n0ttB1t43GWyGUFqP/iMVZ4X9neYgM652uYOdJqXGRmY5eZ5DRwtRSG+lfqyeYyz/tbmPV 7UsixyMDmCS2eZLKEyhlqytZ28ljcv4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1654844981; a=rsa-sha256; cv=none; b=H2XHlu+UwoOQn4g5uCfBXD7/nXxWoihfcqiYKSEXbhsDnQvRPTHJvZrZvV4YyVdrhi7DNy y1Hk4aAa0YJPZVq4qorBvxngk4NNM2d56YgPmmwrcLMKAtOTgBMs7AjnuGn0MHmN3+uohz J/d0U57v3WcpT8GLWL7PJsyJKEn8ZXE= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf26.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com X-Rspam-User: Authentication-Results: imf26.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf26.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com X-Rspamd-Server: rspam03 X-Stat-Signature: 39udcw5unbrm3wb736mdkd469y79cgkc X-Rspamd-Queue-Id: 97513140073 X-HE-Tag: 1654844980-27951 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/6/7 5:44, Yang Shi wrote: > Currently the THP flag check in hugepage_vma_check() will fallthrough if > the flag is NEVER and VM_HUGEPAGE is set. This is not a problem for now > since all the callers have the flag checked before or can't be invoked if > the flag is NEVER. > > However, the following patch will call hugepage_vma_check() in more > places, for example, page fault, so this flag must be checked in > hugepge_vma_check(). > > Signed-off-by: Yang Shi Reviewed-by: Miaohe Lin Thanks! > --- > mm/khugepaged.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/mm/khugepaged.c b/mm/khugepaged.c > index 671ac7800e53..84b9cf4b9be9 100644 > --- a/mm/khugepaged.c > +++ b/mm/khugepaged.c > @@ -458,6 +458,9 @@ bool hugepage_vma_check(struct vm_area_struct *vma, > if (shmem_file(vma->vm_file)) > return shmem_huge_enabled(vma); > > + if (!khugepaged_enabled()) > + return false; > + > /* THP settings require madvise. */ > if (!(vm_flags & VM_HUGEPAGE) && !khugepaged_always()) > return false; >