From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DEBEC433EF for ; Thu, 9 Dec 2021 11:53:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 886476B0074; Thu, 9 Dec 2021 06:53:11 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 836E36B0075; Thu, 9 Dec 2021 06:53:11 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6FE5E6B0078; Thu, 9 Dec 2021 06:53:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay026.a.hostedemail.com [64.99.140.26]) by kanga.kvack.org (Postfix) with ESMTP id 6265F6B0074 for ; Thu, 9 Dec 2021 06:53:11 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 24E5521AB2 for ; Thu, 9 Dec 2021 11:53:01 +0000 (UTC) X-FDA: 78898094562.03.C20AD67 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf30.hostedemail.com (Postfix) with ESMTP id 87E1F80005 for ; Thu, 9 Dec 2021 11:53:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1639050779; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0TYqDLKrFKQnJiMTqk3TD0EmAaxYdybXmgiw3V7bkHY=; b=Ap/qwDeUTyQj+yzssTzH+0vqCHX9t/W0AbQGW+izxrJLw0uTijVuAtRUymbmT/2VI9lMRk I06rzq60c+2KeslMoaky9pxLqmE0cLBWoqdy468oqHLGZ9OAhyIgvHs+BKpbrlbrTxeXss qlG0jItKIc3vAIdDkV54uL14HPJWZ+M= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-1-eLWBEDOsPN-OzimBjxpPgw-1; Thu, 09 Dec 2021 06:52:58 -0500 X-MC-Unique: eLWBEDOsPN-OzimBjxpPgw-1 Received: by mail-wm1-f71.google.com with SMTP id n41-20020a05600c502900b003335ab97f41so2399403wmr.3 for ; Thu, 09 Dec 2021 03:52:58 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=0TYqDLKrFKQnJiMTqk3TD0EmAaxYdybXmgiw3V7bkHY=; b=J39kqmPHn8HduLU7rMhrO14bvq0JFIvGzAhsNITEUQ+wSTVPm3P++k5s4F4yTowJrB yn9bPta/sIF9TEFKOnxQujO5yNbjstrk/EwzXdcm/zggwHaEsHizc7ShSbUtCeGwih7Y jtPJ2lIVxIvt2TYfTfQqLHkpRWnHGdpGXWjbuTwnXsotooJPN8JY4StU1RPspAj09OU2 GoSGeC862FqkY1ujB97D5v6bPMDB4L8i1rKuy0lmzuhaO/LF02e1MoVaYjRMnMU0mE4h 0R1fZsF5/js7fifnOFeW0x+qSDwqGrH3Z1T0h6m1hmuPNFPEThEyrZeuxddqyo5Z2h2s C1IA== X-Gm-Message-State: AOAM532m/9y+pBoxvy3gARSdupJz38Mj92F8+CflHrr/phG3r8qWWS6D Sf5xyJSn6MrkgOvAg1nKcppsfZhBePVwNV4dNis08N3BQzpQ/fDzrqrs0mvlzvLo70RCRZg8i3F UyTjV1v4KyEE= X-Received: by 2002:a1c:448b:: with SMTP id r133mr6687577wma.85.1639050777617; Thu, 09 Dec 2021 03:52:57 -0800 (PST) X-Google-Smtp-Source: ABdhPJyL2rego16YzHim2g10utaFg2hLXRfWqlX4AYNOsaFkm/biENlPxtMps3emSdCNW89UHAze0A== X-Received: by 2002:a1c:448b:: with SMTP id r133mr6687533wma.85.1639050777348; Thu, 09 Dec 2021 03:52:57 -0800 (PST) Received: from [192.168.3.132] (p4ff23ded.dip0.t-ipconnect.de. [79.242.61.237]) by smtp.gmail.com with ESMTPSA id b6sm8982964wmq.45.2021.12.09.03.52.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Dec 2021 03:52:56 -0800 (PST) Message-ID: <858b3185-6770-6c46-5efb-53698c913eec@redhat.com> Date: Thu, 9 Dec 2021 12:52:56 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH v1 2/2] virtio-mem: prepare fake page onlining code for granularity smaller than MAX_ORDER - 1 To: Eric Ren , linux-kernel@vger.kernel.org Cc: "Michael S. Tsirkin" , Jason Wang , Zi Yan , Gavin Shan , Hui Zhu , Sebastien Boeuf , Pankaj Gupta , Wei Yang , virtualization@lists.linux-foundation.org, linux-mm@kvack.org References: <20211126134209.17332-1-david@redhat.com> <20211126134209.17332-3-david@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="Ap/qwDeU"; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf30.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=david@redhat.com X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 87E1F80005 X-Stat-Signature: wsi3nttji3q16935y7moqsxcprg494hp X-HE-Tag: 1639050780-772794 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Eric, thanks for the review! >> if (PageDirty(page)) { >> - virtio_mem_clear_fake_offline(pfn + i, max_nr_pages, >> - false); >> - generic_online_page(page, MAX_ORDER - 1); >> + virtio_mem_clear_fake_offline(pfn + i, 1 << order, false); >> + generic_online_page(page, order); >> } else { >> - virtio_mem_clear_fake_offline(pfn + i, max_nr_pages, >> - true); >> - free_contig_range(pfn + i, max_nr_pages); >> - adjust_managed_page_count(page, max_nr_pages); >> + virtio_mem_clear_fake_offline(pfn + i, 1 << order, true); >> + free_contig_range(pfn + i, 1 << order); >> + adjust_managed_page_count(page, 1 << order); > In the loop, pfn + i, 1 << order are repeatedly calculated. 1 << order > is a step size, pfn + i  is each step position. > Better to figure the numer once each iter? The compiler better be smart enough to calculate such constants once :) > > LGTL. > LGTM. > Reviewed-by: Eric Ren Thanks! -- Thanks, David / dhildenb