From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C270C7EE26 for ; Tue, 23 May 2023 13:14:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AFA406B0074; Tue, 23 May 2023 09:14:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ADCDC900003; Tue, 23 May 2023 09:14:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9C040900002; Tue, 23 May 2023 09:14:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 88A826B0074 for ; Tue, 23 May 2023 09:14:15 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 53612ADF19 for ; Tue, 23 May 2023 13:14:15 +0000 (UTC) X-FDA: 80821563270.25.1C71AE4 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf19.hostedemail.com (Postfix) with ESMTP id 69B621A0175 for ; Tue, 23 May 2023 13:13:45 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=EEwAnJIe; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Xv3rH11f; spf=pass (imf19.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684847625; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bgL1MIRZX3Y+FVWSNOkU++9NMPuYvd0QkuZ4FyLBVfU=; b=gnPEfpSLCtT40LfDpeXn/BbWHLPC5a+sBuR23Ad8VmzdSguueFUDxbjgydNkFeP2s57nHC /25VA7cIj1ZcbbGu90rrIrNtQDFTFrK2zS1EeNdkthqDHBR3jisD0GLmo8mCvJduXlvLfV BLRia1G889MYR45qwHoVmRCdZOz/NcI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684847625; a=rsa-sha256; cv=none; b=TxTB+BS+DwryAllobaWtyMKHUrlQGgSvBOqGkgGsdyxlRwbT8qz6qaWL9yKP9jRIFBbsMk QQuUQXwvgaZCBbuwmfXD7V+8/+QwG1XViYapjkvkXOuLRpaTkTQPQCkYq1MvrrqAiS+u2d ZUHCA7bzbQDhnLBlqN1ACpd6+cOayvc= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=EEwAnJIe; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Xv3rH11f; spf=pass (imf19.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id E931E22AB7; Tue, 23 May 2023 13:13:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1684847623; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bgL1MIRZX3Y+FVWSNOkU++9NMPuYvd0QkuZ4FyLBVfU=; b=EEwAnJIezFPmi/jB0fiajqlAZJHIaxDV0zOANdyOK0hO689bBOzb/mtstSMAicqCiLWpgi VWoRDfh9JktX8kDoVzhMX+5Z7Yhu0Y3fuI6S5Upzq2H1mcROy/h9kdyzxNLHX6CGYpdroW q+ItsLN02lg13wI4KBgfd1VsfG5wYK8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1684847623; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bgL1MIRZX3Y+FVWSNOkU++9NMPuYvd0QkuZ4FyLBVfU=; b=Xv3rH11f9CNEqWknjeqH8ehvmD/QHsE90UXWMIa04KXsgEt4haFtk2+5bTJJ9k28zp5kuR GK2i3+MUcqaFjODQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id CF16713A10; Tue, 23 May 2023 13:13:43 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 6ojXMQe8bGTUPwAAMHmgww (envelope-from ); Tue, 23 May 2023 13:13:43 +0000 Message-ID: <856dbc05-5046-04c8-cf6f-9d0b13e9d229@suse.cz> Date: Tue, 23 May 2023 15:13:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH] mm/mmap: refactor mlock_future_check() Content-Language: en-US To: Lorenzo Stoakes , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton Cc: Mike Rapoport , "Liam R . Howlett" References: <20230522082412.56685-1-lstoakes@gmail.com> From: Vlastimil Babka In-Reply-To: <20230522082412.56685-1-lstoakes@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 69B621A0175 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: pp3tekymxp9qi89qdc6jji1jwjxo6kax X-HE-Tag: 1684847625-655228 X-HE-Meta: U2FsdGVkX197/60OTCBaM+5L+ORiFZWE34bpZeS0LrZ+ANueC2EDD+mtuFPs3IKR2cP4hYvq9xUZqgcrcjoRYu4S0O8Rztx4PaEMS9JN1YQtQ2KO5Tl2dLcnLTsd+9xs0Bunsx8JXkSKE6qvG/an77wqxGYDfYnP5zMZVbAKuYbSEa+2M1tSnLpXmMeEUmD1YKQSzikdBO7xQK96NmazEin6/LWPNYDVBktep6JbvdphiEF7+ZD82QPfViDQHhhV9JWK8cnOPAOAkeVFq+xNRmxGCOEPWHTeRQZbPlp9+YddGrv/c3kwM5vd19hLlxmiNxf18UHo+Du9hbF2WnQOq08wEh+SO8q/EidjeRy4RHVf1PGLlIo0uaRBK1SqtTc2HbWq8MrUPtqUO3p1/MLAh0BFfgWJSRbE7Lex2rpHeCV9r/fRzQ6BDDMUS7jWY1OkKNxXZDn+TM5XWrpI2DXkLMc5y93pwflCOs0IC/Q7o5QVbghHIYDSF8rjPdU4NLWeAaE27IJGswCDeA34YpcY51PrdwAUq26ReUimqwrFe+t4xWFu15Sqjs+iLpOBuSumiCbPq7Xdcgzv01jgDsBMeO/yN77TDI7fHUhVL1PRrf3mT7Jv4aBPOeBI8vSpU1DDGwM+lzn9Q4knXrat+aLiRCM8UvbVaTHLf4rjgQQSySFGxhiMDweSRxB+K1sgt9XuoFa3PFr4WvyjJnCG4VJErga/JFsX1cz7uENFOtda3tjcPL4Xe+CQLbFjbvl2kgmnRmE+ERU68L4sqMYLR0gFWtWfLFz9IB8y1TvcfdNGv5hNLfBbPwweh6CevJuaAtzroR900vB6aVfapiG74QZMOprceSr5DfwoGjPfFOIAwQY+0y0ZwGv/4DzHZBHC51XRMcsG3xvsU0nSac7Dp6QWsJF5uvszPkwUOJg+II92tDrWUfq+Al8rNtXhvVBYc0aO3Jhks5R3FmPw3hfxvFT Y5Wrfc7V nnKxnucbqn7l8mVzWgctqv4AXHGRN/W8WGbJHhrmU7+pm5OfBPAVOCG3sG96hUTigz7UETJHKvP6+1DhhZllH4VbqVs8i+eFhLjEy+7OCWDcTLscD+8aaWRBObwz5mjPj269PlHpBDkZqHprlMW//AAGMt2zX6ZIAEtv7BPupUWXgbXFRVKSNRTvEqZD4Z8pYws7XtbgrJwuadiqN1IypH56QAJjCs+x05rRQ1D691NLVk/NK8trQ8KUaSXQM5zRXrISQOcEd1ykw6TY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 5/22/23 10:24, Lorenzo Stoakes wrote: > In all but one instance, mlock_future_check() is treated as a boolean > function despite returning an error code. In one instance, this error code > is ignored and replaced with -ENOMEM. > > This is confusing, and the inversion of true -> failure, false -> success > is not warranted. Convert the function to a bool, lightly refactor and > return true if the check passes, false if not. > > Signed-off-by: Lorenzo Stoakes Acked-by: Vlastimil Babka > --- > mm/internal.h | 4 ++-- > mm/mmap.c | 33 +++++++++++++++++---------------- > mm/mremap.c | 2 +- > mm/secretmem.c | 2 +- > 4 files changed, 21 insertions(+), 20 deletions(-) > > diff --git a/mm/internal.h b/mm/internal.h > index bb6542279599..66dd214b302a 100644 > --- a/mm/internal.h > +++ b/mm/internal.h > @@ -576,8 +576,8 @@ extern long populate_vma_page_range(struct vm_area_struct *vma, > extern long faultin_vma_page_range(struct vm_area_struct *vma, > unsigned long start, unsigned long end, > bool write, int *locked); > -extern int mlock_future_check(struct mm_struct *mm, unsigned long flags, > - unsigned long len); > +extern bool mlock_future_check(struct mm_struct *mm, unsigned long flags, > + unsigned long bytes); This would have been good opportunity to drop the extern.