From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B472C433F5 for ; Wed, 13 Apr 2022 06:01:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CF7776B0072; Wed, 13 Apr 2022 02:01:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CA6B36B0073; Wed, 13 Apr 2022 02:01:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B6EA16B0075; Wed, 13 Apr 2022 02:01:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.28]) by kanga.kvack.org (Postfix) with ESMTP id A75FB6B0072 for ; Wed, 13 Apr 2022 02:01:26 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id 66461605D3 for ; Wed, 13 Apr 2022 06:01:26 +0000 (UTC) X-FDA: 79350808572.06.408AC99 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by imf14.hostedemail.com (Postfix) with ESMTP id 5F5F710000E for ; Wed, 13 Apr 2022 06:01:25 +0000 (UTC) Received: from kwepemi100008.china.huawei.com (unknown [172.30.72.56]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4KdX0v3s8pzBsLw; Wed, 13 Apr 2022 13:57:03 +0800 (CST) Received: from kwepemm600017.china.huawei.com (7.193.23.234) by kwepemi100008.china.huawei.com (7.221.188.57) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Wed, 13 Apr 2022 14:01:21 +0800 Received: from [10.174.179.234] (10.174.179.234) by kwepemm600017.china.huawei.com (7.193.23.234) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Wed, 13 Apr 2022 14:01:20 +0800 Message-ID: <855ea9f7-5f0a-68a3-eece-6e9c1b27e90b@huawei.com> Date: Wed, 13 Apr 2022 14:01:19 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [RFC PATCH -next V3 1/6] x86: fix function define in copy_mc_to_user To: Kefeng Wang , Mark Rutland , James Morse , Andrew Morton , Thomas Gleixner , "Ingo Molnar" , Borislav Petkov , Robin Murphy , Dave Hansen , "Catalin Marinas" , Will Deacon , "Alexander Viro" , , "H . Peter Anvin" CC: , , , Xie XiuQi References: <20220412072552.2526871-1-tongtiangen@huawei.com> <20220412072552.2526871-2-tongtiangen@huawei.com> From: Tong Tiangen In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.179.234] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To kwepemm600017.china.huawei.com (7.193.23.234) X-CFilter-Loop: Reflected X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: yueixjt71m3ipe4fz84a78hbhx4c86gf Authentication-Results: imf14.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf14.hostedemail.com: domain of tongtiangen@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=tongtiangen@huawei.com X-Rspamd-Queue-Id: 5F5F710000E X-HE-Tag: 1649829685-264806 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: 在 2022/4/12 19:49, Kefeng Wang 写道: > > On 2022/4/12 15:25, Tong Tiangen wrote: >> X86 has it's implementation of copy_mc_to_user but not use #define to >> declare. >> >> This may cause problems, for example, if other architectures open >> CONFIG_ARCH_HAS_COPY_MC, but want to use copy_mc_to_user() outside the >> architecture, the code add to include/linux/uaddess.h is as follows: >> >>      #ifndef copy_mc_to_user >>      static inline unsigned long __must_check >>      copy_mc_to_user(void *dst, const void *src, size_t cnt) >>      { >>         ... >>      } >>      #endif >> >> Then this definition will conflict with the implementation of X86 and >> cause >> compilation errors. > Does powerpc need this define? Oh, missing that, will do next version. >> >> Fixes: ec6347bb4339 ("x86, powerpc: Rename memcpy_mcsafe() to >> copy_mc_to_{user, kernel}()") >> Signed-off-by: Tong Tiangen >> --- >>   arch/x86/include/asm/uaccess.h | 1 + >>   1 file changed, 1 insertion(+) >> >> diff --git a/arch/x86/include/asm/uaccess.h >> b/arch/x86/include/asm/uaccess.h >> index f78e2b3501a1..e18c5f098025 100644 >> --- a/arch/x86/include/asm/uaccess.h >> +++ b/arch/x86/include/asm/uaccess.h >> @@ -415,6 +415,7 @@ copy_mc_to_kernel(void *to, const void *from, >> unsigned len); >>   unsigned long __must_check >>   copy_mc_to_user(void *to, const void *from, unsigned len); >> +#define copy_mc_to_user copy_mc_to_user >>   #endif >>   /* > .