From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12A8FC761A6 for ; Thu, 30 Mar 2023 15:07:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6FA2F6B0072; Thu, 30 Mar 2023 11:07:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6AA126B0078; Thu, 30 Mar 2023 11:07:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 571826B007B; Thu, 30 Mar 2023 11:07:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 456CF6B0072 for ; Thu, 30 Mar 2023 11:07:38 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 15F8D1C65B0 for ; Thu, 30 Mar 2023 15:07:38 +0000 (UTC) X-FDA: 80625893796.17.1591F39 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf19.hostedemail.com (Postfix) with ESMTP id 2D5731A0017 for ; Thu, 30 Mar 2023 15:07:35 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=g10T3wwD; spf=pass (imf19.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680188855; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=flEdophtYQM+tpSiaQIdRAJlRLOhJGfz1jgwJJ1BJnE=; b=iYh2YXDb4Un2as5s+teaW3QPDGVAJbCn1Ei90uF8+3TLhrsvbjc5XSjTLMaPJDcdQ0RMqw pRGLPw9kwJO/7EeUcQM3FHqUObihF/a5vHtrgzGkI/LroRzVBuJBccILMefD1AvShBQFtD M3P+Uk0MgbTqCrVyR+RUuG7x/1IDSfU= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=g10T3wwD; spf=pass (imf19.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680188855; a=rsa-sha256; cv=none; b=m5nhFAlZvevCj5GLWnrSzDZ8fh1uHsMBY/c43bUgpcApVfXHF3/gL0csEwMMIP1/Hf7ZRn J0eP12EGGxEfwWTvpzX6zzBDaKxyeu43Q0kyRks2tRKaZW8/JlIRgP0zi/6roYRn6RQ4+M DBMao0Y1gm7OiAWm9IP491MCAZLr3QI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680188854; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=flEdophtYQM+tpSiaQIdRAJlRLOhJGfz1jgwJJ1BJnE=; b=g10T3wwDruXdnlkKgEFpDR8aIsiTtwSvJ7fTgipLiCmjav2FFrGtL/B2jcn6/zVFV/qdp8 4Amk+nYMW1M12SUJjBMra2DGtNP4UBLksZlxd1PjPMH/5PDe/0CAaaFpWfIl3V0Vyq7QHI Ff4p8mK/+lGAs2+fpRHvGHXgQMinbaY= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-654-dFQTAMfoPD2U4QyvYcJNIw-1; Thu, 30 Mar 2023 11:07:28 -0400 X-MC-Unique: dFQTAMfoPD2U4QyvYcJNIw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8D419858297; Thu, 30 Mar 2023 15:07:27 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id 938B4C15BA0; Thu, 30 Mar 2023 15:07:25 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <64259c7b2b327_21883920818@willemb.c.googlers.com.notmuch> References: <64259c7b2b327_21883920818@willemb.c.googlers.com.notmuch> <20230329141354.516864-1-dhowells@redhat.com> <20230329141354.516864-5-dhowells@redhat.com> To: Willem de Bruijn Cc: dhowells@redhat.com, Matthew Wilcox , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Al Viro , Christoph Hellwig , Jens Axboe , Jeff Layton , Christian Brauner , Chuck Lever III , Linus Torvalds , netdev@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [RFC PATCH v2 04/48] net: Declare MSG_SPLICE_PAGES internal sendmsg() flag MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <854581.1680188845.1@warthog.procyon.org.uk> Date: Thu, 30 Mar 2023 16:07:25 +0100 Message-ID: <854582.1680188845@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: iuktnbygeru69xbsfifd7edijzwri57p X-Rspamd-Queue-Id: 2D5731A0017 X-HE-Tag: 1680188855-102781 X-HE-Meta: U2FsdGVkX1+M4x2QQYKXK7F+jMZG7Wyrko9OMDbZpon8wVZSafK1cGTKt7KBiVn3jyOE5VeOR3gUd3BVSW5DSQdG2wJKc4maJwb5BgU4m1Q0nP0Wt8WnUp0ofvPJJ+WPZcgHkSm3tQ7q30hXC2098XlSlD3RrM9pi1Uk6E5oH0HboO+WvgRaem+v7UoAVqRHNt7+0kqbrvi5WuvBtBQ5LAg19ZEuwI20NV1F2ZYxhXuKE9jI27ezTq7zVZEE+13oCtfj1lt0s5UvaSOeNCI5q+8Mcb0XbhFkPTPUEN5TumibhrdUItOc+WNPJ2lRRGlziuhyn7TCVEXozKVLXKc66Ylb5a/UzopaQFYdQlkPC1tnhH/Xx1xBNPVFYuQA9cxT7PEDf5gBCgnmpgDEt1FXu82Nv9gmyj9wz7tRwlLR59AWPWhQnLGkv6oMxA0laU4lhH/FjeZ8FloqjcFxNvhBbd48EDi7dLTs/fzhtx2bugj63gDbYqyCCJPRGWI2ZSBBSaXV4s/BP/F2LO3qRw32324eXT4ZOFrDadt2AztDfurpKvGHd578XNKaO8wNrxmPU4+UUdNfPZ/5VS8nxdEz7WxQR+mZfdLrteRCSF0HCXbrvL0fs+7a0JHbI/8Ta3U5bBvxpCiFt7xf/zWlDXB5oDBHh/3GDZ1KcErkyamres29hyQ/UVJE1x3iqWJstpW4QifgiO8pFM/tD4Q2uSXUmBjcicrzGC+SVOecrawfk9/7m8T6qhB2kQBGebXjkwDMr0VYDcU16Mm590qa8AbL2LWxcpNZ+M4rpV2QZJWv7TH+OiIC3f30be6q2Y5+7QPqXw49c5+SqjQw742/FNqoThdhwAIiU+5aKd7jp+QKqNSsh7NGQ22ZiEBHzLeP36OXXmq3XfdTPSTKVz/ARaV+CoZbObPFVTy2/0IdKCdQz/5kTCCZ4+tOuIlWNvr99IBd7kzboJv22SNRFkmej6v RS3HjVrg KVoC47isi3Oh+ty4aJ+KUq5hRVLUYlynM1QZpSDEiWwgC90usMVYJ3d7PKCetQj9zv0sZRtRAw3p/XHuj0iQWri8iIsCXk2stbGyZhHNA6tu3Mn0LecXEq07EzRLBFmA9B09xA785C4hY7yRMt0QkWxgm1cyjnfy/H936nmCMZsJ2NIpa3aYsmBV1FdvfFwVoUCkmVd9mEVJFXx7vH/AWfefi1Q6qQRmS7eMEgzVE5zAEgPLf+LTMtLZL8zhmcSQTllAXp3wwbHADVfFN5wlfMc91oMsTAqN4bikJU13axXJ9AF95PAiLVDQY0/cPHgEAvTAc X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Willem de Bruijn wrote: > No need to modify __sys_sendmmsg explicitly, as it ends up calling > __sys_sendmsg? > > Also, sendpage does this flags masking in the internal sock_FUNC > helpers rather than __sys_FUNC. Might be preferable. I was wondering whether other flags, such as MSG_BATCH should be added to the list. Is it bad if userspace sets that in sendmsg()? AF_KCM, at least, looks at it. David