From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31581CFA76E for ; Fri, 4 Oct 2024 11:46:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 715866B00A9; Fri, 4 Oct 2024 07:46:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6C5DC6B0188; Fri, 4 Oct 2024 07:46:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 565CB6B0189; Fri, 4 Oct 2024 07:46:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 38B026B00A9 for ; Fri, 4 Oct 2024 07:46:23 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 6417F81781 for ; Fri, 4 Oct 2024 11:46:22 +0000 (UTC) X-FDA: 82635741804.15.09A2C41 Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by imf12.hostedemail.com (Postfix) with ESMTP id D3D314000A for ; Fri, 4 Oct 2024 11:46:18 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=samsung.com header.s=mail20170921 header.b=uqBjPwou; spf=pass (imf12.hostedemail.com: domain of m.szyprowski@samsung.com designates 210.118.77.11 as permitted sender) smtp.mailfrom=m.szyprowski@samsung.com; dmarc=pass (policy=none) header.from=samsung.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728042206; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OeqSxL0GgxswWPe88tZUDP7FJMEdHJjkwdrJT+0N+Z4=; b=6k690/0W0ZLsB2D8o1p/vpcZXmWzh0x2S0Ijnu6L9NKusAUExhi7TmRDFTLQBIpBoS0R4P h8k7+UUF2N+DXFXo1jZeOOs9rsFFDTpjHdVS3Oo8UMtLMr9hiuHXnm1vOPyhIZJZhFbrQS mmm/1dixziK/0ATKsiH22Wxfn9C416Y= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=samsung.com header.s=mail20170921 header.b=uqBjPwou; spf=pass (imf12.hostedemail.com: domain of m.szyprowski@samsung.com designates 210.118.77.11 as permitted sender) smtp.mailfrom=m.szyprowski@samsung.com; dmarc=pass (policy=none) header.from=samsung.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728042206; a=rsa-sha256; cv=none; b=JOzQdTWNbT8n/RhPkE6yhTrPNwFm4kYJdA2dr+JL9uqjqYY3EAEE5r4ML6HhG3axpKH9Jw PEnJKk2mRBTgEe4tZfW7QOn4vbCMBUXmsaFp+25Np2g1FGudGSURiAWFu75cszhZvsbybp kacabsFirHJbXcSlVhwuiXqj3Qh9lbI= Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20241004114616euoutp01f8d1095e901ab03c4d10462f33da3998~7PWLEHgkW2420524205euoutp01E for ; Fri, 4 Oct 2024 11:46:16 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20241004114616euoutp01f8d1095e901ab03c4d10462f33da3998~7PWLEHgkW2420524205euoutp01E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1728042376; bh=OeqSxL0GgxswWPe88tZUDP7FJMEdHJjkwdrJT+0N+Z4=; h=Date:Subject:To:Cc:From:In-Reply-To:References:From; b=uqBjPwouMytMwHrY0tVKsguCZpFn/DkAtuzes3fCoYPcVtw6YEdf9Joz797SzxpFj viY0aDBEmrMk5qYy4jDKaatQUo5bbOdFeIudOCF8IY/EPpf6DfKqTWilRZX6yu5ySs hSxy0Sm2161ZClJOxLrJhA2tECi4rpnnTFx71C+w= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20241004114616eucas1p2955add576b99f8294ca19d25de4466a3~7PWK85Ijc2554725547eucas1p2D; Fri, 4 Oct 2024 11:46:16 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id CB.9F.09875.885DFF66; Fri, 4 Oct 2024 12:46:16 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20241004114615eucas1p1910b6b4e74f8a878f56104026eece731~7PWKmzi8v0267602676eucas1p1Z; Fri, 4 Oct 2024 11:46:15 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20241004114615eusmtrp2f46993bc0497d036f5b37a16abf4a129~7PWKmLF-x0990309903eusmtrp2m; Fri, 4 Oct 2024 11:46:15 +0000 (GMT) X-AuditID: cbfec7f4-11bff70000002693-7b-66ffd5881884 Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id E5.C2.14621.785DFF66; Fri, 4 Oct 2024 12:46:15 +0100 (BST) Received: from [106.210.134.192] (unknown [106.210.134.192]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20241004114615eusmtip20ddfbc45ec5dfe2abae4ad37ecbb88e3~7PWKOwBeh1524715247eusmtip2F; Fri, 4 Oct 2024 11:46:15 +0000 (GMT) Message-ID: <853a1b27-8c74-4fd1-9186-1c0c1378a8ef@samsung.com> Date: Fri, 4 Oct 2024 13:46:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/5] mm: Add PageAnonNotKsm() To: "Matthew Wilcox (Oracle)" , Andrew Morton Cc: linux-mm@kvack.org, Alex Shi Content-Language: en-US From: Marek Szyprowski In-Reply-To: <20241002152533.1350629-5-willy@infradead.org> Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupkleLIzCtJLcpLzFFi42LZduzned2Oq//TDA6sEbCYs34Nm8Xyu4/Z Le6t+c9q8fvHHDYHFo/NK7Q8Nq3qZPPY9GkSu8eJGb9ZAliiuGxSUnMyy1KL9O0SuDKOHjjA WHBaoGLSitWMDYw3ebsYOTkkBEwkmm4eYupi5OIQEljBKLH29yM2kISQwBdGiTuLtSASnxkl XnWdZYPpeNixnBUisZxRYuOKR6wQHR8ZJb5vSwOxeQXsJFrfHQaLswioSDzqOMEOEReUODnz CQuILSogL3H/1gywuLCAocT2oysYQWwRgQSJGwsegsWZBYwlmjfdZoSwxSVuPZnPBGKzAdV3 ve0CO4hTwFri9a57LBA18hLb385hBjlOQmAPh0TrskWsEFe7SBxsW8YEYQtLvDq+hR3ClpH4 v3M+E0RDO6PEgt/3oZwJjBINz28xQlRZS9w59wtoHQfQCk2J9bv0IcKOEvv6n4CFJQT4JG68 FYQ4gk9i0rbpzBBhXomONiGIajWJWcfXwa09eOES8wRGpVlIwTILyZuzkLwzC2HvAkaWVYzi qaXFuempxUZ5qeV6xYm5xaV56XrJ+bmbGIGp5fS/4192MC5/9VHvECMTB+MhRgkOZiUR3nnb /6YJ8aYkVlalFuXHF5XmpBYfYpTmYFES51VNkU8VEkhPLEnNTk0tSC2CyTJxcEo1MG3saZn2 Yx/3ruunrpf3hd077bHvRNjrrQoLHgd9DVEMYT6yuFTq7ck4heofJ6cdFPdxeMVw0mX+ptvJ f37qTJx2LOiyvyOXyDS9A2lS6jNVbonK/dz3xkq9+YzFDJE9AezTquvjaqTd6kN3bGBivh2W 9unUT/e1k1pu252wbZPW4F+cMuGOldV9S8sDD0Wf3zggcE65RVMxNEfffcbp2TGb3TmU/395 1SV/aQbfO7el+Ucl6gJZt39XSfqRvLO9IcKXiW+17QyxxdfOq3DLzOxL/XBr1oQZ7a5nKwQf HZzU53BmDSdb2tacNUdLT16eecnwzueTfrlBSk3z1uvUyv2907KzcpvzhQUFhTe53vArsRRn JBpqMRcVJwIAbnP7gpwDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprNIsWRmVeSWpSXmKPExsVy+t/xe7rtV/+nGbQ+NbaYs34Nm8Xyu4/Z Le6t+c9q8fvHHDYHFo/NK7Q8Nq3qZPPY9GkSu8eJGb9ZAlii9GyK8ktLUhUy8otLbJWiDS2M 9AwtLfSMTCz1DI3NY62MTJX07WxSUnMyy1KL9O0S9DKOHjjAWHBaoGLSitWMDYw3ebsYOTkk BEwkHnYsZ+1i5OIQEljKKPHrzi82iISMxMlpDawQtrDEn2tdYHEhgfeMEvvW5YLYvAJ2Eq3v DoPVsAioSDzqOMEOEReUODnzCQuILSogL3H/1gywuLCAocT2oysYQWwRgQSJaXMPgc1kFjCW aN50mxFifrbE01lL2SHi4hK3nsxnArHZgHq73kLcwClgLfF61z0WiBozia6tXYwQtrzE9rdz mCcwCs1CcsYsJKNmIWmZhaRlASPLKkaR1NLi3PTcYkO94sTc4tK8dL3k/NxNjMBY2nbs5+Yd jPNefdQ7xMjEwXiIUYKDWUmEd972v2lCvCmJlVWpRfnxRaU5qcWHGE2BYTGRWUo0OR8YzXkl 8YZmBqaGJmaWBqaWZsZK4rxul8+nCQmkJ5akZqemFqQWwfQxcXBKNTCFTZOedWbWtlv5jr91 csNC3rB87BY65GUXqfCBd8q3tPf5h6TL/6uYaXYdNnbfrX5ZYX/2njfPJtTWbloUp/HxbZF+ G5u7k8+b1hYOafObSc47l815m3fZ7uy88h5jTfmsxOA3ft0H7F+EPzGfk6/L8pmLrejTsTTn 7RsXL73w4adF5YzZJ/6Ezvq+94U8o/7cu96T/vC5v6hn3PbhfvhandeGLPu9S2qM3Je9/HSu ZUuySFAJe4Ayr12Uk+alI2vkqlw3RS84xvbUzlL3w7xvHFd+nZ0splv/O8T9swi/Vz+De/yW a/XbL3T19ndLzYqpVzbaZPpmx4XK627VxtJC/q9cV10vmlty++nHVe5KLMUZiYZazEXFiQBb gFBlLgMAAA== X-CMS-MailID: 20241004114615eucas1p1910b6b4e74f8a878f56104026eece731 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20241004114615eucas1p1910b6b4e74f8a878f56104026eece731 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20241004114615eucas1p1910b6b4e74f8a878f56104026eece731 References: <20241002152533.1350629-1-willy@infradead.org> <20241002152533.1350629-5-willy@infradead.org> X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: D3D314000A X-Stat-Signature: tw3bingiq1yg5a6qyy8ko91a6qacnk34 X-Rspam-User: X-HE-Tag: 1728042378-113743 X-HE-Meta: U2FsdGVkX19lNoXOEJi0phKMPytCBVWUSDYKMPSAkunTDVgih8rRIw9ASF+u68Cypw156VJIEJwk9BjPx5xiCYYJungo3w/Hjp6SPRCIVKToNQEZQ96gCXo6mImWAjvzDmWps75aYZaE/RGH86ZN58SOy/ks2FNK/YFJFULzssutCNujOKTQ/JHxQCwhrJGhW+rNjwk/Hfn9OksD2cafscqRF3E01cXqijfwPTav1Sy7QTMSqp6Ea49/heVzaTlJJI6x6HzAyDh4hB67RevlQxgs+meEUOauD42L5jaBHzuTn2B3ChJEpMJYOKuAvUi1Ssy4D2s1EwE8mMXiNQwxrxPW8TB/sQMLHyh6HZoqOMwiKopRmwqMNQa1i2iPqbTRv0KsscyArEtfr+LufpxKXzLx3VVa/+cUoOxpvPHifPBPxshV8KGpuPzOapwQLU2nIvrl1dDUjV429LvnMmLBT1wNZvnvnNVtEejq9PUX8fM6EAxLX8f19RasJDY+7eziX7tICE0LZazQaAbH8UGsLLTC37RyzP5+7vYH6/ezn8Ugw2WUa5NKQVmK2nVziT6aFr/JXrQzX/JYCY76xXy8mKguHJdONDAQeDjAodzsbFFGPLITGlCjypwyiB6UrW8NFObYFL+YkjGL+7WEkLbNm/MT2kbinlOGECWoup2MHO4Er7Aoq40+SPGFutf/+jTYqTkGr0dMqocKbzoLRa5ym47pqQV3IUp8qnNlzph7VZ6XhYhXql/4LXDwNa8/HBV8R67y7FbI4j0D8S5S6OnipLT/WNHk3mwLZFdKEVWIIa82yL4LMvk1F7rAaGnh47Ye/yh46QIA/hlvi4GMv7gPeEAbGsIn7kMszu0p6lNK5sJmcxCb5qjnqUQz90rn1hCOoQh64iQik1EG1kYXKxFWiB8qUZrEfhFSaWpcW8xFe7v4zLUJZR2tzEJ1S5A3FjfzoCxa4jTtubjibt88kLW KPq9Gu5w J9MNSTQPrxWiUuHhWIEWgRHCt7ODRqUeFQTiVVN9DMrGz4V1mSEQx+eMf//PDruMj/naCCJq0w7um8kK5hzNtkQziTynpzo/FxRachrkq54I+C5uBQsZS+j1ciLsI4WAAUXZw X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 02.10.2024 17:25, Matthew Wilcox (Oracle) wrote: > Check that this anonymous page is really anonymous, not > anonymous-or-KSM. This optimises the debug check, but its real purpose > is to remove the last two users of PageKsm(). > > Signed-off-by: Matthew Wilcox (Oracle) > --- > include/linux/page-flags.h | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h > index 4c2dfe289046..157c4ffc2fdc 100644 > --- a/include/linux/page-flags.h > +++ b/include/linux/page-flags.h > @@ -689,6 +689,13 @@ static __always_inline bool folio_test_anon(const struct folio *folio) > return ((unsigned long)folio->mapping & PAGE_MAPPING_ANON) != 0; > } > > +static __always_inline bool PageAnonNotKsm(const struct page *page) > +{ > + unsigned long flags = (unsigned long)page_folio(page)->mapping; > + > + return (flags & PAGE_MAPPING_FLAGS) == PAGE_MAPPING_ANON; > +} > + > static __always_inline bool PageAnon(const struct page *page) > { > return folio_test_anon(page_folio(page)); > @@ -1129,14 +1136,14 @@ static __always_inline int PageAnonExclusive(const struct page *page) > > static __always_inline void SetPageAnonExclusive(struct page *page) > { > - VM_BUG_ON_PGFLAGS(!PageAnon(page) || PageKsm(page), page); > + VM_BUG_ON_PGFLAGS(PageAnonNotKsm(page), page); !PageAnonNotKsm(page) ? At least such change fixes booting of today's linux-next with debug enabled on RISC-V based boards. > VM_BUG_ON_PGFLAGS(PageHuge(page) && !PageHead(page), page); > set_bit(PG_anon_exclusive, &PF_ANY(page, 1)->flags); > } > > static __always_inline void ClearPageAnonExclusive(struct page *page) > { > - VM_BUG_ON_PGFLAGS(!PageAnon(page) || PageKsm(page), page); > + VM_BUG_ON_PGFLAGS(PageAnonNotKsm(page), page); ditto > VM_BUG_ON_PGFLAGS(PageHuge(page) && !PageHead(page), page); > clear_bit(PG_anon_exclusive, &PF_ANY(page, 1)->flags); > } Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland