From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C333AC4345F for ; Mon, 15 Apr 2024 19:14:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 599886B008C; Mon, 15 Apr 2024 15:14:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 549E36B0093; Mon, 15 Apr 2024 15:14:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3C3FC6B0096; Mon, 15 Apr 2024 15:14:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 18AB06B008C for ; Mon, 15 Apr 2024 15:14:14 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id D11FBC0794 for ; Mon, 15 Apr 2024 19:14:13 +0000 (UTC) X-FDA: 82012716786.23.18CC9D6 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf23.hostedemail.com (Postfix) with ESMTP id E316F140010 for ; Mon, 15 Apr 2024 19:14:09 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=grW3yyjz; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713208451; a=rsa-sha256; cv=none; b=AcKDR1ecpjiToGbbq/gSMunuDFF4xbCSfWX0zUXV8mDTpQHDYHDHTB7yyHtN6fuuTDaTtR aY5fevZZ0y/1oBAlVXnPqIbtk3v+9sRCySkUbady6VD5TbMQWHqyKys7hFw7Ryb7aoYGMz L97PTohChI7qOXizOOHKLnl/QkYxYG4= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=grW3yyjz; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713208451; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bMAt0oAbaTmcnLSElf/SBdLJ4dVXqKvD9eBFf4mhfOU=; b=YEJaL5ZGXdnQ/5NrFQrOLSo1UipVHOfF4FT8SFq+kZqLG4WRB6lRVzSNNrP9ZQTU09IFyR uRkz+/SKpi1nT4MksrnE9loVRIaek4ggSY3wM2lgAHW1QFgXmsi2OI5RwVshzuI2nLXtRr 9uq7hSpr+FZsl7bpnU1KqDJ+RfIeZI8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1713208449; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=bMAt0oAbaTmcnLSElf/SBdLJ4dVXqKvD9eBFf4mhfOU=; b=grW3yyjzP0t0UJdzgTB2JscrbnGLaO1EiIOQnJvgfP60Und3DWqMEFnEjItJnXYVc40wF0 fL2qG+cdAGXUbWeED4aQ8kkBmH8Gc1Thqcjp69WRAMhXkWb2AGSC2n6tjOJf2j2o+v5C0I H0ur7SJO53zUYS3zSm17H51PczagUak= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-617-vwQAymppMJWYv0SvNr6-qQ-1; Mon, 15 Apr 2024 15:14:06 -0400 X-MC-Unique: vwQAymppMJWYv0SvNr6-qQ-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-41634d6c008so11781585e9.1 for ; Mon, 15 Apr 2024 12:14:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713208445; x=1713813245; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=bMAt0oAbaTmcnLSElf/SBdLJ4dVXqKvD9eBFf4mhfOU=; b=eWtW4AysjrDF4c/Aa2h2rz2RtNWzMvZ5NY4hDmMbrSdgJYlFD9mB3LZNqTo3aKmLc6 ceYiVBcxRVMrk4oOsfDggu9CD7uToyHPL7+iiwnnswdU84cnn64li55FOV8ZHymK1Qbf n46Qv4+2Am5jm7U3ly9N5mwEylZeTkusaWXPGQvsyOd371+j/Untu7rFuAIGD3Fc2qKG 7dB2zDuBO3BzUOhmCFJ0dCMq8qFlKo2lGlVeC5ynfqGaGaMReOKnyVnpc6tv79RSbqJR kId0VMz7R7ArfUi2LLgtIKzuecm7p4TOx2Q4Asn0HY8/vfiXmOSC1+oQ8bEvo3jBvzb7 G6tA== X-Forwarded-Encrypted: i=1; AJvYcCVHWxbrMgmI/zJSXW8JaYv5a4Y5Uk5024K4LXvsZU+High1W/Y5IMu8wWM4ZYmM3uoPcITsN3SIzU8nRGBQTozKZZY= X-Gm-Message-State: AOJu0YwOilQrfBDHNmOF6gScrxQRtr4gErxGh+bB5ieB7CmY7dxsVq5h VdBr0LI2DGU8m0iVijCY+ol7t+5kuPNuTivBSzmfRWvjuseZhwvytYdRHVtTqt+3hTN6ORAMc40 WNrPX4cDPBs96dfGyFr4yRpN3qWlwGtGEyUo92Oydjh1RAJ/y X-Received: by 2002:a05:600c:4ed4:b0:417:caa8:c3f4 with SMTP id g20-20020a05600c4ed400b00417caa8c3f4mr9281084wmq.34.1713208445573; Mon, 15 Apr 2024 12:14:05 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHNACX+5g4v7h9bZKcNb840TnSltslTev61FDz0PyU5OepqWDJ4QOJiQHGkHdSUyQUaUBHVTw== X-Received: by 2002:a05:600c:4ed4:b0:417:caa8:c3f4 with SMTP id g20-20020a05600c4ed400b00417caa8c3f4mr9281051wmq.34.1713208445135; Mon, 15 Apr 2024 12:14:05 -0700 (PDT) Received: from ?IPV6:2003:cb:c706:d800:568a:6ea7:5272:797c? (p200300cbc706d800568a6ea75272797c.dip0.t-ipconnect.de. [2003:cb:c706:d800:568a:6ea7:5272:797c]) by smtp.gmail.com with ESMTPSA id s12-20020a05600c45cc00b00417e8be070csm15550664wmo.9.2024.04.15.12.14.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Apr 2024 12:14:04 -0700 (PDT) Message-ID: <8533cb18-42ff-42bc-b9e5-b0537aa51b21@redhat.com> Date: Mon, 15 Apr 2024 21:14:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/2] s390/mm: re-enable the shared zeropage for !PV and !skeys KVM guests To: Alexander Gordeev Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Christian Borntraeger , Janosch Frank , Claudio Imbrenda , Heiko Carstens , Vasily Gorbik , Andrew Morton , Peter Xu , Sven Schnelle , Gerald Schaefer , Andrea Arcangeli , kvm@vger.kernel.org, linux-s390@vger.kernel.org References: <20240411161441.910170-1-david@redhat.com> <20240411161441.910170-3-david@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: E316F140010 X-Stat-Signature: qfsspu36ctrkhbstzmpwakwh5zwrmgm9 X-Rspam-User: X-HE-Tag: 1713208449-670397 X-HE-Meta: U2FsdGVkX1/cQIa0ytN8T5GUyMzwKUJaLlQy5GxEolSuLMy3k9I7HF2wxtQZLpv5NdK/SKSgjQNT2W7Pht6QBUcrc3o9cPLEd1Pq+SBxy+ag7ikjNSFmzdKMfrFA+DF7396ZnKwkeYX7XFJtG0HD4XBtNbesAk9nHw05HP6mZWzK+8v/7rT/QQ+fazH2GW+C4eECFrz32JyJxDabc0BRWYbVyhAjTw7A5fnMQLROSTBgTvsbokHsG3PEx9osrtQu4ywW8eI0HaE+zdwHD+fZLB588ltxQW81q0fozwSAwJUBrl3JDhI/3dqvOzztWn7NcxfKDDeDf4ylVL+2rfaGaiHrgJknFPwMIVmJxip7KPsHqnH8sCduxxhhB/EC3vTpITSlx9OEITykX1chj5G6lwo0afBmsLr0GGR539cMH4loRKrW+Jp2d3gOp3fOCA6DTS516GOkHOeJ+5cuYPIwtxf09BqIiWJaNvo8FPfCT441tzmck4OYI8xoWJVTxEMcIA1IZFzsuRguD3ea3nwU5SQgm5ZIWb6Zooq+nwd7++647on8CpgnrM7OgcwwCOC1n2gNwI4E+2c8xaMnhO21GqWm9WyQqapM9lSKav3Ngin29kqCVQsQvpnJuUW21XE3PtUsP5GclA8Uctgz/0acUTmI/1fNbJtSJWyznjVen6/A78OzrZ8y+gWMtmW2wuUc0bhZD41MhmGd8dxnuV5jYaOpAorbLEf/L8qUrgbQj+O6/n0qlQMB37wrbNIIKa0OLIexSKA3r8MvNtMMCZ9R3P1z2uJQY/skB7zdU56FkzDNLQsIlUKlcIF2xOGyqqDwpJpPW9TbFTfWqZMMOid9Voc77SEVRE4xM40LE3dFaLYmS271hECK7n1Z2FYH8RuBgC4gHNQF2Fapadi8ZEMbYzqeWzVXTpfokA5CvRIDzY5AUwWvyRIzuDohEE9EarKYn0wNEgMKQHW9a6elw+Y 4rS6AU74 Uxc/jZZ+vJWPPD8AMNGNw2pWdZd21d8kqmkUCnHKTk4FeijbQH1cLT+COIxbvB1Y9XRxp8FuKfalbI4Rg/PXAyqBVyN+6+pG7Brua+NiIsoyU6qpcdJomcZ6ErMRvFxAERYuBs0eNFTn8cs8PIJBfKFczfB5VNEoqfma+oopes7EWi3f+CjDySVGgaSQfJJfz6hv/cAgBuWOBXvz3UjSk76JuGt5WZHs8k7nS16qfHIxW/k1ud0yg3YsmKomQvYm3qvr5rK0XGB0ASwOAYAvdsNtdsxypsR7PCb83eItLiItt7PSdbSKw9q2m8mEtbjoe7u2Eh+xOUO/Ni/4xGR1l23gT7r1OQ+KmlaBtmA1Q11dCM+kPmcxDfwEvgwlVo+G5tc20Agt7JJSgHub+ZbkPBh5Zx/daXpCc7BrRKbb8X9c9XyT5xFZLU9v4VMTTa+ULGuwx4LpMwvezuTh7ODygc29QDik14JTjGh0vIyc1oJUQi1M= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 15.04.24 20:24, Alexander Gordeev wrote: > On Thu, Apr 11, 2024 at 06:14:41PM +0200, David Hildenbrand wrote: > > David, could you please clarify the below questions? Sure, let me take a look if we're still missing to handle some corner cases correctly. > >> +static int __s390_unshare_zeropages(struct mm_struct *mm) >> +{ >> + struct vm_area_struct *vma; >> + VMA_ITERATOR(vmi, mm, 0); >> + unsigned long addr; >> + int rc; >> + >> + for_each_vma(vmi, vma) { >> + /* >> + * We could only look at COW mappings, but it's more future >> + * proof to catch unexpected zeropages in other mappings and >> + * fail. >> + */ >> + if ((vma->vm_flags & VM_PFNMAP) || is_vm_hugetlb_page(vma)) >> + continue; >> + addr = vma->vm_start; >> + >> +retry: >> + rc = walk_page_range_vma(vma, addr, vma->vm_end, >> + &find_zeropage_ops, &addr); >> + if (rc <= 0) >> + continue; > > So in case an error is returned for the last vma, __s390_unshare_zeropage() > finishes with that error. By contrast, the error for a non-last vma would > be ignored? Right, it looks a bit off. walk_page_range_vma() shouldn't fail unless find_zeropage_pte_entry() would fail -- which would also be very unexpected. To handle it cleanly in case we would ever get a weird zeropage where we don't expect it, we should probably just exit early. Something like the following (not compiled, addressing the comment below): From b97cd17a3697ac402b07fe8d0033f3c10fbd6829 Mon Sep 17 00:00:00 2001 From: David Hildenbrand Date: Mon, 15 Apr 2024 20:56:20 +0200 Subject: [PATCH] fixup Signed-off-by: David Hildenbrand --- arch/s390/mm/gmap.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/arch/s390/mm/gmap.c b/arch/s390/mm/gmap.c index 9233b0acac89..3e3322a9cc32 100644 --- a/arch/s390/mm/gmap.c +++ b/arch/s390/mm/gmap.c @@ -2618,7 +2618,8 @@ static int __s390_unshare_zeropages(struct mm_struct *mm) struct vm_area_struct *vma; VMA_ITERATOR(vmi, mm, 0); unsigned long addr; - int rc; + vm_fault_t rc; + int zero_page; for_each_vma(vmi, vma) { /* @@ -2631,9 +2632,11 @@ static int __s390_unshare_zeropages(struct mm_struct *mm) addr = vma->vm_start; retry: - rc = walk_page_range_vma(vma, addr, vma->vm_end, - &find_zeropage_ops, &addr); - if (rc <= 0) + zero_page = walk_page_range_vma(vma, addr, vma->vm_end, + &find_zeropage_ops, &addr); + if (zero_page < 0) + return zero_page; + else if (!zero_page) continue; /* addr was updated by find_zeropage_pte_entry() */ @@ -2656,7 +2659,7 @@ static int __s390_unshare_zeropages(struct mm_struct *mm) goto retry; } - return rc; + return 0; } static int __s390_disable_cow_sharing(struct mm_struct *mm) -- 2.44.0 > >> + >> + /* addr was updated by find_zeropage_pte_entry() */ >> + rc = handle_mm_fault(vma, addr, >> + FAULT_FLAG_UNSHARE | FAULT_FLAG_REMOTE, >> + NULL); >> + if (rc & VM_FAULT_OOM) >> + return -ENOMEM; > > Heiko pointed out that rc type is inconsistent vs vm_fault_t returned by Right, let's use another variable for that. > handle_mm_fault(). While fixing it up, I've got concerned whether is it > fine to continue in case any other error is met (including possible future > VM_FAULT_xxxx)? Such future changes would similarly break break_ksm(). Staring at it, I do wonder if break_ksm() should be handling VM_FAULT_HWPOISON ... very likely we should handle it and fail -- we might get an MC while copying from the source page. VM_FAULT_HWPOISON on the shared zeropage would imply a lot of trouble, so I'm not concerned about that for the case here, but handling it in the future would be cleaner. Note that we always retry the lookup, so we won't just skip a zeropage on unexpected errors. We could piggy-back on vm_fault_to_errno(). We could use vm_fault_to_errno(rc, FOLL_HWPOISON), and only continue (retry) if the rc is 0 or -EFAULT, otherwise fail with the returned error. But I'd do that as a follow up, and also use it in break_ksm() in the same fashion. -- Cheers, David / dhildenb