From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5347C38142 for ; Tue, 24 Jan 2023 13:57:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 49D236B0071; Tue, 24 Jan 2023 08:57:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 44CA66B0072; Tue, 24 Jan 2023 08:57:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 313E66B0074; Tue, 24 Jan 2023 08:57:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 269D86B0071 for ; Tue, 24 Jan 2023 08:57:15 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id ED9481C5BAC for ; Tue, 24 Jan 2023 13:57:14 +0000 (UTC) X-FDA: 80389844388.02.BC597DA Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf05.hostedemail.com (Postfix) with ESMTP id 15A9D100015 for ; Tue, 24 Jan 2023 13:57:12 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Drersenc; spf=pass (imf05.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674568633; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DgD/f9BNb2oVu+Rz4+nVO6VWZZv2jdeOteZmp96pjN8=; b=lphlx8rSRwhkEgF131Bkd0Hd6MeZ6KqyURtDKWqHLEKyeh4BmuVlC11ab7OOUj57O5U7xI GPQh2Uaeq7t553kHGzF8sf36CkzK3VtxNanfRSt2VkUY3re+sHvfjVEaKQONayNWDULMji AKPIXlKxCR6pDoPZgGS1YZPURs1tCvc= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Drersenc; spf=pass (imf05.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674568633; a=rsa-sha256; cv=none; b=cIsY07o4CN8t7A2F1QUiNsW9iZcVMoriJpFh+gFh70cJ1Eb31qakYX3r4kn2UxtZ6wU+ND RLmCNiy9N2IlGUzg7EqLQ/hom5WT8vxmjyNHDODopp0iqIIYsm9ykqVXhjIY1kSf/I6OH+ bfg+qDKlI+ZWmRko2IByA1cAR91wA5I= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674568632; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DgD/f9BNb2oVu+Rz4+nVO6VWZZv2jdeOteZmp96pjN8=; b=DrersencZ1x4H8Ojj1Co/mpImPpionn8gRa3sPNa/XDxFSOt1dECyfSdbMViW/4vxo28dY xHsDk0zUK+naNakJZvQLUVCo8r5+dp0LAz9OmgPDocFdOT3K3R2v4VvLQ9iCmcBN2CbA9O jPhYLrPqxZjSbltuSfnu2gSZR0WWy+Y= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-646-DeVOvTxrOxOtsQT31D-5ag-1; Tue, 24 Jan 2023 08:57:11 -0500 X-MC-Unique: DeVOvTxrOxOtsQT31D-5ag-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 56726858F09; Tue, 24 Jan 2023 13:57:10 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.97]) by smtp.corp.redhat.com (Postfix) with ESMTP id B59712026D4B; Tue, 24 Jan 2023 13:57:08 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <20230123173007.325544-1-dhowells@redhat.com> <20230123173007.325544-11-dhowells@redhat.com> <31f7d71d-0eb9-2250-78c0-2e8f31023c66@nvidia.com> <84721e8d-d40e-617c-b75e-ead51c3e1edf@nvidia.com> <852117.1674567983@warthog.procyon.org.uk> To: Jason Gunthorpe Cc: dhowells@redhat.com, John Hubbard , Al Viro , Christoph Hellwig , Matthew Wilcox , Jens Axboe , Jan Kara , Jeff Layton , Logan Gunthorpe , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Christoph Hellwig , linux-mm@kvack.org Subject: Re: [PATCH v8 10/10] mm: Renumber FOLL_PIN and FOLL_GET down MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <852913.1674568628.1@warthog.procyon.org.uk> Date: Tue, 24 Jan 2023 13:57:08 +0000 Message-ID: <852914.1674568628@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 15A9D100015 X-Rspam-User: X-Stat-Signature: rtkbukhk9b6atztcngb79pygsonj48jr X-HE-Tag: 1674568632-68583 X-HE-Meta: U2FsdGVkX19hhMqFAwH1x4hZPkGgPfTMkCPvZjjBlKp5QmsegZCL3gdhDsJisAmPXUXuYArAZ89fh1xHJuKOJm48EpbjbSeBbaspnQmc8q9CwPFkNPMsKwmMVlzDks8TZiwU+H1vVE2T7nW0eKFVYNKf8M3rMOYDPuY4inR6Rt/MqUZ0eFopTMGXCoGlVY3yzJ7/bS9iulkaVs74BkK51TV5Wf9dtTQdMstKI3Iw8a1aTRc+pOB8YyEYaNfha5j3J3HfRabRdJBWBBlq7zY6mYR5M5HFzrT/UEjn6kTHD8krJwSvig4wSHGKganevG+w5CdvPc4Kp0o6y33XCSigQcdrd9SIhfC8YC6aK2hrcK1s61E544M1hiQgRYT63Su29Vwf9Bwh5K/lZyP70+ICXce+XCszHR7smBuoYWchW2lgHWGA0yhNs/XHOMiXUssLFPYwQXZizoeWyU4vxXMjfwrgi0EIyTAryLC+9Ni+zyiwOQPs569v3/tnPSWxEO0xdwQCjHrwr3YE87rE3f9Vj2Lcn14/ubL9tBeiLTBeB23q8yzrfU02ub8xEwG2LCn+UE1G/RugKReU6jAd521nlABWrajqfgOai2W+QJTEmwHYa87UiweCg0zjXp60wqS8PwyPNQrlaSiiShd6clWy0c1spD4hghd6BmUqHKUJ10Yo13UaU2Xt9oxek7HDwIaHWZzYsq9OjH8XfMkkjvWJKVqRfONrIe6jB9r631g74XNeAUqEawfmbOLNAtmGXuYTH+bkGRlfqHE+R5T0rB0ze1hGarRuG/NBp1kuGQ1AQ+iWNbJY/QzAAHzCGSk8k2aUVaebDfeVVHTP+yzszYAzzh37JPj5Vuj3AkhknfJGySlqn++WQXhXp2jmayek5zN1ZMWcE1iSga7vfoFSFAD2lv3/SvPS3Hy+sdMcErXjCrj7shvEYF42wS36i4vSZjvEk6x7gg4Lv8lW2M+jA4I 1N+VsO+h XuVdxmW+qDHO2M1oM+qVEONHeznMCLkxt1xSKnqghsfxumrOyIAV+JTLDnJQcUP8gKydWZVt0lWibB9e0BCtf5hJIAFrvu2PuNLK56IpfvAB1rr9szIpVQtrH4f28DY+keTUDiFRhcYXAe4Qb7kI7ZluF1ZA9kk8JvUXeeDBClW0NT/MEnwkqb2zW3g3xSoMiZehUz1H42xlUmL5+r3HVUsNxlnx6snfy/8His99WoHQ9S7S7C/YZZym89g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Jason Gunthorpe wrote: > I moved FOLL_PIN to internal.h because it is not supposed to be used > outside mm/* > > I would prefer to keep it that way. I'll need to do something else, then, such as creating a new pair of 'cleanup' flags: [include/linux/mm_types.h] #define PAGE_CLEANUP_UNPIN (1U << 0) #define PAGE_CLEANUP_PUT (1U << 0) [mm/gup.h] void folio_put_unpin(struct folio *folio, unsigned int cleanup_flags) { unsigned int gup_flags = 0; cleanup_flags &= PAGE_CLEANUP_UNPIN | PAGE_CLEANUP_PUT; if (!cleanup_flags) return; gup_flags |= cleanup_flags & PAGE_CLEANUP_UNPIN ? FOLL_PIN : 0; gup_flags |= cleanup_flags & PAGE_CLEANUP_PUT ? FOLL_GET : 0; gup_put_folio(folio, 1, flags); } EXPORT_SYMBOL_GPL(folio_put_unpin); David