From: Abel Wu <wuyun.wu@huawei.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Christoph Lameter <cl@linux.com>,
Pekka Enberg <penberg@kernel.org>,
"David Rientjes" <rientjes@google.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>, <liu.xiang6@zte.com.cn>,
"open list:SLAB ALLOCATOR" <linux-mm@kvack.org>,
open list <linux-kernel@vger.kernel.org>,
<hewenliang4@huawei.com>, <hushiyuan@huawei.com>
Subject: Re: [PATCH] mm/slub: make add_full() condition more explicit
Date: Thu, 20 Aug 2020 09:56:23 +0800 [thread overview]
Message-ID: <85259217-3805-92d8-3be1-8279d8a6a85b@huawei.com> (raw)
In-Reply-To: <20200819123713.38a2509a2b7651f14db33e61@linux-foundation.org>
On 2020/8/20 3:37, Andrew Morton wrote:
> On Tue, 11 Aug 2020 10:02:36 +0800 <wuyun.wu@huawei.com> wrote:
>
>> From: Abel Wu <wuyun.wu@huawei.com>
>>
>> The commit below is incomplete, as it didn't handle the add_full() part.
>> commit a4d3f8916c65 ("slub: remove useless kmem_cache_debug() before remove_full()")
>>
>> This patch checks for SLAB_STORE_USER instead of kmem_cache_debug(),
>> since that should be the only context in which we need the list_lock for
>> add_full().
>>
>
> Does this contradict what the comment tells us?
>
> * This also ensures that the scanning of full
> * slabs from diagnostic functions will not see
> * any frozen slabs.
>
I don't think so. If the flag SLAB_STORE_USER is not set, the slab won't
be added to the full list no matter this patch is applied or not, since
the check inside add_full() will guard for that. Am I missing something
here?
Regards,
Abel
next prev parent reply other threads:[~2020-08-20 1:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-11 2:02 wuyun.wu
2020-08-17 9:19 ` Abel Wu
2020-08-19 19:37 ` Andrew Morton
2020-08-20 1:56 ` Abel Wu [this message]
2020-10-16 16:58 ` Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85259217-3805-92d8-3be1-8279d8a6a85b@huawei.com \
--to=wuyun.wu@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=hewenliang4@huawei.com \
--cc=hushiyuan@huawei.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liu.xiang6@zte.com.cn \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox