From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF71EC25B4E for ; Tue, 24 Jan 2023 13:46:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2A9666B0071; Tue, 24 Jan 2023 08:46:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 258F16B0072; Tue, 24 Jan 2023 08:46:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 121226B0074; Tue, 24 Jan 2023 08:46:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 026B86B0071 for ; Tue, 24 Jan 2023 08:46:45 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id B1400AB03C for ; Tue, 24 Jan 2023 13:46:45 +0000 (UTC) X-FDA: 80389817970.17.EEE4F51 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf15.hostedemail.com (Postfix) with ESMTP id AF585A0004 for ; Tue, 24 Jan 2023 13:46:43 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Nxr0m9Zf; spf=pass (imf15.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674568003; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ETrfxyrVdU7X1rX1QL9lvr6n2bGLp1QRnmU9FMajeiU=; b=8Qp2YWwFxM/JZZ3TsZA8eCdxCZNlU0O5Y3wSRPAIQShZGODf7vKOLSiSmh0iDfG2eoOPwu oliAwy9IxDL9nY794er9/CFhEGlNJQqBBiC1+VDf676/CI1EXjAmeXzOyqlHbocdyj0plF rUcsOBU2dOKYXT9WswdOWaF4qapBQLc= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Nxr0m9Zf; spf=pass (imf15.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674568003; a=rsa-sha256; cv=none; b=nTyz/QCS/mqQY+jqzFJRnUJ1Iwm/We9LQyF5eLJCKhZXN7atGv4gn2/oRwW49bMXqwJj1B xiD7dC1YxEjLl0kCISI/OWE6bzUVvtmzNo/0nymTTTpDxushFvVVpKkYFqY6CJ0aIDYOp3 BF8FWho7tFqS2i96nQIfB6Vw6es5egg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674568003; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ETrfxyrVdU7X1rX1QL9lvr6n2bGLp1QRnmU9FMajeiU=; b=Nxr0m9ZflJsT7XeMZMdhzbWMjA1sq4gItkko8gBA2HXy4+dU4kqebM1tVQNpPtRJK3arkQ 29ZUt5q7Vx0Y/5hzgDNfESWJgWsED82Kcgex8uiqODnKM2NOcnSRSDPUcKIkSbtl8ze3iO ZeswYG2DhH7Es3mRWBD9msbG/f3v36g= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-618-YMTlk8RlN1GqCVMCLPBtqg-1; Tue, 24 Jan 2023 08:46:26 -0500 X-MC-Unique: YMTlk8RlN1GqCVMCLPBtqg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D36318030CC; Tue, 24 Jan 2023 13:46:25 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.97]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3E5D71121330; Tue, 24 Jan 2023 13:46:24 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <20230123173007.325544-1-dhowells@redhat.com> <20230123173007.325544-11-dhowells@redhat.com> <31f7d71d-0eb9-2250-78c0-2e8f31023c66@nvidia.com> <84721e8d-d40e-617c-b75e-ead51c3e1edf@nvidia.com> To: Jason Gunthorpe Cc: dhowells@redhat.com, John Hubbard , Al Viro , Christoph Hellwig , Matthew Wilcox , Jens Axboe , Jan Kara , Jeff Layton , Logan Gunthorpe , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Christoph Hellwig , linux-mm@kvack.org Subject: Re: [PATCH v8 10/10] mm: Renumber FOLL_PIN and FOLL_GET down MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <852116.1674567983.1@warthog.procyon.org.uk> Date: Tue, 24 Jan 2023 13:46:23 +0000 Message-ID: <852117.1674567983@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: AF585A0004 X-Stat-Signature: xbbb87mbxo31mdafgbki7wobhne6wi1u X-HE-Tag: 1674568003-514941 X-HE-Meta: U2FsdGVkX19SguPtghgSxp4pSjsi6H4J7iXSSZmv795PSk0IfMb4ogA/q2M8sF6v+uLQxQsgbMQu8RRK5gEkzLuYDtQwWy2QCuqg2DFyErBUdIhDPa7yYIZ5tI6HHt2esnlWz5VqjmwkljCrH7L+EiZ0XTBUA3aI+nT0heWgIeMnaEniL9Nfx7FNCSSwOxnzkrPf1O98GZrvEQi5eTZ6wfd1UvLOhDGo9zQFc8NpxuEaDf/E9dnljQOCgioejMyD7XoSbNzG/+obiueg0L1emH3IR2XvTDqc6L7SpYntKHSLfcQHAKHVWWEEzLC1n2NhwhZ91ZR9lZ2BrTX/5MzHsipV2JX0RWJXJk+Ya/yZPxjO3diCyFiI2gkf+RWgGvtf3kaa44r7H7SJ0tVQbtgsTvRGaBn2bhg+EzBd7v9Wr5iQ+432QVhgIjYawDWDl4GCKlh7X1dCKpzowZ7PidEz8Buphd7rUShgb/Z+j24YdxnxJ7fL7Pz6NAodnffskrQ6I69n30VXUAwf9CUVEXw20TV/AOyir45NxO6DmHZv9+A/IhKjnm/kBR4SVHqcMZQn/HYOgr8sKClge5ZZ9wf0ygIyxVGuzZhES8XDlkam3d23VdpzChFATIThrCp8dtZJZlpTTNEsXDrgfw24P7CSvXNKkNcPo0U57I0RwyB95fm9PLQXw157M06JTPfzsc/pAVmhpXPGYQKzMe9wSAyGoCr8iXlz9JzXD3nmhuP12V3O1+jBkkCtUr7AI9/vKSbx4/Dyfqsn8T+NqsrAZ0azms67gJd8GNnUAUtkT7rABFjkUHah5trefeA3mmTogZ18nm6XAKbufT3n8d39DvWmcUANO2d8/S5Mn2vs30vY0//1yDd7URHRTl3Ecmf+nOorYH5edahcTZ/LN33ggpVj2AFKwQ/lUMuWkqHKIRNIKdPYTMu9fW0aIsX+KXnVkPc2eUD/fXavuRXiuo0vRRs JdHzhbTG AuBwO625ijPVy+nsa3E1TnviiA3/PdXSvvRYOhNleP1Tr3qatg7NDJWut/8yCDH2YGtIQDbj0ONTqKK6mKHebfyJuS9WbNwaXC4ujD/FEGXaHxazyPZqEdbPwZETgqCeNOsol6Yjh9SxNOPiitJY4vkjdQZlk2NymP2G9CjuxmLzRQl/P6cz+DQxoVl/+1GO5ahCBLeMUvWxbbAackxF6Gts9/gCa5N5T76lbV4usc3qlcPu3uCNlETXMEg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Jason Gunthorpe wrote: > Yeah, I already wrote a similar patch, using the 1<< notation, > splitting the internal/external, and rebasing on the move to > mm_types.. I can certainly drop that patch if we'd rather do this. Note that I've already given Andrew a patch to move FOLL_* to mm_types.h. I'm happy to go with your patch on top of that if you can just renumber FOLL_PIN to 0 and FOLL_GET to 1. David