From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B8ECCFB43F for ; Mon, 7 Oct 2024 11:01:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E94666B00F3; Mon, 7 Oct 2024 07:01:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E43756B00F4; Mon, 7 Oct 2024 07:01:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D33276B00F5; Mon, 7 Oct 2024 07:01:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id B028F6B00F3 for ; Mon, 7 Oct 2024 07:01:13 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 34B3FAAD98 for ; Mon, 7 Oct 2024 11:01:13 +0000 (UTC) X-FDA: 82646514426.25.F5BC8E5 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf27.hostedemail.com (Postfix) with ESMTP id 840C740012 for ; Mon, 7 Oct 2024 11:01:09 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf27.hostedemail.com: domain of vincenzo.frascino@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=vincenzo.frascino@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728298722; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9dfeyPppJSDRv8OyRVmEjfBIkiZpYyL+43FkMwjKZag=; b=dIsEnKscK0tnO2HXju56kXf2aTvDvujmmQAeld+vWwe/FEXC0kph+dXHx+caRiZdfBNfr7 Jxw+ew8DL1zwRsdb7c9kNBBsDmxWiND0wIbcZsvJOrpb7kSHbh91GuDQthwv0Kr50+8v2h EBBcxwt18MMtgtQ9L5uXaz3Zx0UZOpQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728298722; a=rsa-sha256; cv=none; b=wHOgiSv1B2W1YrjEc85OXVnheteg6LCyfswYZA5XCqZfEaLn/LZVDLEWgJrAqO9JhH485j QEw/jB/FFrzHakh6p5qaSJZJuUOG0iRVwImYmIvFV8BkxvrPxv50L+pBYmey/R4vyCwNVc VmVkVZu1x3+vLUl3LV3PqKxm1DOLLZw= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf27.hostedemail.com: domain of vincenzo.frascino@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=vincenzo.frascino@arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 02F9CFEC; Mon, 7 Oct 2024 04:01:38 -0700 (PDT) Received: from [10.1.196.72] (e119884-lin.cambridge.arm.com [10.1.196.72]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BDB013F640; Mon, 7 Oct 2024 04:01:05 -0700 (PDT) Message-ID: <850cdc2a-a336-4dab-bc7a-d9bcae3fb3cf@arm.com> Date: Mon, 7 Oct 2024 12:01:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/2] vdso: Introduce vdso/page.h To: Arnd Bergmann , linux-kernel@vger.kernel.org, Linux-Arch , linux-mm@kvack.org Cc: Andy Lutomirski , Thomas Gleixner , "Jason A . Donenfeld" , Christophe Leroy , Michael Ellerman , Nicholas Piggin , Naveen N Rao , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Theodore Ts'o , Andrew Morton , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers References: <20241003152910.3287259-1-vincenzo.frascino@arm.com> <20241003152910.3287259-3-vincenzo.frascino@arm.com> <423e571b-3ef6-4e80-ba81-bf42589a4ba8@app.fastmail.com> Content-Language: en-US From: Vincenzo Frascino In-Reply-To: <423e571b-3ef6-4e80-ba81-bf42589a4ba8@app.fastmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 840C740012 X-Stat-Signature: i49jzwf7e1bfew59yb6tixry74hygkga X-Rspam-User: X-HE-Tag: 1728298869-11320 X-HE-Meta: U2FsdGVkX1+YqjQ031ODc5UwSbZAZG8tvkqgZdprKNnFh1RqFvCsA4v/mhtorE+Cw1QmGvOgGYb5R2wMH12H9vgPEW6FMwEcePbBcpUAbKN80TkWmPPaXnMZp6Ni6eT5HC3hScgOYS14+T9RkBZ/v3nYm7g1IXkMnte6lVfquVfCBRJAEJy9Q4LZMxs6jTb9qXFso9RyDRSKo2vhZsUqo/CAvkF9qlF85BD6KLli9S2Xo1DsDutgj73j2m2yi/TQABroW9YyVZ71AMnnHltMBdIQCFhv/d6LepVz1M6uwDJARSBVSCh9yeOIWq7yfFNkwyoPspYK0/ceqg15bdoegG/OGvYAJ/p55fmDkqDfCwYd1zBjHkWZpZQYGqJt12pzlBytlfINbv1teUSLAGUOH/rGCrdpXF1ft10LpurKPxZmU85538FORZZBlrIrS3zreAarKDmnq4rxzrwCpbqEq9EScd3iv6KDipvnYTcSKo7nLdnnzAiUEDTyfibg3rCZ0i3HVYgaye0NxX19DtxGUn0+W6iwjpw2TKpQUT1hBqn56ap/Iy7gAiFCaTlr1UUjjFKxrvAAFGM/E249OaSFMNCC1efBu+fzu96ab4T6K7ax0pNF3a7+wBzu5wtjeBSXixCZ2yeEZFlF2teYdhx00Kzcs1Or1oO+O9r2ZGfB8rwgelUNjQDvHC3N9UgzIAiun408trtNpiXZR8RaLaz3+aD8djbcJ7HpiVxFvyWCPUxlViHwTQfDpqHpU4QDvcP3Z5dDccoiVTZn22MQWh9StMdEytjITKqvVb375cHaWq/nzalCp/uimhO6dHBrsR8lheqG5Q5yL3bsKS5QU3BSHponwK0zw6QiHgAFBh57GB19I1keKCzSvQl+DjtB523aoXecntfAXTc8gCvPiqt/zkLKyF/2M8Y1HfZH1kjxHy3qZu6IALwuesGKOSVfIaAEmw1jlIPwqZ90k+0BOBx uAEEt5yB UDrcXV4c9Rt3/UW4ziEUI5S+giWWR9lw0bnY31SSll1VYlsr+laRuxL7mEQvo/PKzDqdW/lYszJPpWxxH/VHe0WfPUPShaPqZH/c76BmvSGhjrGiU/LCdtCHeOi39CjPx8nGM5qxZKjZ0gDyviSFpMkTaAnK5p72x5u54BIXh5fTixbulDTKRVrsAsAt7NXy1GwIIeIZ/d2oLe85l+GD+AcR8W280FvfiCUh++Jl+HQOMylztyvhZCMweWt/vxYOJuJm4im4Cr40m/Ubt4Mndkb5gaFr4lMLtn421 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 04/10/2024 14:13, Arnd Bergmann wrote: > On Thu, Oct 3, 2024, at 15:29, Vincenzo Frascino wrote: >> The VDSO implementation includes headers from outside of the >> vdso/ namespace. >> >> Introduce vdso/page.h to make sure that the generic library >> uses only the allowed namespace. >> >> Note: on a 32-bit architecture UL is an unsigned 32 bit long. Hence when >> it supports 64-bit phys_addr_t we might end up in situation in which the >> top 32 bit are cleared. To prevent this issue this patch provides >> separate macros for PAGE_MASK. >> >> Cc: Arnd Bergmann >> Cc: Andy Lutomirski >> Cc: Thomas Gleixner >> Cc: Jason A. Donenfeld >> Signed-off-by: Vincenzo Frascino > > Looks good to me. I would apply this to the asm-generic > tree for 6.13, but there is one small detail I'm unsure > about: > Thanks. >> +#if defined(CONFIG_PHYS_ADDR_T_64BIT) >> +#define PAGE_MASK (~((1 << CONFIG_PAGE_SHIFT) - 1)) >> +#else >> +#define PAGE_MASK (~(PAGE_SIZE-1)) >> +#endif > > We only want the #if branch for 32-bit architectures, right? > > On 64-bit ones, CONFIG_PHYS_ADDR_T_64BIT is always set, so > I think that is unnecessary change from the existing version, > even though it should be harmless. > It seemed harmless from the tests I did. But adding an '&& defined(CONFIG_32BIT)' makes it logically correct. I will add a comment as well in the next version. > Arnd -- Regards, Vincenzo