From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CD58C3ABBC for ; Tue, 6 May 2025 16:03:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 717D16B0089; Tue, 6 May 2025 12:03:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6C5B46B008A; Tue, 6 May 2025 12:03:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 58CC96B008C; Tue, 6 May 2025 12:03:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 3631E6B0089 for ; Tue, 6 May 2025 12:03:56 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id CAF7A59E29 for ; Tue, 6 May 2025 16:03:56 +0000 (UTC) X-FDA: 83412954072.21.D2BA6DF Received: from smtpbgau1.qq.com (smtpbgau1.qq.com [54.206.16.166]) by imf26.hostedemail.com (Postfix) with ESMTP id ACF3F140004 for ; Tue, 6 May 2025 16:03:52 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=uniontech.com header.s=onoh2408 header.b="IQVUre/C"; dmarc=pass (policy=none) header.from=uniontech.com; spf=pass (imf26.hostedemail.com: domain of wangyuli@uniontech.com designates 54.206.16.166 as permitted sender) smtp.mailfrom=wangyuli@uniontech.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746547434; a=rsa-sha256; cv=none; b=B+lYYiI7rCVxQ9scbklXjR9nOOyKpgPkQf235CwMfk6N0+sRItxUJ06FBMD9AMM/hfULCy 93YPBawKI/0vm6BBOnCON1RERmIQ/HVwDfIonYTzXYobPWSCFtHA2pAO/aqz8smZ8PkOXP nG00b459wfW+LNixr1gw7ALdYUz8WPI= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=uniontech.com header.s=onoh2408 header.b="IQVUre/C"; dmarc=pass (policy=none) header.from=uniontech.com; spf=pass (imf26.hostedemail.com: domain of wangyuli@uniontech.com designates 54.206.16.166 as permitted sender) smtp.mailfrom=wangyuli@uniontech.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746547434; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=MIxVgUD/gcfzc+AvSnntXs5+xQ69OsezJ0OGOwzsfyo=; b=DW+1OzLBOsu2kE4hwQFlsCdfgQlRZj8bTl3WgRn0H7lSmTRclzcDNwFvrAKvDB025Afw/Q c0KBAG23gYnKr6LNxDVLLaNvVEQSbeoAixnhImL7gzFugXbxwOsTuy6tLO4jYV7Zcf9rsy emaavFOZyw8cr8N11LpUvfEBdw9rKuk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=uniontech.com; s=onoh2408; t=1746547411; bh=MIxVgUD/gcfzc+AvSnntXs5+xQ69OsezJ0OGOwzsfyo=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=IQVUre/C6Wwu2covPWBLq1pMU6EK0B5V/xfCqkDckBmAqAQl8AWhZbWD4pgdHwwvL ZANJ4YY/NJkgjIb+jc+4Sne6HelHtcw/o9A6cgMWJ/o+j4ej6uWrhqdjbZ+pewk31k w3J08/NOQITlHyaHldm1AUupurDG+hs1xzHK0abA= X-QQ-mid: zesmtpip3t1746547370tbb3ca5be X-QQ-Originating-IP: o8pgAATOo7e4w+pMFoumg25Llhz0GOUtirb0feOXr+Y= Received: from localhost.localdomain ( [localhost]) by bizesmtp.qq.com (ESMTP) with id ; Wed, 07 May 2025 00:02:48 +0800 (CST) X-QQ-SSF: 0000000000000000000000000000000 X-QQ-GoodBg: 1 X-BIZMAIL-ID: 15489425460272937920 EX-QQ-RecipientCnt: 10 From: WangYuli To: akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, yuzhao@google.com, stevensd@chromium.org, kaleshsingh@google.com, zhanjun@uniontech.com, niecheng1@uniontech.com, guanwentao@uniontech.com, WangYuli Subject: [PATCH] mm: vmscan: Avoid signedness error for GCC 5.4 Date: Wed, 7 May 2025 00:02:38 +0800 Message-ID: <85050791B887DC13+20250506160238.799984-1-wangyuli@uniontech.com> X-Mailer: git-send-email 2.49.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-QQ-SENDSIZE: 520 Feedback-ID: zesmtpip:uniontech.com:qybglogicsvrgz:qybglogicsvrgz8a-1 X-QQ-XMAILINFO: Nco2gOFShP5nyEqgTp7q0Srkca5PBUpgKh4NtRRMPOwxhhomJoREKFn3 wdg37EQt1XOAk2R/LolorTrAeC6okoZxFlSo8qLKtJIij7HwYCKdzlS9uplfQsxAZARdd5A L/0djvX9E0jFfic0/ApW9C4cHv1c0xJWxwHLLNNzpT+pLeA2A48iz6BptOmq65mG8iGmv35 rB/IPVUPpp0nU/5w4kRJp2qmMyw95stNa3Nkb4Htubub43PoCAMUjGEg8aKuMinQ1sIPVe3 M6qFGvaWZpCommkjHmHhLnQYYRF6/Kg9tCHJpzXWMyChFf85Ipfwi0MveNmZkf9Ti4L4ZBu XRqgEQWQfz4QIn0ZXrYJRAPbjAsYEhDMxGBU5uCtH0gHRSsop989yqTm2LLPg2a0aYTCsD2 62jxPqVwpbkkpseE/uEQg824n9WLi7+T/Zyj8evHL9kYs1myJRNljh5yEKfy/Isfsu/WNYQ jTzdXC0Gqrcv5nADlbLagH+mliB66zHJhtkYFOUg301jW1gpOlRNB4ijKA/V6cCrf917jhm zf57kumzlrCwy18lQpziMFgidsQD4EiP7CuictxHn6+pin3zp2qe4mREXJddXwGVX5ehNDK nUX4zfyjHo98MADH6+BNWutS6pZOnEPAZAEQ6yLA7xaVYmGpUrCJqZ64xuTWS4lxOggz70f 2DWekJTbodD/bDGecRPnYg6Pi2/6JNEVH4njMEULsPIgR6DLjT/mTVlFm57VQUB/30oxOVi wCF7At5JK4dadnIywLRbBt55Cerm6TkQL8hCMOzQolrR3pI6SxYsf71L5SCm/Wh7qVUVBPt nzMM4p5gGnh5y04K/QySN4zR2JmH2j0N0msmKf3AkoA7yuaRKPePiR0M+QETCH6269w7Gh9 at8nRGuOxWqw6QrojO9K+GoP6214GF45x454aThf4IWqXMU8NaxHX3/hcspnBld3DioZji/ FEYSfzSW+RVLiYBdNJcqx+gyER3qDTw/ri7q6PwVL/o+ZYVZbfSxYaAcPnQ5A9xjmpwiltu bpJX1mqgIvjwGtwR1O X-QQ-XMRINFO: NI4Ajvh11aEj8Xl/2s1/T8w= X-QQ-RECHKSPAM: 0 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: ACF3F140004 X-Stat-Signature: dhkq7iuixmkqjm19xo67op97nhsz3pz8 X-Rspam-User: X-HE-Tag: 1746547432-435892 X-HE-Meta: U2FsdGVkX18RmEO+TVO21QlfGz+SK/QDDmuLmo4qd/1M2oSL4NZRszoY/u8o8ohdQN/nWc8ArP/GjmuQVpbIF/KDc/3gf7XvAVRbwt7UMCZ7RqJPBZfxnrdj99ge5fVJ/hpERjiGiq+lNU92PEltnsYGGuzKLjIYyjSKUgOS0SwSyWiQJ+1MCJqL/9Bi9a1Hc2xmiOzHhbxLz/MSueOFIJDRf8oRx9xjyDQ0Zqr82/yNcup8kU7oBl1jgq0OlAI1mWXbz0RN5V92CqiLsSyJWwPjwOAA/zZxtoTMez5HtlPYDpOwSU7+McPq3NCoQO8Qade5ZAqTru2NZZd+V+lXMlirJi9TGsLVycjZ+fF0HghoPwRea/VxxTQ7742rZ1Ge0K4DXdGvjPhb+LYaPYlfDmqK5j6G5Xca+zLiDh3oZBjirsWIXhrCmGT6khYknr9Ynwygif9vG0yiuCDslSuNwjpvQ7dEQ2XMJN8gwYmG3zQbMOukS1QySVtWY4cpohFcoqeClNInFoGqCe5KAKXaaPOeUVdgteGxEqRmXab537ftgNpgJ/R32ONdPkplVRjeLSvlQ+7s1Zmx0UakaNhYSfv0ZeNdkFY0M98eHxeUpIjgohxgMXcFvW2pYc6Pfa8Jzz2k+xcATeWkJnPcpIU+TTC8ad+FEElu76+6J6cxMb2YG5XLkj1vAK3OtbxXTvogdSbeRfhlIxR9K829Duwp1mwp1oHgEEcbYt/rva5APTl8d5Sd/AJIGDL/OYtkSoXRC5hjpzx9D1TYxEx3UaA9sVuMFF4YE1fXkvWwVurBCv9hxiuM/wVdisgm3HzQZlRQ7xcFShCOuvWl4Q8R3I7iybuBv1ygX+cd164lryYdNVl6YJWOjHxPkZujXDMf+i1TgIgvKPlhaesbIQSTYGOZwzkG5dnAO7rZBvvdj7enr5TrRLYL5vLstnWjXgFvWhhOj4K4ShpnCbMGJq9tr2Q P8Lu6szi Xo0Rp1gtn+Iu9rZkXhHSlaG52oMP5kLfBquZSG8d+mtzZ74Il/xP8Gas8q7k0cBKySEQB6SStsbi+pOZT6nnvTD5ugwI7Dr2lwoxvw1jepGiZuNGQklWAnjs9JZI7Qf/Guhxq53Dzy9MNWNOTydD3aENZC86kr4XEnH0RM4ZEzJLk9Rgg/LK6bjuWKRZhujki5l2+eytD4QIfKcFVz1pHcfzWVO6jqio1QSHAnOYeX5JBlZOSLn9tXZv+vzIpx2M3onqWccOLBjNv7JjJYnHaInnVg8q2S7CNHvuUfEqoSsRO2tI6e1oCQOLFouuiaA+vIRmW7seOPE/NWtzdPPGfP24CVA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: To the compiler, (MAX_NR_TIERS - 1) (i.e., (4U - 1)) is unsigned, whereas tier is a signed integer. GCC 5.4 does not permit the minimum operation on such type-inconsistent operands. Cast it to a signed integer to circumvent this compiler error. Fix follow error with gcc 5.4: mm/vmscan.c: In function ‘read_ctrl_pos’: mm/vmscan.c:3166:728: error: call to ‘__compiletime_assert_887’ declared with attribute error: min(tier, 4U - 1) signedness error Fixes: 37a260870f2c ("mm/mglru: rework type selection") Signed-off-by: WangYuli --- mm/vmscan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/vmscan.c b/mm/vmscan.c index 3783e45bfc92..29dce1aed962 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -3163,7 +3163,7 @@ static void read_ctrl_pos(struct lruvec *lruvec, int type, int tier, int gain, pos->gain = gain; pos->refaulted = pos->total = 0; - for (i = tier % MAX_NR_TIERS; i <= min(tier, MAX_NR_TIERS - 1); i++) { + for (i = tier % MAX_NR_TIERS; i <= min(tier, (int)(MAX_NR_TIERS - 1)); i++) { pos->refaulted += lrugen->avg_refaulted[type][i] + atomic_long_read(&lrugen->refaulted[hist][type][i]); pos->total += lrugen->avg_total[type][i] + -- 2.49.0