From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86375C4332F for ; Fri, 21 Oct 2022 13:50:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E2D248E0002; Fri, 21 Oct 2022 09:50:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DB63B8E0001; Fri, 21 Oct 2022 09:50:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C56758E0002; Fri, 21 Oct 2022 09:50:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id B3CBA8E0001 for ; Fri, 21 Oct 2022 09:50:20 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 2B029A0DED for ; Fri, 21 Oct 2022 13:50:20 +0000 (UTC) X-FDA: 80045091000.07.9249871 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf17.hostedemail.com (Postfix) with ESMTP id 68C0940030 for ; Fri, 21 Oct 2022 13:50:19 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id BEDDA219C8; Fri, 21 Oct 2022 13:50:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1666360217; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=52+XSCFwlMADDtkLiX19EF6vTQJl2O9f027xZLvwVcs=; b=hR9+lF5W88X7dPunQ9qH12qpIXwbBHgIQm6M1oruIRx+4IpMWcAF62LCaQRfxDLqi6QWbQ dkkaYG4FBcTQs04j8f5dduv4gOme3KNYpeODqcj4ChFrBRSWdQgueoKkdkKdDw6UD4+9CC mrQbRTPDzOSM4edBXrI+cUW/zqyo+Kw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1666360217; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=52+XSCFwlMADDtkLiX19EF6vTQJl2O9f027xZLvwVcs=; b=7vT+QMr+lniBsnyY5+/gvxzD17hl9ND9mP8k9zXzlx8cRN6Sd5u//l7GTILQr4tE/efZw9 x+dD1n0ObwDMQ2CQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8C42F1331A; Fri, 21 Oct 2022 13:50:17 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id YPOWIZmjUmNIDwAAMHmgww (envelope-from ); Fri, 21 Oct 2022 13:50:17 +0000 Message-ID: <8504f36a-b6bc-4c46-843e-55d8cd5a1dd0@suse.cz> Date: Fri, 21 Oct 2022 15:50:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.3 Subject: Re: [PATCH rcu 5/8] slab: Explain why SLAB_DESTROY_BY_RCU reference before locking Content-Language: en-US To: paulmck@kernel.org, Christoph Lameter Cc: rcu@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com, rostedt@goodmis.org, Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org References: <20221019224652.GA2499358@paulmck-ThinkPad-P17-Gen-1> <20221019224659.2499511-5-paulmck@kernel.org> <03d5730-9241-542d-76c6-728be4487c4@gentwo.de> <20221021134309.GG5600@paulmck-ThinkPad-P17-Gen-1> From: Vlastimil Babka In-Reply-To: <20221021134309.GG5600@paulmck-ThinkPad-P17-Gen-1> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=hR9+lF5W; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=7vT+QMr+; spf=pass (imf17.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666360219; a=rsa-sha256; cv=none; b=vqLluhIbohrBMH+ztX97+jvS5pHo26DDcbVu8Aj1oVdQzoGOWizReJZFSf/l6g6zmyZFkc dTgUQ68bpe0a7vMKF3BaIu/rWdm+Jdxfy/hhNmLJd34FQDKPPEDA/X5ztFRpLium0zQj1p PTZC1IGNpduoQkWOnI+ms2SBeiERdEQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666360219; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=52+XSCFwlMADDtkLiX19EF6vTQJl2O9f027xZLvwVcs=; b=MjEjIZRtb7lOKHHQR9gIHgB2zGFjOnmeYt6CI9smnXCSMYYvb3t4rJCT9ypo5R1H6DJUA1 90x84r14pHwMzWL+/M8e+M0tnaOzokYvg+y/BGLg9d1NE1EoCl3p9jHVKnfUHZGr1gFaH5 mJM0uRf3kQ/twkbBhQtRKo8q1CEMPUQ= Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=hR9+lF5W; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=7vT+QMr+; spf=pass (imf17.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none X-Stat-Signature: goeet3azp38qpmgeaiu3z9dmg95ebh7k X-Rspamd-Queue-Id: 68C0940030 X-Rspamd-Server: rspam02 X-Rspam-User: X-HE-Tag: 1666360219-448006 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 10/21/22 15:43, Paul E. McKenney wrote: > On Fri, Oct 21, 2022 at 09:44:23AM +0200, Christoph Lameter wrote: >> On Wed, 19 Oct 2022, Paul E. McKenney wrote: >> >> > It is not obvious to the casual user why it is absolutely necessary to >> > acquire a reference to a SLAB_DESTROY_BY_RCU structure before acquiring >> > a lock in that structure. Therefore, add a comment explaining this point. >> >> Sorry but this is not correct and difficult to comprehend. >> >> 1. You do not need a reference to a slab object after it was allocated. >> Objects must be properly protected by rcu_locks. >> >> 2. Locks are initialized once on slab allocation via a constructor (*not* on object allocation via kmem_cache_alloc) >> >> 3. Modifying locks at allocation/free is not possible since references to >> these objects may still persist after free and before alloc. >> >> 4. The old term SLAB_DESTROY_BY_RCU is used here. > > Thank you for looking this over, but Vlastimil beat you to it. How does > the update below look? LGTM. > Thanx, Paul > > ------------------------------------------------------------------------ > > commit ff4c536e6b44e2e185e38c3653851f92e07139da > Author: Paul E. McKenney > Date: Mon Sep 26 08:57:56 2022 -0700 > > slab: Explain why SLAB_TYPESAFE_BY_RCU reference before locking > > It is not obvious to the casual user why it is absolutely necessary to > acquire a reference to a SLAB_TYPESAFE_BY_RCU structure before acquiring > a lock in that structure. Therefore, add a comment explaining this point. > > [ paulmck: Apply Vlastimil Babka feedback. ] > > Signed-off-by: Paul E. McKenney Acked-by: Vlastimil Babka > Cc: Christoph Lameter > Cc: Pekka Enberg > Cc: David Rientjes > Cc: Joonsoo Kim > Cc: Andrew Morton > Cc: Vlastimil Babka > Cc: Roman Gushchin > Cc: Hyeonggon Yoo <42.hyeyoo@gmail.com> > Cc: > > diff --git a/include/linux/slab.h b/include/linux/slab.h > index 90877fcde70bd..487418c7ea8cd 100644 > --- a/include/linux/slab.h > +++ b/include/linux/slab.h > @@ -76,6 +76,17 @@ > * rcu_read_lock before reading the address, then rcu_read_unlock after > * taking the spinlock within the structure expected at that address. > * > + * Note that it is not possible to acquire a lock within a structure > + * allocated with SLAB_TYPESAFE_BY_RCU without first acquiring a reference > + * as described above. The reason is that SLAB_TYPESAFE_BY_RCU pages > + * are not zeroed before being given to the slab, which means that any > + * locks must be initialized after each and every kmem_struct_alloc(). > + * Alternatively, make the ctor passed to kmem_cache_create() initialize > + * the locks at page-allocation time, as is done in __i915_request_ctor(), > + * sighand_ctor(), and anon_vma_ctor(). Such a ctor permits readers > + * to safely acquire those ctor-initialized locks under rcu_read_lock() > + * protection. > + * > * Note that SLAB_TYPESAFE_BY_RCU was originally named SLAB_DESTROY_BY_RCU. > */ > /* Defer freeing slabs to RCU */