From: John Ogness <john.ogness@linutronix.de>
To: Waiman Long <llong@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Gu Bowen <gubowen5@huawei.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
stable@vger.kernel.org, linux-mm@kvack.org,
Lu Jialin <lujialin4@huawei.com>,
Breno Leitao <leitao@debian.org>
Subject: Re: [PATCH] mm: Fix possible deadlock in console_trylock_spinning
Date: Wed, 06 Aug 2025 17:40:53 +0206 [thread overview]
Message-ID: <84h5yko44i.fsf@jogness.linutronix.de> (raw)
In-Reply-To: <5ca375cd-4a20-4807-b897-68b289626550@redhat.com>
On 2025-08-01, Waiman Long <llong@redhat.com> wrote:
>>> kmemleak_scan_thread() invokes scan_block() which may invoke a nomal
>>> printk() to print warning message. This can cause a deadlock in the
>>> scenario reported below:
>>>
>>> CPU0 CPU1
>>> ---- ----
>>> lock(kmemleak_lock);
>>> lock(&port->lock);
>>> lock(kmemleak_lock);
>>> lock(console_owner);
>>>
>>> To solve this problem, switch to printk_safe mode before printing warning
>>> message, this will redirect all printk()-s to a special per-CPU buffer,
>>> which will be flushed later from a safe context (irq work), and this
>>> deadlock problem can be avoided.
printk no longer works like this. There are no special per-CPU
buffers. As correctly pointed out by Longman, the proper interface is
printk_deferred_enter()/printk_deferred_exit().
With the deferred interface, the printk message is still immediately
stored in the printk ringbuffer (which is lockless) and only the console
printing itself is deferred.
John Ogness
next prev parent reply other threads:[~2025-08-06 15:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-30 9:49 Gu Bowen
2025-08-01 22:33 ` Andrew Morton
2025-08-02 3:09 ` Waiman Long
2025-08-02 3:53 ` Andrew Morton
2025-08-04 12:08 ` Catalin Marinas
2025-08-04 12:34 ` Breno Leitao
2025-08-04 18:28 ` Catalin Marinas
2025-08-05 7:44 ` Gu Bowen
2025-08-06 15:34 ` John Ogness [this message]
2025-08-07 3:22 ` Gu Bowen
2025-08-01 23:52 ` Andrew Morton
2025-08-11 14:33 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84h5yko44i.fsf@jogness.linutronix.de \
--to=john.ogness@linutronix.de \
--cc=akpm@linux-foundation.org \
--cc=catalin.marinas@arm.com \
--cc=gubowen5@huawei.com \
--cc=leitao@debian.org \
--cc=linux-mm@kvack.org \
--cc=llong@redhat.com \
--cc=lujialin4@huawei.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox