From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 315CCC48BF8 for ; Thu, 22 Feb 2024 08:51:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B8CAA6B0081; Thu, 22 Feb 2024 03:51:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B3D416B0083; Thu, 22 Feb 2024 03:51:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9DE016B0085; Thu, 22 Feb 2024 03:51:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 8A7C56B0081 for ; Thu, 22 Feb 2024 03:51:08 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 59E50140CEA for ; Thu, 22 Feb 2024 08:51:08 +0000 (UTC) X-FDA: 81818820216.29.16CB605 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf14.hostedemail.com (Postfix) with ESMTP id 3B053100015 for ; Thu, 22 Feb 2024 08:51:06 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="LPwadc/1"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708591866; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2nFn5jCZTy1s9WBf67eU2Zf2Y/G1Fhgpl8nVuZPJzLo=; b=5uvVlPsqysMsrDnnPstvp2IcXq7ATaGplujJOs+USFoe58VhYb2f/wyLwcUUUnXJgqaJTa 7DhCrAuvgFf9tfa6kZralJbLUBtOIwXLrfMcnhQApwUvXJXQFKYHdDTvV8L2u4azpaWX8b ADgXQUZm3I4UOt9r9LHojGhwCSyx6Oc= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="LPwadc/1"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708591866; a=rsa-sha256; cv=none; b=tIxndIFTxmj2GTUrPQB1mCsXJMrTHXJK3x5TR9fvUlyETz2lhtgGZISddXFbuw/3CQRcVL KtQ8Il8lyp+g8qRJuht7oTobR2pTsXZkkb8OrWhNqBIuEUOJ1567dZnNN41BMArWkGxCXs CcN4ZLeQLR4r0qOD3HnAQ5OegJm2eLU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1708591865; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=2nFn5jCZTy1s9WBf67eU2Zf2Y/G1Fhgpl8nVuZPJzLo=; b=LPwadc/1/IR0sDt7yIjRju4E7Q6x/eoqiX86YAkcwZ8OztwglMX3ac41/7MxArHX++locm 4+gEhnH63eMjnD0fVXYy9hLy10x2EtxkFmpTNv9Vt0wUeQtT5sIO/Px1yA50/A/TLgPVMn xtz0ZRYfZt3r/ol5txkwjvDx/aKEshM= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-147-naYpD03ANRG8N7F5aWK1kw-1; Thu, 22 Feb 2024 03:51:04 -0500 X-MC-Unique: naYpD03ANRG8N7F5aWK1kw-1 Received: by mail-lf1-f70.google.com with SMTP id 2adb3069b0e04-512a00a2629so4795859e87.1 for ; Thu, 22 Feb 2024 00:51:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708591862; x=1709196662; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=2nFn5jCZTy1s9WBf67eU2Zf2Y/G1Fhgpl8nVuZPJzLo=; b=M+9nhT45rmTIRIxtDoQNdmiTeMOV/sUMUbvs2HLLZiW+Mh6Wmz0J6sobcQaQt7GCFM SUdDEmFKm3Kt/thix48csJIoXqHiuRWY7LdJ4jP1yRGWFgC7xIfdQIbiPzJGCW3mKd5X l89x97tTzzJjlAeFXSFUYWvIjWbCaZM/N/rt/rzWxZN+jTtKKoyRY57bQJTfE/jxDYRh R9SngWVdzMwIx84XR2OfBYsCG+rAV0lkKSBBOZDNe6WhKQU2d0bt9VVnNFJh2u/e97Go GOq/u80Bb8xYasiNRPxSpRJrrFX9nSRnCxikI2VYMJf2xSWRjIxfxtkc4vfJHNaZ+mLN 0diA== X-Forwarded-Encrypted: i=1; AJvYcCVLKZ4AwjGaHMUoZ33lti8/QSBJ6/X0BB1E7UM3yScw+xIpHC5uSUwC3PsKmvEXld5+GL2CEPRo/xcKlvM5IunCkQM= X-Gm-Message-State: AOJu0Yw/Xl6fAdH0TAwvVXxh8Pr1q/sfic2ZBdxfioNjgNwMkBbaee0z F2PB7c8vyyG9GBRplSD/CMWaAvULgvd2RbK+mNuPEtJXS0HzL/JpZ8v+veb+5WvyS3NM7RA647a e85KeeHMz7gzyMS0JRUQk1sfQ4xQzxvzTB4nAE+qLmqQ5unjj X-Received: by 2002:a19:9115:0:b0:512:d4f6:aba with SMTP id t21-20020a199115000000b00512d4f60abamr2491888lfd.0.1708591862690; Thu, 22 Feb 2024 00:51:02 -0800 (PST) X-Google-Smtp-Source: AGHT+IHKvihlLAIYg4Xo4Tso6CmcImOyTH2YZcm2QQiRHQWD5z/KlRSQgERl69V9XKNNlyQhWq1w4A== X-Received: by 2002:a19:9115:0:b0:512:d4f6:aba with SMTP id t21-20020a199115000000b00512d4f60abamr2491870lfd.0.1708591862210; Thu, 22 Feb 2024 00:51:02 -0800 (PST) Received: from ?IPV6:2003:cb:c70f:8b00:ed48:6d18:2152:1cda? (p200300cbc70f8b00ed486d1821521cda.dip0.t-ipconnect.de. [2003:cb:c70f:8b00:ed48:6d18:2152:1cda]) by smtp.gmail.com with ESMTPSA id f19-20020a05600c155300b00411ff030f06sm21647703wmg.9.2024.02.22.00.51.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Feb 2024 00:51:01 -0800 (PST) Message-ID: <84fc211a-075d-44c7-a4c3-698931b6dc7c@redhat.com> Date: Thu, 22 Feb 2024 09:51:00 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/1] mm/khugepaged: bypassing unnecessary scans with MMF_DISABLE_THP check To: Lance Yang , akpm@linux-foundation.org Cc: mhocko@suse.com, zokeefe@google.com, songmuchun@bytedance.com, shy828301@gmail.com, peterx@redhat.com, minchan@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240129054551.57728-1-ioworker0@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: 3nfnandfrbpaueyn1kxyf7b5gg938n34 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 3B053100015 X-HE-Tag: 1708591866-25694 X-HE-Meta: U2FsdGVkX198xtdEL8LO4JadDeIEo36yB+CwopakNDL7O9W1UfxPGGFb/nT863e/SjIZDhQyZpOM3o0QrtCvnBeZGlVrFLw4GiA13N96SyFOIRy/0tUVtFLJ7n+VVQITYQQt9G9jZgpRAfp2rwGgovpqBGrEdXTkx7jjRPE2xYp6ASvk3A9zoyav1UTI7JpjsJzKtonWHb5vfCvD3oHGZY1VVI8KhawlqbJoxSgUaqsRUz+iLop1P/vFSezVugpOW9FjDc6PWWBeUx6o9apsfSlcQYRft5STpsG3c4teQBrgTuFUowteeXEisWMybJNddn5hgGqBT1cBmtvZPVGSsgM2K76orsp1HbCnF2l1ZwZYyCrkzcdShMYDeVVzE8f1w1QcZdJ53WamQuHlFddM0XEFgSrzOs4o5+kF4V0ZrCc88ZM7erCWFt1OqoZuEjmAX5YZNlxoDLd6NFgDWTJnujBrlkIW86P75RgTINtjGIaxC/U6J2+zhiMx+tgsdBCNbDzoCVaVYluAOLS4RufbGnjbocjyeF2q2UybXvPTzlY+J71q81/Nl7ygmzY7AtOIzFuIoD74RNG/5M56ftsgGOMJ/dfi/DvUd3mpb9T23LV3wNFhVmfiso/I9pAMerzkUQwlN85vP2B2Sb3aQ+G3W/vVa9FmmaSzFfr4bZMyxaqgomGlDoXxJfAwJ47t+aeLz0BonsgiP8nAolnzRSgGzrqCoDNpi6XHZAaLruoMtLdMAz+wLkEachruaLFdTXJ11tZ5vPy7eKzffWBJuLp9wB8fNZgXb/Mg7cZQssAv0EbgoP8oFWpPFRAmF7zTf4EQHGWZjkn5vlwDUaK/JCVkNCdf9r2+u1MBy44zZZua9GuL4mT2GE9RtvTm3vZJJAl0nPEzOBMKy3nSDSMrezMjsgrAyC62HsS5LR5OVdK3BSkTEFyGY8DwaZFBYOrXL8lnVn2xhSFAqU7K3KhCkFZ lPAQQvUp RPZnO45bd1ubfMbiEb6H0IJTk6fQvn12RZ71M4wUA5UOze+pPjKlzoAHdfIt1L1tuDhySUFrpeZfw2Vn3vOatqyGsdCNkoHoPa8nK3w8vJCKx/ss5/zuawj5gtVotWUSqeNpiWjdkwozOSpUFhbONPxzfQZF7erQnRC2Br10lTHIdGoXy8Lgu1aNM5jll+fTZMbPFoHvUADV61eJP/Hl1KazPyA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 22.02.24 08:51, Lance Yang wrote: > Hey, > > On an Intel Core i5 CPU, the time taken by > khugepaged to scan the address space of > the process, which has been set with the > MMF_DISABLE_THP flag after being added > to the mm_slots list, is as follows (shorter is better): > > VMA Count | Old | New | Change > --------------------------------------- > 50 | 23us | 9us | -60.9% > 100 | 32us | 9us | -71.9% > 200 | 44us | 9us | -79.5% > 400 | 75us | 9us | -88.0% > 800 | 98us | 9us | -90.8% > > IIUC, once the count of VMAs for the process > exceeds page_to_scan, khugepaged needs to > wait for scan_sleep_millisecs ms before scanning > the next process. IMO, unnecessary scans could > actually be skipped with a very inexpensive > mm->flags check in this case. FWIW Acked-by: David Hildenbrand -- Cheers, David / dhildenb