From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A75DC10F25 for ; Mon, 9 Mar 2020 04:52:51 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id ED56C20665 for ; Mon, 9 Mar 2020 04:52:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ED56C20665 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=perches.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5B9CC6B0003; Mon, 9 Mar 2020 00:52:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 56A546B0006; Mon, 9 Mar 2020 00:52:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 47FA66B0007; Mon, 9 Mar 2020 00:52:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0244.hostedemail.com [216.40.44.244]) by kanga.kvack.org (Postfix) with ESMTP id 2CCDE6B0003 for ; Mon, 9 Mar 2020 00:52:50 -0400 (EDT) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id E89088248047 for ; Mon, 9 Mar 2020 04:52:49 +0000 (UTC) X-FDA: 76574603658.10.meat42_52e5d50315863 X-HE-Tag: meat42_52e5d50315863 X-Filterd-Recvd-Size: 3402 Received: from smtprelay.hostedemail.com (smtprelay0004.hostedemail.com [216.40.44.4]) by imf42.hostedemail.com (Postfix) with ESMTP for ; Mon, 9 Mar 2020 04:52:49 +0000 (UTC) Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay03.hostedemail.com (Postfix) with ESMTP id 4D777837F24A; Mon, 9 Mar 2020 04:52:49 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: note65_52936ebc40606 X-Filterd-Recvd-Size: 2288 Received: from XPS-9350.home (unknown [47.154.118.177]) (Authenticated sender: joe@perches.com) by omf19.hostedemail.com (Postfix) with ESMTPA; Mon, 9 Mar 2020 04:52:47 +0000 (UTC) Message-ID: <84f3c9891d4e89909d5537f34ea9d75de339c415.camel@perches.com> Subject: Re: [PATCH] mm: Use fallthrough; From: Joe Perches To: Sergey Senozhatsky Cc: Andrew Morton , Johannes Weiner , Michal Hocko , Vladimir Davydov , Hugh Dickins , Minchan Kim , Nitin Gupta , Sergey Senozhatsky , linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org Date: Sun, 08 Mar 2020 21:51:07 -0700 In-Reply-To: <20200309041551.GA1765@jagdpanzerIV.localdomain> References: <20200308031825.GB1125@jagdpanzerIV.localdomain> <5f297e8995b22c9ccf06d4d0a04f7d9a37d3cd77.camel@perches.com> <20200309041551.GA1765@jagdpanzerIV.localdomain> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.34.1-2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 2020-03-09 at 13:15 +0900, Sergey Senozhatsky wrote: > On (20/03/07 19:54), Joe Perches wrote: > > On Sun, 2020-03-08 at 12:18 +0900, Sergey Senozhatsky wrote: > > > On (20/03/06 23:58), Joe Perches wrote: > > > [..] > > > > --- a/mm/mempolicy.c > > > > +++ b/mm/mempolicy.c > > > > @@ -907,7 +907,6 @@ static void get_policy_nodemask(struct mempolicy *p, nodemask_t *nodes) > > > > > > > > switch (p->mode) { > > > > case MPOL_BIND: > > > > - /* Fall through */ > > > > case MPOL_INTERLEAVE: > > > > Consecutive case labels do not need an interleaving fallthrough; > > > > ie: ditto > > I see. Shall this be mentioned in the commit message, maybe? I've no real opinion about that necessity. fallthrough commments are relatively rarely used as a separating element between case labels. It's by far most common to just have consecutive case labels without any other content. It's somewhere between 500:1 to 1000:1 in the kernel.