From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F153C4345F for ; Fri, 12 Apr 2024 11:21:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C53F26B007B; Fri, 12 Apr 2024 07:21:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BDD086B0083; Fri, 12 Apr 2024 07:21:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A7D8D6B0088; Fri, 12 Apr 2024 07:21:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 89FD86B007B for ; Fri, 12 Apr 2024 07:21:30 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id EFA20C0E2D for ; Fri, 12 Apr 2024 11:21:28 +0000 (UTC) X-FDA: 82000639056.03.85FFEA4 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf01.hostedemail.com (Postfix) with ESMTP id 2F1124001E for ; Fri, 12 Apr 2024 11:21:27 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf01.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712920887; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=USddiEiFMmcmTLvueuP4TP66wot48r1cSKB5SXgylsY=; b=sIVLPqqkaC3Cq6VPv2mf4JwUouIhfBBGV/T6mrDmdvZWFYG57Eqgk99dC5dQSm4E5quuPe q26bqgSr6PxvFTmoqlhWydMz+Up09X7GyNhLfNOe88pEW1AfWUVMRkfYAZojq0QEmObvuG ZZ2EOMJXswec3qkyfP5yiwBdqn7Dq8c= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf01.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712920887; a=rsa-sha256; cv=none; b=rUdGcb53ecEMFsQFBXxyJqerex6vFBERPuVe7I0AacJw0PkyOd2YRPyQ4q+grepvgMil1O Wohz2MQY5GiPBwvgcSzY20wvg7boZrOYlq4YLA8gpkEsPP1Q2KjR2tyWMwVJsWzBTl7yHD KwFlLpz+HvoFSZw+2zLz6zsCUMDK1Sc= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 632ED339; Fri, 12 Apr 2024 04:21:55 -0700 (PDT) Received: from [10.57.73.208] (unknown [10.57.73.208]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 27AB83F766; Fri, 12 Apr 2024 04:21:24 -0700 (PDT) Message-ID: <84eca849-5da3-4272-ade6-dc0f2b3dc4b2@arm.com> Date: Fri, 12 Apr 2024 12:21:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 2/2] mm/arm64: override mkold_clean_ptes() batch helper Content-Language: en-GB To: Lance Yang Cc: akpm@linux-foundation.org, david@redhat.com, 21cnbao@gmail.com, mhocko@suse.com, fengwei.yin@intel.com, zokeefe@google.com, shy828301@gmail.com, xiehuan09@gmail.com, wangkefeng.wang@huawei.com, songmuchun@bytedance.com, peterx@redhat.com, minchan@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240408042437.10951-1-ioworker0@gmail.com> <20240408042437.10951-3-ioworker0@gmail.com> <3cd1036d-3814-4a10-b6d2-099937ceabc8@arm.com> From: Ryan Roberts In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 2F1124001E X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: k5cnmfgq6nzj4t6tws5zo4993ruwskfe X-HE-Tag: 1712920887-838542 X-HE-Meta: U2FsdGVkX1+9sd/GjToKsdAwIKHMhx8nfgIZqQGsJy32UCp2AsWxPOU5rat6ZkVf9yAcPXs4PoIkttIvSLlbdD7tQfBBHfB8wHQWJJpSOsbVQWvDma/bC0nYVmaDfLtMDU0J9S3RZHjzzGu6bEWg7+HC9Hm37Bf9QBg8VEDlzvLgUxHZVBL43L/P2PebZF0gTe2d12vU2CrQICRhzjK4T6WFgakxbNF8tTTl5w0Ts88AIGeDw4/xoihLaOWcosjAcaozxsLDGT7mhqebO6IDUGgWDA/Y7nq7tQeh/WApA2gOkVrckxyyJGn/TBZTsGyV++deyXbUbcfNFSQlSTp3fXYZ//5CbZqT1Huwc2b/Mk/2PwjeLliM0cr9Vt9W8e/OCxPECvAPRTHfTnZExc4F0WI8wlwtspFRrrctb2dKTbVVMryMYVOBUGd+W5rFYFjwZ076r6qD8esoQLSTzm9UGdMtPIJLevWBjPvuSaKvSrrueCzAOtblM+zjx74r36sNNmIwW+trmp0m2//d3Anwetbh6n3g7h0Yka8EF5gCP7AYryCFmtTy8yVrC9uMXhd4FwV8WsCYsVz0AIpuJah8i6QkV+U4rhavC9CGh+XRd9WAjEtM/I7E0/oUwT/0FVZ5Gi1q6dvBwZRGNeI4RPGSmt5BFH91Vjyx1qMki4kINIiHyQ2WWkpww+O2q6kH0EDyXp+DrxG53Qn8inbKGlRHxkEBtB/ktZC6mtjhh+2sZluXfaBV6Rwv++zUnbrWr1zC8K2uUKW9Ykg2PoPf6MeM1Eo+ljVrUqWztLKv1o7fB56FL+5s8eYYdwFTIhIu0ZszcZrBxm1+/bB7PI3VnSg8MWfqu9it0+NA8D/EpO8oFE2pG9kr9BeRBhA/nbkpxk9yAdoJO0KSbh79DOnmQI4c68P6ZkhwGCjP823wWdXmy05oEyB34UOk27wxLRnFzKpn/LwXAeGJJBvGr3OgX8Q CByzmFbt rW4WF1LQ1qUw3ta2Kp/Y1nZ78LWp4zQmQ0Cxy3LcJuFHSQ6mQefQyiPY+rqNED/tOV3Onuifm6o7pYZ1m52vOAb+QuEokUpn2CZB0zwSUpWBp/JOffvVOOgQmxbuzEjDWhW7yaD9k979JD2eQjP6ytGcIv0UiBlOe6YCz/+sII1Vlb+MUgVyge82teH+WQwcp/x81FF2hA3WiyJ7QvUmr08ctDujw6LuMwYSpSudXTLPgomjYbLbhyZZoSsl810OPk864RiBfvNR128kFquBAM/tlYxh9qwlozRkvFMotZB9Tmgm5YQxBLAqHOQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12/04/2024 03:09, Lance Yang wrote: > On Thu, Apr 11, 2024 at 9:17 PM Ryan Roberts wrote: >> >> On 08/04/2024 05:24, Lance Yang wrote: >>> The per-pte get_and_clear/modify/set approach would result in >>> unfolding/refolding for contpte mappings on arm64. So we need >>> to override mkold_clean_ptes() for arm64 to avoid it. >> >> IIRC, in the last version, I suggested copying the wrprotect_ptes() pattern to >> correctly iterate over contpte blocks. I meant for you to take it as inspiration >> but looks like you have done a carbon copy, including lots of things that are >> unneeded here. That's my fault for not being clear - sorry! > > My bad. I must have misunderstood your intention. Not at all - it was my bad. wrprotect_ptes() is nothing like what I eventually suggested below, so sorry for the bad steer.